
[ Upstream commit c592c8a28f5821e880ac6675781cd8a151b0737c ] The refcounting of the gate clocks has a bug causing the enable_refcnt to underflow when unused clocks are disabled. This happens because clk provider erroneously bumps the refcount if clock is enabled at a boot time, which it shouldn't be doing, and it does this only for the gate clocks, while peripheral clocks are using the same gate ops and the peripheral clocks are missing the initial bump. Hence the refcount of the peripheral clocks is 0 when unused clocks are disabled and then the counter is decremented further by the gate ops, causing the integer underflow. Fix this problem by removing the erroneous bump and by implementing the disable_unused() callback, which disables the unused gates properly. The visible effect of the bug is such that the unused clocks are never gated if a loaded kernel module grabs the unused clocks and starts to use them. In practice this shouldn't cause any real problems for the drivers and boards supported by the kernel today. Acked-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> Signed-off-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
185 lines
4.8 KiB
C
185 lines
4.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (c) 2012, NVIDIA CORPORATION. All rights reserved.
|
|
*/
|
|
|
|
#include <linux/clk-provider.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/io.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/err.h>
|
|
|
|
#include <soc/tegra/fuse.h>
|
|
|
|
#include "clk.h"
|
|
|
|
static DEFINE_SPINLOCK(periph_ref_lock);
|
|
|
|
/* Macros to assist peripheral gate clock */
|
|
#define read_enb(gate) \
|
|
readl_relaxed(gate->clk_base + (gate->regs->enb_reg))
|
|
#define write_enb_set(val, gate) \
|
|
writel_relaxed(val, gate->clk_base + (gate->regs->enb_set_reg))
|
|
#define write_enb_clr(val, gate) \
|
|
writel_relaxed(val, gate->clk_base + (gate->regs->enb_clr_reg))
|
|
|
|
#define read_rst(gate) \
|
|
readl_relaxed(gate->clk_base + (gate->regs->rst_reg))
|
|
#define write_rst_clr(val, gate) \
|
|
writel_relaxed(val, gate->clk_base + (gate->regs->rst_clr_reg))
|
|
|
|
#define periph_clk_to_bit(gate) (1 << (gate->clk_num % 32))
|
|
|
|
#define LVL2_CLK_GATE_OVRE 0x554
|
|
|
|
/* Peripheral gate clock ops */
|
|
static int clk_periph_is_enabled(struct clk_hw *hw)
|
|
{
|
|
struct tegra_clk_periph_gate *gate = to_clk_periph_gate(hw);
|
|
int state = 1;
|
|
|
|
if (!(read_enb(gate) & periph_clk_to_bit(gate)))
|
|
state = 0;
|
|
|
|
if (!(gate->flags & TEGRA_PERIPH_NO_RESET))
|
|
if (read_rst(gate) & periph_clk_to_bit(gate))
|
|
state = 0;
|
|
|
|
return state;
|
|
}
|
|
|
|
static void clk_periph_enable_locked(struct clk_hw *hw)
|
|
{
|
|
struct tegra_clk_periph_gate *gate = to_clk_periph_gate(hw);
|
|
|
|
write_enb_set(periph_clk_to_bit(gate), gate);
|
|
udelay(2);
|
|
|
|
if (!(gate->flags & TEGRA_PERIPH_NO_RESET) &&
|
|
!(gate->flags & TEGRA_PERIPH_MANUAL_RESET)) {
|
|
if (read_rst(gate) & periph_clk_to_bit(gate)) {
|
|
udelay(5); /* reset propogation delay */
|
|
write_rst_clr(periph_clk_to_bit(gate), gate);
|
|
}
|
|
}
|
|
|
|
if (gate->flags & TEGRA_PERIPH_WAR_1005168) {
|
|
writel_relaxed(0, gate->clk_base + LVL2_CLK_GATE_OVRE);
|
|
writel_relaxed(BIT(22), gate->clk_base + LVL2_CLK_GATE_OVRE);
|
|
udelay(1);
|
|
writel_relaxed(0, gate->clk_base + LVL2_CLK_GATE_OVRE);
|
|
}
|
|
}
|
|
|
|
static void clk_periph_disable_locked(struct clk_hw *hw)
|
|
{
|
|
struct tegra_clk_periph_gate *gate = to_clk_periph_gate(hw);
|
|
|
|
/*
|
|
* If peripheral is in the APB bus then read the APB bus to
|
|
* flush the write operation in apb bus. This will avoid the
|
|
* peripheral access after disabling clock
|
|
*/
|
|
if (gate->flags & TEGRA_PERIPH_ON_APB)
|
|
tegra_read_chipid();
|
|
|
|
write_enb_clr(periph_clk_to_bit(gate), gate);
|
|
}
|
|
|
|
static int clk_periph_enable(struct clk_hw *hw)
|
|
{
|
|
struct tegra_clk_periph_gate *gate = to_clk_periph_gate(hw);
|
|
unsigned long flags = 0;
|
|
|
|
spin_lock_irqsave(&periph_ref_lock, flags);
|
|
|
|
if (!gate->enable_refcnt[gate->clk_num]++)
|
|
clk_periph_enable_locked(hw);
|
|
|
|
spin_unlock_irqrestore(&periph_ref_lock, flags);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void clk_periph_disable(struct clk_hw *hw)
|
|
{
|
|
struct tegra_clk_periph_gate *gate = to_clk_periph_gate(hw);
|
|
unsigned long flags = 0;
|
|
|
|
spin_lock_irqsave(&periph_ref_lock, flags);
|
|
|
|
WARN_ON(!gate->enable_refcnt[gate->clk_num]);
|
|
|
|
if (--gate->enable_refcnt[gate->clk_num] == 0)
|
|
clk_periph_disable_locked(hw);
|
|
|
|
spin_unlock_irqrestore(&periph_ref_lock, flags);
|
|
}
|
|
|
|
static void clk_periph_disable_unused(struct clk_hw *hw)
|
|
{
|
|
struct tegra_clk_periph_gate *gate = to_clk_periph_gate(hw);
|
|
unsigned long flags = 0;
|
|
|
|
spin_lock_irqsave(&periph_ref_lock, flags);
|
|
|
|
/*
|
|
* Some clocks are duplicated and some of them are marked as critical,
|
|
* like fuse and fuse_burn for example, thus the enable_refcnt will
|
|
* be non-zero here if the "unused" duplicate is disabled by CCF.
|
|
*/
|
|
if (!gate->enable_refcnt[gate->clk_num])
|
|
clk_periph_disable_locked(hw);
|
|
|
|
spin_unlock_irqrestore(&periph_ref_lock, flags);
|
|
}
|
|
|
|
const struct clk_ops tegra_clk_periph_gate_ops = {
|
|
.is_enabled = clk_periph_is_enabled,
|
|
.enable = clk_periph_enable,
|
|
.disable = clk_periph_disable,
|
|
.disable_unused = clk_periph_disable_unused,
|
|
};
|
|
|
|
struct clk *tegra_clk_register_periph_gate(const char *name,
|
|
const char *parent_name, u8 gate_flags, void __iomem *clk_base,
|
|
unsigned long flags, int clk_num, int *enable_refcnt)
|
|
{
|
|
struct tegra_clk_periph_gate *gate;
|
|
struct clk *clk;
|
|
struct clk_init_data init;
|
|
const struct tegra_clk_periph_regs *pregs;
|
|
|
|
pregs = get_reg_bank(clk_num);
|
|
if (!pregs)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
gate = kzalloc(sizeof(*gate), GFP_KERNEL);
|
|
if (!gate) {
|
|
pr_err("%s: could not allocate periph gate clk\n", __func__);
|
|
return ERR_PTR(-ENOMEM);
|
|
}
|
|
|
|
init.name = name;
|
|
init.flags = flags;
|
|
init.parent_names = parent_name ? &parent_name : NULL;
|
|
init.num_parents = parent_name ? 1 : 0;
|
|
init.ops = &tegra_clk_periph_gate_ops;
|
|
|
|
gate->magic = TEGRA_CLK_PERIPH_GATE_MAGIC;
|
|
gate->clk_base = clk_base;
|
|
gate->clk_num = clk_num;
|
|
gate->flags = gate_flags;
|
|
gate->enable_refcnt = enable_refcnt;
|
|
gate->regs = pregs;
|
|
|
|
/* Data in .init is copied by clk_register(), so stack variable OK */
|
|
gate->hw.init = &init;
|
|
|
|
clk = clk_register(NULL, &gate->hw);
|
|
if (IS_ERR(clk))
|
|
kfree(gate);
|
|
|
|
return clk;
|
|
}
|