Nathan Chancellor 931971280c
drm/amdgpu: Remove unnecessary variable shadow in gfx_v9_0_rlcg_wreg ...
clang warns:
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:754:6: warning: variable 'shadow'
is used uninitialized whenever 'if' condition is
false [-Wsometimes-uninitialized]
if (offset == grbm_cntl || offset == grbm_idx)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:757:6: note: uninitialized use
occurs here
if (shadow) {
^~~~~~
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:754:2: note: remove the 'if' if
its condition is always true
if (offset == grbm_cntl || offset == grbm_idx)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:738:13: note: initialize the
variable 'shadow' to silence this warning
bool shadow;
^
= 0
1 warning generated.
shadow is only assigned in one condition and used as the condition for
another if statement; combine the two if statements and remove shadow
to make the code cleaner and resolve this warning.
Fixes: 2e0cc4d48bhttps://github.com/ClangBuiltLinux/linux/issues/936
Suggested-by: Joe Perches <joe@perches.com >
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com >
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com >
Signed-off-by: Alex Deucher <alexander.deucher@amd.com >
2020-03-19 00:03:05 -04:00
2020-01-22 16:55:27 -05:00
2016-10-25 14:38:45 -04:00
2019-06-10 23:02:48 +02:00
2019-06-10 23:02:48 +02:00
2020-03-13 11:52:35 -04:00
2019-01-14 15:04:29 -05:00
2020-02-28 16:59:20 -05:00
2020-02-28 16:59:20 -05:00
2020-02-28 16:59:20 -05:00
2020-02-28 16:59:20 -05:00
2020-02-28 16:59:20 -05:00
2020-03-10 15:54:34 -04:00
2020-03-10 15:54:34 -04:00
2020-02-28 16:59:20 -05:00
2019-12-23 14:59:20 -05:00
2017-12-18 10:58:35 -05:00
2019-12-23 14:59:20 -05:00
2019-12-23 14:59:20 -05:00
2020-01-07 11:55:56 -05:00
2019-11-06 16:27:48 -05:00
2019-06-10 23:02:48 +02:00
2019-10-17 17:12:34 -04:00
2019-05-24 12:21:02 -05:00
2019-06-10 23:02:48 +02:00
2020-02-26 14:21:13 -05:00
2020-03-13 09:09:11 +10:00
2019-10-25 11:40:50 +02:00
2018-11-05 14:21:50 -05:00
2020-03-16 16:21:32 -04:00
2020-01-30 17:15:42 -05:00
2020-03-16 16:17:55 -04:00
2020-02-28 16:59:22 -05:00
2020-03-16 16:17:55 -04:00
2020-01-22 16:34:07 -05:00
2020-02-25 11:01:25 -05:00
2019-10-17 16:31:06 -04:00
2020-02-17 10:34:34 +01:00
2019-07-30 23:48:32 -05:00
2020-02-27 14:58:01 +01:00
2019-10-28 16:59:43 +01:00
2019-07-18 14:18:05 -05:00
2020-02-26 14:17:32 -05:00
2020-03-16 16:21:32 -04:00
2020-03-09 13:50:52 -04:00
2019-10-03 09:11:05 -05:00
2020-03-06 14:19:58 +01:00
2020-02-26 14:21:12 -05:00
2019-11-13 15:29:44 -05:00
2018-11-05 14:21:16 -05:00
2019-08-12 12:47:47 -05:00
2019-11-04 09:28:51 +10:00
2019-09-16 09:59:21 -05:00
2020-03-10 15:55:11 -04:00
2020-03-09 13:51:24 -04:00
2020-01-07 12:03:47 -05:00
2020-02-25 11:30:42 -05:00
2019-06-10 23:02:48 +02:00
2019-06-10 23:02:48 +02:00
2016-09-27 13:00:52 -04:00
2020-02-26 14:21:12 -05:00
2019-12-09 17:02:07 -05:00
2019-08-13 09:09:30 +02:00
2019-11-19 10:12:54 -05:00
2019-03-19 15:36:58 -05:00
2019-06-10 23:02:48 +02:00
2019-11-19 12:09:23 -05:00
2019-02-13 17:47:11 -05:00
2020-03-09 13:51:24 -04:00
2020-01-16 13:35:10 -05:00
2019-11-19 10:12:50 -05:00
2019-12-18 16:09:12 -05:00
2020-03-10 15:55:18 -04:00
2019-06-21 18:59:28 -05:00
2020-03-10 15:55:11 -04:00
2020-03-05 00:32:40 -05:00
2019-11-23 19:56:45 -04:00
2019-11-23 19:56:45 -04:00
2020-02-13 13:08:13 +01:00
2020-03-10 15:55:11 -04:00
2019-10-15 15:49:14 -04:00
2020-03-13 09:09:11 +10:00
2020-02-26 14:21:12 -05:00
2019-06-10 23:02:48 +02:00
2020-02-26 14:21:12 -05:00
2020-02-26 14:21:12 -05:00
2020-02-11 15:35:54 -05:00
2019-06-20 11:36:22 -05:00
2020-03-19 00:03:05 -04:00
2020-03-19 00:03:05 -04:00
2020-03-16 16:21:32 -04:00
2020-03-16 16:21:32 -04:00
2020-03-13 11:52:34 -04:00
2020-03-10 15:55:02 -04:00
2020-03-09 13:51:48 -04:00
2020-03-09 13:51:48 -04:00
2019-12-03 11:57:00 -05:00
2020-03-16 16:17:55 -04:00
2019-06-10 23:02:48 +02:00
2019-06-10 22:59:53 +02:00
2019-06-10 23:00:08 +02:00
2020-03-10 15:55:11 -04:00
2020-03-05 00:32:32 -05:00
2019-06-21 18:59:34 -05:00
2020-02-04 23:30:39 -05:00
2020-02-04 23:30:39 -05:00
2019-11-06 16:27:48 -05:00
2019-06-10 23:02:48 +02:00
2019-11-22 14:55:12 -05:00
2020-03-06 14:34:18 -05:00
2020-02-28 16:59:22 -05:00
2019-11-13 15:29:42 -05:00
2020-03-19 00:03:05 -04:00
2020-03-10 15:55:11 -04:00
2020-01-07 11:58:37 -05:00
2020-02-04 23:30:39 -05:00
2018-11-26 15:47:34 -05:00
2020-01-27 16:46:45 -05:00
2019-10-25 16:15:00 -04:00
2020-03-06 14:40:30 -05:00
2020-02-11 15:10:36 -05:00
2017-10-20 13:28:44 -04:00
2017-09-28 16:03:20 -04:00
2020-01-22 16:34:14 -05:00
2020-03-16 16:17:55 -04:00
2020-02-04 23:30:39 -05:00
2020-03-16 16:21:32 -04:00
2020-03-19 00:03:04 -04:00
2020-03-16 16:21:32 -04:00
2019-10-07 15:11:07 -05:00
2020-03-10 15:55:11 -04:00
2020-03-06 14:31:28 -05:00
2020-03-16 16:17:55 -04:00
2019-10-03 09:11:05 -05:00
2020-01-22 16:55:27 -05:00
2019-08-12 12:47:48 -05:00
2020-01-22 16:55:27 -05:00
2019-06-20 21:35:29 -05:00
2020-03-06 14:31:51 -05:00
2019-06-10 23:00:01 +02:00
2019-06-10 23:04:34 +02:00
2016-05-04 20:23:53 -04:00
2020-02-26 14:21:13 -05:00
2019-06-10 23:04:34 +02:00
2018-03-14 15:39:51 -05:00
2019-11-13 15:29:44 -05:00
2016-07-14 16:39:35 -04:00
2019-01-25 16:15:36 -05:00
2019-06-10 23:04:34 +02:00
2016-10-25 14:38:45 -04:00
2019-12-23 14:55:44 -05:00
2016-10-25 14:38:45 -04:00
2020-01-14 10:18:08 -05:00
2020-01-14 10:18:08 -05:00
2017-11-27 18:29:47 -05:00
2017-12-13 17:28:08 -05:00
2019-06-20 21:16:37 -05:00
2017-01-27 12:20:41 -05:00
2019-06-10 23:04:34 +02:00
2016-10-25 14:38:45 -04:00
2020-02-13 13:08:13 +01:00
2016-10-25 14:38:45 -04:00
2020-02-13 13:08:13 +01:00
2016-10-25 14:38:45 -04:00
2020-02-13 13:08:13 +01:00
2016-10-25 14:38:45 -04:00
2020-02-13 13:08:13 +01:00
2016-10-25 14:38:45 -04:00
2020-02-28 15:40:26 +10:00
2016-10-25 14:38:45 -04:00
2020-01-14 10:18:58 -05:00
2018-04-11 13:07:54 -05:00
2020-01-22 16:34:07 -05:00
2019-06-20 11:35:45 -05:00
2018-02-19 14:19:49 -05:00
2019-11-13 15:29:46 -05:00
2016-10-25 14:38:45 -04:00
2020-02-28 16:59:21 -05:00
2017-05-31 16:48:48 -04:00
2020-03-09 13:51:48 -04:00
2017-05-31 16:48:48 -04:00
2020-03-19 00:03:05 -04:00
2017-08-15 14:46:13 -04:00
2020-03-13 11:52:33 -04:00
2020-03-05 00:32:47 -05:00
2020-03-16 16:17:55 -04:00
2019-06-21 18:59:23 -05:00
2020-01-07 12:00:33 -05:00
2018-11-05 14:21:24 -05:00
2019-12-03 11:52:11 -05:00
2018-09-10 22:46:22 -05:00
2020-03-05 00:31:54 -05:00
2019-10-03 09:11:04 -05:00
2019-09-16 09:59:29 -05:00
2016-10-25 14:38:45 -04:00
2020-01-27 16:46:45 -05:00
2016-10-25 14:38:45 -04:00
2020-01-16 13:34:27 -05:00
2016-10-25 14:38:45 -04:00
2020-03-13 11:52:34 -04:00
2020-01-07 12:03:42 -05:00
2020-01-27 16:46:44 -05:00
2019-06-20 21:35:29 -05:00
2019-06-10 23:04:34 +02:00
2016-10-25 14:38:45 -04:00
2019-12-18 16:09:07 -05:00
2019-11-19 10:12:49 -05:00
2020-03-19 00:03:05 -04:00
2019-11-19 10:12:50 -05:00
2020-03-19 00:03:05 -04:00
2019-11-19 10:12:50 -05:00
2019-12-11 15:22:08 -05:00
2019-06-10 23:04:34 +02:00
2019-06-10 23:04:34 +02:00
2020-01-22 16:36:30 -05:00
2019-06-25 08:42:25 -05:00
2019-07-08 13:56:02 -05:00
2020-03-05 00:32:40 -05:00
2019-08-12 12:47:48 -05:00
2020-03-05 00:31:54 -05:00
2019-10-03 09:11:05 -05:00
2020-03-05 00:32:40 -05:00
2019-12-03 11:08:24 -05:00
2019-12-18 16:33:26 -05:00
2020-03-06 14:34:42 -05:00
2019-12-23 15:00:00 -05:00
2019-12-11 15:22:07 -05:00
2019-12-23 15:00:01 -05:00
2019-09-16 10:09:52 -05:00
2019-04-19 11:33:27 -05:00
2017-09-26 15:14:12 -04:00
2020-03-05 00:28:34 -05:00
2019-06-20 21:35:30 -05:00
2019-10-03 09:11:05 -05:00
2019-06-20 21:16:38 -05:00
2019-10-03 09:11:05 -05:00
2019-10-03 09:11:05 -05:00
2019-10-03 09:11:05 -05:00
2019-09-13 17:11:03 -05:00
2019-09-13 17:11:03 -05:00
2019-09-13 17:11:03 -05:00
2019-09-13 17:11:03 -05:00
2019-09-13 17:11:03 -05:00
2020-02-19 10:36:26 -05:00
2019-09-13 17:11:03 -05:00
2020-03-06 14:34:49 -05:00
2019-08-02 10:30:39 -05:00
2019-06-20 21:16:38 -05:00
2018-06-15 12:20:42 -05:00
2016-07-15 12:33:31 -04:00
2020-03-19 00:03:05 -04:00
2020-03-19 00:03:05 -04:00
2018-02-19 14:18:31 -05:00
2019-11-19 12:09:13 -05:00
2018-02-19 14:18:31 -05:00
2020-03-13 11:52:33 -04:00
2018-08-27 11:10:34 -05:00
2019-11-19 12:09:13 -05:00
2019-08-12 12:47:50 -05:00
2016-08-31 15:21:09 -04:00
2019-12-23 14:55:44 -05:00
2016-10-25 14:38:45 -04:00
2019-12-23 14:55:44 -05:00
2016-10-25 14:38:45 -04:00
2020-03-05 00:32:32 -05:00
2017-03-29 23:54:45 -04:00
2020-02-26 14:17:33 -05:00
2019-06-21 18:58:21 -05:00
2020-01-22 16:55:27 -05:00
2016-10-25 14:38:45 -04:00
2019-06-10 23:04:34 +02:00
2018-03-15 09:57:50 -05:00
2018-08-27 11:10:19 -05:00
2019-11-22 14:35:10 -05:00
2016-10-25 14:38:45 -04:00
2019-06-10 23:04:34 +02:00
2019-12-17 18:47:46 +01:00
2018-02-19 14:18:08 -05:00
2018-08-27 11:10:19 -05:00
2016-09-28 16:13:17 -04:00
2020-03-16 16:21:32 -04:00
2019-08-27 09:17:35 -05:00
2020-03-16 16:17:55 -04:00
2020-03-05 00:33:01 -05:00
2020-03-16 16:17:55 -04:00
2018-06-15 12:20:34 -05:00
2019-06-11 11:51:28 -05:00
2018-11-06 14:02:41 -05:00
2019-06-10 23:04:34 +02:00
2016-10-25 14:38:45 -04:00
2019-10-03 09:11:01 -05:00
2019-10-03 09:11:01 -05:00
2020-03-06 14:32:06 -05:00
2019-12-11 15:22:07 -05:00
2019-06-14 11:44:24 +02:00
2016-10-25 14:38:45 -04:00
2020-01-22 16:55:27 -05:00
2016-10-25 14:38:45 -04:00
2020-01-22 16:55:27 -05:00
2016-10-25 14:38:45 -04:00
2019-10-17 17:12:34 -04:00
2017-03-29 23:54:47 -04:00
2019-06-14 11:44:24 +02:00
2016-10-25 14:38:45 -04:00
2020-01-22 16:55:27 -05:00
2016-10-25 14:38:45 -04:00
2020-01-22 16:55:27 -05:00
2017-03-29 23:54:47 -04:00
2020-03-19 00:03:05 -04:00
2019-12-18 16:09:07 -05:00
2020-03-19 00:03:05 -04:00
2020-01-27 16:46:44 -05:00
2020-03-19 00:03:05 -04:00
2019-07-18 14:18:05 -05:00
2020-01-22 16:55:27 -05:00
2017-03-29 23:54:46 -04:00
2019-10-03 09:11:05 -05:00
2017-03-29 23:54:30 -04:00
2019-10-03 09:11:05 -05:00
2020-01-14 10:18:08 -05:00
2020-01-14 10:18:08 -05:00
2017-11-01 19:22:00 -04:00
931971280c