Szymon Janc 83ebb9ec73 Bluetooth: Fix not registering BR/EDR SMP channel with force_bredr flag ...

If force_bredr is set SMP BR/EDR channel should also be for non-SC
capable controllers. Since hcidev flag is persistent wrt power toggle
it can be already set when calling smp_register(). This resulted in
SMP BR/EDR channel not being registered even if HCI_FORCE_BREDR_SMP
flag was set.

This also fix NULL pointer dereference when trying to disable
force_bredr after power cycle.

BUG: unable to handle kernel NULL pointer dereference at 0000000000000388
IP: [<ffffffffc0493ad8>] smp_del_chan+0x18/0x80 [bluetooth]

Call Trace:
[<ffffffffc04950ca>] force_bredr_smp_write+0xba/0x100 [bluetooth]
[<ffffffff8133be14>] full_proxy_write+0x54/0x90
[<ffffffff81245967>] __vfs_write+0x37/0x160
[<ffffffff813617f7>] ? selinux_file_permission+0xd7/0x110
[<ffffffff81356fbd>] ? security_file_permission+0x3d/0xc0
[<ffffffff810eb5b2>] ? percpu_down_read+0x12/0x50
[<ffffffff812462a5>] vfs_write+0xb5/0x1a0
[<ffffffff812476f5>] SyS_write+0x55/0xc0
[<ffffffff817eb872>] entry_SYSCALL_64_fastpath+0x1a/0xa4
Code: 48 8b 45 f0 eb c1 0f 1f 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f
      44 00 00 f6 05 c6 3b 02 00 04 55 48 89 e5 41 54 53 49 89 fc 75
      4b
      <49> 8b 9c 24 88 03 00 00 48 85 db 74 31 49 c7 84 24 88 03 00 00
RIP  [<ffffffffc0493ad8>] smp_del_chan+0x18/0x80 [bluetooth]
RSP <ffff8802aee3bd90>
CR2: 0000000000000388

Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

2016-09-19 20:19:34 +02:00

..

bnep

treewide: replace dev->trans_start update with helper

2016-05-04 14:16:49 -04:00

cmtp

Bluetooth: use list_for_each_entry*

2015-12-20 08:11:10 +01:00

hidp

Bluetooth: hidp: fix device disconnect on idle timeout

2015-10-21 00:49:23 +02:00

rfcomm

Bluetooth: use list_for_each_entry*

2015-12-20 08:11:10 +01:00

6lowpan.c

net: add netdev_lockdep_set_classes() helper

2016-06-09 13:28:37 -07:00

a2mp.c

Bluetooth: Move get info completed callback to a2mp.c

2015-07-30 13:37:22 +02:00

a2mp.h

Bluetooth: Add BT_HS config option

2015-07-30 13:31:59 +02:00

af_bluetooth.c

Bluetooth: Use numbers for subsystem version string

2016-09-19 20:19:34 +02:00

amp.c

Bluetooth: Fix breakage in amp_write_rem_assoc_frag()

2015-08-10 20:41:34 +02:00

amp.h

Bluetooth: Add BT_HS config option

2015-07-30 13:31:59 +02:00

ecc.c

Bluetooth: Add ECC library for LE Secure Connections

2014-12-03 16:51:16 +01:00

ecc.h

Bluetooth: Add ECC library for LE Secure Connections

2014-12-03 16:51:16 +01:00

hci_conn.c

Bluetooth: Rename HCI_BREDR into HCI_PRIMARY

2016-07-09 21:37:13 +03:00

hci_core.c

Bluetooth: Fix wrong New Settings event when closing HCI User Channel

2016-09-19 20:19:34 +02:00

hci_debugfs.c

Bluetooth: Add debugfs fields for hardware and firmware info

2016-07-18 09:33:28 +03:00

hci_debugfs.h

Bluetooth: Provide option to enable/disable debugfs information

2015-02-15 18:54:13 +02:00

hci_event.c

Bluetooth: Add Authentication Failed reason to Disconnected Mgmt event

2016-07-13 08:32:12 +03:00

hci_request.c

Bluetooth: Fix reason code used for rejecting SCO connections

2016-09-19 20:19:34 +02:00

hci_request.h

Bluetooth: mgmt: Fix sending redundant event for Advertising Instance

2016-09-19 20:19:34 +02:00

hci_sock.c

Bluetooth: Send control open and close messages for HCI user channels

2016-09-19 20:19:34 +02:00

hci_sysfs.c

Bluetooth: Remove controller device attributes

2016-07-09 21:37:11 +03:00

Kconfig

Bluetooth: add LED trigger for indicating HCI is powered up

2016-02-23 20:29:35 +01:00

l2cap_core.c

Bluetooth: split sk_filter in l2cap_sock_recv_cb

2016-08-24 16:55:04 +02:00

l2cap_sock.c

Bluetooth: split sk_filter in l2cap_sock_recv_cb

2016-08-24 16:55:04 +02:00

leds.c

Bluetooth: Add combined LED trigger for controller power

2016-09-19 20:19:34 +02:00

leds.h

Bluetooth: Add combined LED trigger for controller power

2016-09-19 20:19:34 +02:00

lib.c

Bluetooth: Add BT_WARN and bt_dev_warn logging macros

2015-09-24 16:25:44 +02:00

Makefile

Bluetooth: add LED trigger for indicating HCI is powered up

2016-02-23 20:29:35 +01:00

mgmt_util.c

Bluetooth: Add support for sending MGMT commands and events to monitor

2016-09-19 20:19:34 +02:00

mgmt_util.h

Bluetooth: Add generic mgmt helper API

2015-03-17 18:03:08 +01:00

mgmt.c

Bluetooth: Use kzalloc instead of kmalloc/memset

2016-09-19 20:19:34 +02:00

sco.c

bluetooth: Validate socket address length in sco_sock_bind().

2015-12-15 15:39:08 -05:00

selftest.c

Bluetooth: Export ECDH selftest result in debugfs

2015-04-02 08:47:38 +03:00

selftest.h

Bluetooth: Add support for self testing framework

2014-12-30 08:53:55 +02:00

smp.c

Bluetooth: Fix not registering BR/EDR SMP channel with force_bredr flag

2016-09-19 20:19:34 +02:00

smp.h

Bluetooth: Fix crash in SMP when unpairing

2015-10-22 09:02:03 +02:00