Kinglong Mee 834e465bba NFS: Skip checking ds_cinfo.buckets when lseg's commit_through_mds is set ...

When lseg's commit_through_mds is set, pnfs client always WARN once
in nfs_direct_select_verf after checking ds_cinfo.nbuckets.

nfs should use the DS verf except commit_through_mds is set for
layout segment where nbuckets is zero.

[17844.666094] ------------[ cut here ]------------
[17844.667071] WARNING: CPU: 0 PID: 21758 at /root/source/linux-pnfs/fs/nfs/direct.c:174 nfs_direct_select_verf+0x5a/0x70 [nfs]()
[17844.668650] Modules linked in: nfs_layout_nfsv41_files(OE) nfsv4(OE) nfs(OE) fscache(E) nfsd(OE) xfs libcrc32c btrfs ppdev coretemp crct10dif_pclmul auth_rpcgss crc32_pclmul crc32c_intel nfs_acl ghash_clmulni_intel lockd vmw_balloon xor vmw_vmci grace raid6_pq shpchp sunrpc parport_pc i2c_piix4 parport vmwgfx drm_kms_helper ttm drm serio_raw mptspi e1000 scsi_transport_spi mptscsih mptbase ata_generic pata_acpi [last unloaded: fscache]
[17844.686676] CPU: 0 PID: 21758 Comm: kworker/0:1 Tainted: G        W  OE   4.3.0-rc1-pnfs+ #245
[17844.687352] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 05/20/2014
[17844.698502] Workqueue: nfsiod rpc_async_release [sunrpc]
[17844.699212]  0000000000000009 0000000043e58010 ffff8800454fbc10 ffffffff813680c4
[17844.699990]  ffff8800454fbc48 ffffffff8108b49d ffff88004eb20000 ffff88004eb20000
[17844.700844]  ffff880062e26000 0000000000000000 0000000000000001 ffff8800454fbc58
[17844.701637] Call Trace:
[17844.725252]  [<ffffffff813680c4>] dump_stack+0x19/0x25
[17844.732693]  [<ffffffff8108b49d>] warn_slowpath_common+0x7d/0xb0
[17844.733855]  [<ffffffff8108b5da>] warn_slowpath_null+0x1a/0x20
[17844.735015]  [<ffffffffa04a27ca>] nfs_direct_select_verf+0x5a/0x70 [nfs]
[17844.735999]  [<ffffffffa04a2b83>] nfs_direct_set_hdr_verf+0x23/0x90 [nfs]
[17844.736846]  [<ffffffffa04a2e17>] nfs_direct_write_completion+0x227/0x260 [nfs]
[17844.737782]  [<ffffffffa04a433c>] nfs_pgio_release+0x1c/0x20 [nfs]
[17844.738597]  [<ffffffffa0502df3>] pnfs_generic_rw_release+0x23/0x30 [nfsv4]
[17844.739486]  [<ffffffffa01cbbea>] rpc_free_task+0x2a/0x70 [sunrpc]
[17844.740326]  [<ffffffffa01cbcd5>] rpc_async_release+0x15/0x20 [sunrpc]
[17844.741173]  [<ffffffff810a387c>] process_one_work+0x21c/0x4c0
[17844.741984]  [<ffffffff810a37cd>] ? process_one_work+0x16d/0x4c0
[17844.742837]  [<ffffffff810a3b6a>] worker_thread+0x4a/0x440
[17844.743639]  [<ffffffff810a3b20>] ? process_one_work+0x4c0/0x4c0
[17844.744399]  [<ffffffff810a3b20>] ? process_one_work+0x4c0/0x4c0
[17844.745176]  [<ffffffff810a8d75>] kthread+0xf5/0x110
[17844.745927]  [<ffffffff810a8c80>] ? kthread_create_on_node+0x240/0x240
[17844.747105]  [<ffffffff8172ce1f>] ret_from_fork+0x3f/0x70
[17844.747856]  [<ffffffff810a8c80>] ? kthread_create_on_node+0x240/0x240
[17844.748642] ---[ end trace 336a2845d42b83f0 ]---

Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

2015-09-22 18:09:14 -04:00

..

blocklayout

Merge tag 'nfs-for-4.3-1' of git://git.linux-nfs.org/projects/trondmy/linux-nfs

2015-09-07 14:02:24 -07:00

filelayout

nfs/filelayout: Fix NULL reference caused by double freeing of fh_array

2015-09-17 18:10:28 -04:00

flexfilelayout

NFSv4.1/flexfiles: Clean up ff_layout_write_done_cb/ff_layout_commit_done_cb

2015-09-02 15:24:54 -07:00

objlayout

NFSv4.1/pnfs: Separate out metadata and data consistency for pNFS

2015-03-27 12:39:38 -04:00

cache_lib.c

NFS: simplify and clean cache library

2013-02-15 10:43:36 -05:00

cache_lib.h

NFS: simplify and clean cache library

2013-02-15 10:43:36 -05:00

callback_proc.c

NFSv4: Add a tracepoint for CB_LAYOUTRECALL

2015-08-25 14:40:06 -04:00

callback_xdr.c

NFS: Convert use of __constant_htonl to htonl

2015-06-10 18:57:59 -04:00

callback.c

Merge tag 'nfs-for-4.3-1' of git://git.linux-nfs.org/projects/trondmy/linux-nfs

2015-09-07 14:02:24 -07:00

callback.h

NFS: Add in v4.2 callback operation

2013-06-08 16:20:18 -04:00

client.c

NFS: Use RPC functions for matching sockaddrs

2015-08-17 13:29:51 -05:00

delegation.c

NFSv4: Recovery of recalled read delegations is broken

2015-09-20 22:34:16 -04:00

delegation.h

NFSv4: Recovery of recalled read delegations is broken

2015-09-20 22:34:16 -04:00

dir.c

NFS: Rename nfs_readdir_free_pagearray() and nfs_readdir_large_page()

2015-08-17 13:29:31 -05:00

direct.c

NFS: Skip checking ds_cinfo.buckets when lseg's commit_through_mds is set

2015-09-22 18:09:14 -04:00

dns_resolve.c

NFS: Enabling v4.2 should not recompile nfsd and lockd

2013-11-19 16:20:40 -05:00

dns_resolve.h

NFS: DNS resolver cache per network namespace context introduced

2012-01-31 18:20:26 -05:00

file.c

NFSv4: Respect the server imposed limit on how many changes we may cache

2015-09-07 12:36:17 -04:00

fscache-index.c

NFS: Fabricate fscache server index key correctly

2014-09-25 21:25:18 -04:00

fscache.c

nfs: define nfs_inc_fscache_stats and using it as possible

2014-11-24 20:08:47 -05:00

fscache.h

NFS: Use i_writecount to control whether to get an fscache cookie in nfs_open()

2013-09-27 18:40:25 +01:00

getroot.c

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

inode.c

Revert "NFS: Make close(2) asynchronous when closing NFS O_DIRECT files"

2015-09-04 16:54:29 -04:00

internal.h

NFSv4: Respect the server imposed limit on how many changes we may cache

2015-09-07 12:36:17 -04:00

iostat.h

nfs: define nfs_inc_fscache_stats and using it as possible

2014-11-24 20:08:47 -05:00

Kconfig

kernel: conditionally support non-root users, groups and capabilities

2015-04-15 16:35:22 -07:00

Makefile

NFS: Rename idmap.c to nfs4idmap.c

2015-04-23 15:16:14 -04:00

mount_clnt.c

nfs: have nfs_mount fake up a auth_flavs list when the server didn't provide it

2013-06-28 15:51:51 -04:00

namespace.c

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

netns.h

pnfs/blocklayout: serialize GETDEVICEINFO calls

2014-11-12 14:22:52 -05:00

nfs2super.c

NFS: Convert v2 into a module

2012-07-30 19:06:41 -04:00

nfs2xdr.c

nfs: save server READ/WRITE/COMMIT status

2015-02-03 11:06:40 -08:00

nfs3_fs.h

nfsv3: introduce nfs3_set_ds_client

2015-02-03 11:06:34 -08:00

nfs3acl.c

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

nfs3client.c

nfs: set hostname when creating nfsv3 ds connection

2015-02-03 11:06:38 -08:00

nfs3proc.c

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

nfs3super.c

nfsv3: introduce nfs3_set_ds_client

2015-02-03 11:06:34 -08:00

nfs3xdr.c

xprtrdma: Fix large NFS SYMLINK calls

2015-08-05 16:21:28 -04:00

nfs4_fs.h

NFS: Remove nfs41_server_notify_{target|highest}_slotid_update()

2015-08-17 13:32:00 -05:00

nfs4client.c

NFS: Use RPC functions for matching sockaddrs

2015-08-17 13:29:51 -05:00

nfs4file.c

NFSv4: Respect the server imposed limit on how many changes we may cache

2015-09-07 12:36:17 -04:00

nfs4getroot.c

nfs: Remove invalid NFS_ATTR_FATTR_V4_REFERRAL checking in nfs4_get_rootfh

2015-07-01 11:31:22 -04:00

nfs4idmap.c

NFS: Combine nfs_idmap_{init|quit}() and nfs_idmap_{init|quit}_keyring()

2015-08-17 13:29:56 -05:00

nfs4idmap.h

NFS: Move nfs_idmap.h into fs/nfs/

2015-04-23 15:16:14 -04:00

nfs4namespace.c

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

nfs4proc.c

NFSv4.x/pnfs: Don't try to recover stateids twice in layoutget

2015-09-20 22:34:35 -04:00

nfs4renewd.c

NFSv4.1: Fix an NFSv4.1 state renewal regression

2014-09-30 17:18:42 -04:00

nfs4session.c

NFSv4.1: Don't set up a backchannel if the server didn't agree to do so

2015-02-18 12:30:47 -08:00

nfs4session.h

NFSv4.1: Clear the old state by our client id before establishing a new lease

2015-03-03 21:52:30 -05:00

nfs4state.c

Failing to send a CLOSE if file is opened WRONLY and server reboots on a 4.x mount

2015-09-17 15:48:11 -04:00

nfs4super.c

NFS: Move nfs_idmap.h into fs/nfs/

2015-04-23 15:16:14 -04:00

nfs4sysctl.c

NFS: Move nfs_idmap.h into fs/nfs/

2015-04-23 15:16:14 -04:00

nfs4trace.c

NFSv4.1: Add tracepoints for debugging slot table operations

2013-08-22 08:58:27 -04:00

nfs4trace.h

NFSv4: Add a tracepoint for CB_LAYOUTRECALL

2015-08-25 14:40:06 -04:00

nfs4xdr.c

NFSv4: Express delegation limit in units of pages

2015-09-07 12:36:13 -04:00

nfs42.h

nfs42: remove unused declaration

2015-08-25 20:06:56 -04:00

nfs42proc.c

nfs: fix v4.2 SEEK on files over 2 gigs

2015-09-17 15:48:23 -04:00

nfs42xdr.c

nfs42: decode_layoutstats does not need res parameter

2015-08-25 20:06:56 -04:00

nfs.h

NFS: Convert v4 into a module

2012-07-30 19:06:52 -04:00

nfsroot.c

NFS: a couple off by ones

2015-01-30 20:43:30 -05:00

nfstrace.c

NFSv4: Allow tracing of NFSv4 fsync calls

2015-03-27 12:39:34 -04:00

nfstrace.h

NFS: fix the handling of NFS_INO_INVALID_DATA flag in nfs_revalidate_mapping

2014-01-27 15:35:56 -05:00

pagelist.c

nfs: fix pg_test page count calculation

2015-09-17 15:48:23 -04:00

pnfs_dev.c

NFSv4.1: Don't cache deviceids that have no notifications

2015-03-27 12:32:24 -04:00

pnfs_nfs.c

NFS41: fix list splice type

2015-08-20 13:43:53 -05:00

pnfs.c

NFSv4.1/pNFS: Don't request a minimal read layout beyond the end of file

2015-08-31 02:05:47 -07:00

pnfs.h

NFSv4.1/flexfiles: Allow coalescing of new layout segments and existing ones

2015-08-25 19:42:43 -04:00

proc.c

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

read.c

NFS: Do cleanup before resetting pageio read/write to mds

2015-09-20 13:46:45 -04:00

super.c

NFS: Error out when register_shrinker fail in register_nfs_fs

2015-08-12 14:42:23 -04:00

symlink.c

don't pass nameidata to ->follow_link()

2015-05-10 22:20:15 -04:00

sysctl.c

nfs: convert use of typedef ctl_table to struct ctl_table

2014-06-06 16:08:16 -07:00

unlink.c

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

write.c

NFS: Do cleanup before resetting pageio read/write to mds

2015-09-20 13:46:45 -04:00