Lukas Wunner 81c4b5bf30 PCI: hotplug: Constify hotplug_slot_ops ...

Hotplug drivers cannot declare their hotplug_slot_ops const, making them
attractive targets for attackers, because upon registration of a hotplug
slot, __pci_hp_initialize() writes to the "owner" and "mod_name" members
in that struct.

Fix by moving these members to struct hotplug_slot and constify every
driver's hotplug_slot_ops except for pciehp.

pciehp constructs its hotplug_slot_ops at runtime based on the PCIe
port's capabilities, hence cannot declare them const.  It can be
converted to __write_rarely once that's mainlined:
http://www.openwall.com/lists/kernel-hardening/2016/11/16/3

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>  # drivers/pci/hotplug/rpa*
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> # drivers/platform/x86
Cc: Len Brown <lenb@kernel.org>
Cc: Scott Murray <scott@spiteful.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Oliver OHalloran <oliveroh@au1.ibm.com>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: Sebastian Ott <sebott@linux.vnet.ibm.com>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: Corentin Chary <corentin.chary@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>

2018-09-18 17:52:15 -05:00

..

acpi_pcihp.c

PCI: shpchp: Separate existence of SHPC and permission to use it

2018-06-26 15:38:28 -05:00

acpiphp_core.c

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

acpiphp_glue.c

PCI: Fix is_added/is_busmaster race condition

2018-07-31 11:27:54 -05:00

acpiphp_ibm.c

Merge tag 'acpi-part2-4.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm

2018-02-09 09:44:25 -08:00

acpiphp.h

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

cpci_hotplug_core.c

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

cpci_hotplug_pci.c

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

cpci_hotplug.h

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

cpcihp_generic.c

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

cpcihp_zt5550.c

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

cpcihp_zt5550.h

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

cpqphp_core.c

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

cpqphp_ctrl.c

PCI: cpqphp: Fix possible NULL pointer dereference

2018-02-28 14:35:54 -06:00

cpqphp_nvram.c

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

cpqphp_nvram.h

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

cpqphp_pci.c

Merge branch 'pci/spdx' into next

2018-02-01 11:40:07 -06:00

cpqphp_sysfs.c

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

cpqphp.h

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

ibmphp_core.c

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

ibmphp_ebda.c

PCI: hotplug: Demidlayer registration with the core

2018-07-23 17:04:13 -05:00

ibmphp_hpc.c

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

ibmphp_pci.c

Merge branch 'pci/spdx' into next

2018-02-01 11:40:07 -06:00

ibmphp_res.c

Merge branch 'pci/spdx' into next

2018-02-01 11:40:07 -06:00

ibmphp.h

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

Kconfig

PCI: shpchp: Convert SHPC to be builtin only

2018-06-02 00:18:28 -05:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

pci_hotplug_core.c

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

pciehp_core.c

PCI: pciehp: Rename controller struct members for clarity

2018-09-18 17:52:15 -05:00

pciehp_ctrl.c

PCI: pciehp: Rename controller struct members for clarity

2018-09-18 17:52:15 -05:00

pciehp_hpc.c

PCI: pciehp: Rename controller struct members for clarity

2018-09-18 17:52:15 -05:00

pciehp_pci.c

PCI: pciehp: Unify controller and slot structs

2018-09-18 17:52:15 -05:00

pciehp.h

PCI: pciehp: Reshuffle controller struct for clarity

2018-09-18 17:52:15 -05:00

pnv_php.c

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

rpadlpar_core.c

Merge tag 'pci-v4.16-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci

2018-02-06 09:59:40 -08:00

rpadlpar_sysfs.c

Merge tag 'pci-v4.16-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci

2018-02-06 09:59:40 -08:00

rpadlpar.h

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

rpaphp_core.c

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

rpaphp_pci.c

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

rpaphp_slot.c

PCI: hotplug: Demidlayer registration with the core

2018-07-23 17:04:13 -05:00

rpaphp.h

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

s390_pci_hpc.c

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

sgi_hotplug.c

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

shpchp_core.c

PCI: hotplug: Constify hotplug_slot_ops

2018-09-18 17:52:15 -05:00

shpchp_ctrl.c

PCI: Mark fall-through switch cases before enabling -Wimplicit-fallthrough

2018-07-12 16:55:57 -05:00

shpchp_hpc.c

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

shpchp_pci.c

Merge branch 'pci/spdx' into next

2018-02-01 11:40:07 -06:00

shpchp_sysfs.c

PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-28 15:49:06 -06:00

shpchp.h

PCI: shpchp: Add shpchp_is_native()

2018-06-04 12:08:06 -05:00