Yintian Tao
7c868b592d
drm/amdgpu: not remove sysfs if not create sysfs
When load amdgpu failed before create pm_sysfs and ucode_sysfs,
the pm_sysfs and ucode_sysfs should not be removed.
Otherwise, there will be warning call trace just like below.
[ 24.836386] [drm] VCE initialized successfully.
[ 24.841352] amdgpu 0000:00:07.0: amdgpu_device_ip_init failed
[ 25.370383] amdgpu 0000:00:07.0: Fatal error during GPU init
[ 25.889575] [drm] amdgpu: finishing device.
[ 26.069128] amdgpu 0000:00:07.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring kiq_2.1.0 test failed (-110)
[ 26.070110] [drm:gfx_v9_0_hw_fini [amdgpu]] *ERROR* KCQ disable failed
[ 26.200309] [TTM] Finalizing pool allocator
[ 26.200314] [TTM] Finalizing DMA pool allocator
[ 26.200349] [TTM] Zone kernel: Used memory at exit: 0 KiB
[ 26.200351] [TTM] Zone dma32: Used memory at exit: 0 KiB
[ 26.200353] [drm] amdgpu: ttm finalized
[ 26.205329] ------------[ cut here ]------------
[ 26.205330] sysfs group 'fw_version' not found for kobject '0000:00:07.0'
[ 26.205347] WARNING: CPU: 0 PID: 1228 at fs/sysfs/group.c:256 sysfs_remove_group+0x80/0x90
[ 26.205348] Modules linked in: amdgpu(OE+) gpu_sched(OE) ttm(OE) drm_kms_helper(OE) drm(OE) i2c_algo_bit fb_sys_fops syscopyarea sysfillrect sysimgblt rpcsec_gss_krb5 auth_rpcgss nfsv4 nfs lockd grace fscache binfmt_misc snd_hda_codec_generic ledtrig_audio crct10dif_pclmul snd_hda_intel crc32_pclmul snd_hda_codec ghash_clmulni_intel snd_hda_core snd_hwdep snd_pcm snd_timer input_leds snd joydev soundcore serio_raw pcspkr evbug aesni_intel aes_x86_64 crypto_simd cryptd mac_hid glue_helper sunrpc ip_tables x_tables autofs4 8139too psmouse 8139cp mii i2c_piix4 pata_acpi floppy
[ 26.205369] CPU: 0 PID: 1228 Comm: modprobe Tainted: G OE 5.2.0-rc1 #1
[ 26.205370] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Ubuntu-1.8.2-1ubuntu1 04/01/2014
[ 26.205372] RIP: 0010:sysfs_remove_group+0x80/0x90
[ 26.205374] Code: e8 35 b9 ff ff 5b 41 5c 41 5d 5d c3 48 89 df e8 f6 b5 ff ff eb c6 49 8b 55 00 49 8b 34 24 48 c7 c7 48 7a 70 98 e8 60 63 d3 ff <0f> 0b eb d7 66 90 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55
[ 26.205375] RSP: 0018:ffffbee242b0b908 EFLAGS: 00010282
[ 26.205376] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000006
[ 26.205377] RDX: 0000000000000007 RSI: 0000000000000092 RDI: ffff97ad6f817380
[ 26.205377] RBP: ffffbee242b0b920 R08: ffffffff98f520c4 R09: 00000000000002b3
[ 26.205378] R10: ffffbee242b0b8f8 R11: 00000000000002b3 R12: ffffffffc0e58240
[ 26.205379] R13: ffff97ad6d1fe0b0 R14: ffff97ad4db954c8 R15: ffff97ad4db7fff0
[ 26.205380] FS: 00007ff3d8a1c4c0(0000) GS:ffff97ad6f800000(0000) knlGS:0000000000000000
[ 26.205381] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 26.205381] CR2: 00007f9b2ef1df04 CR3: 000000042aab8001 CR4: 00000000003606f0
[ 26.205384] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 26.205385] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 26.205385] Call Trace:
[ 26.205461] amdgpu_ucode_sysfs_fini+0x18/0x20 [amdgpu]
[ 26.205518] amdgpu_device_fini+0x3b4/0x560 [amdgpu]
[ 26.205573] amdgpu_driver_unload_kms+0x4f/0xa0 [amdgpu]
[ 26.205623] amdgpu_driver_load_kms+0xcd/0x250 [amdgpu]
[ 26.205637] drm_dev_register+0x12b/0x1c0 [drm]
[ 26.205695] amdgpu_pci_probe+0x12a/0x1e0 [amdgpu]
[ 26.205699] local_pci_probe+0x47/0xa0
[ 26.205701] pci_device_probe+0x106/0x1b0
[ 26.205704] really_probe+0x21a/0x3f0
[ 26.205706] driver_probe_device+0x11c/0x140
[ 26.205707] device_driver_attach+0x58/0x60
[ 26.205709] __driver_attach+0xc3/0x140
Signed-off-by: Yintian Tao <yttao@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Nirmoy Das <nirmoy.das@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2019-12-02 17:39:05 -05:00
..
2019-12-02 17:39:05 -05:00
2019-08-28 22:11:03 +02:00
2019-10-23 11:14:11 -04:00
2019-08-14 18:31:10 +02:00
2019-08-14 19:27:26 +02:00
2019-10-17 13:59:16 +02:00
2019-10-11 18:22:50 +03:00
2019-10-24 16:12:30 +02:00
2019-10-23 18:20:05 +02:00
2019-10-24 13:55:56 +02:00
2019-10-03 16:38:50 +02:00
2019-10-28 21:12:27 +09:00
2019-08-28 22:11:03 +02:00
2019-10-24 17:59:45 +02:00
2019-10-24 16:12:36 +02:00
2019-10-21 14:23:25 +02:00
2019-10-04 17:04:05 +01:00
2019-11-06 05:46:04 +10:00
2019-10-03 16:38:50 +02:00
2019-09-19 16:24:24 -07:00
2019-10-17 23:42:02 +08:00
2019-10-03 16:38:50 +02:00
2019-10-24 14:12:21 +02:00
2019-10-10 12:50:02 +02:00
2019-06-30 09:48:05 +02:00
2019-10-17 13:59:16 +02:00
2019-10-23 18:20:31 +02:00
2019-10-14 22:19:32 +02:00
2019-10-24 14:29:48 -04:00
2019-10-23 11:14:11 -04:00
2019-10-23 12:10:05 +02:00
2019-10-29 13:01:51 -05:00
2019-10-24 13:55:56 +02:00
2019-10-25 11:40:51 +02:00
2019-07-17 12:52:55 +02:00
2019-11-26 14:51:04 -05:00
2019-10-16 00:28:32 +03:00
2019-10-23 18:21:01 +02:00
2019-06-05 20:31:04 +02:00
2019-11-07 18:08:07 -05:00
2019-10-04 13:42:33 +01:00
2019-07-15 18:11:31 +02:00
2019-06-05 20:29:57 +02:00
2019-09-16 15:14:43 +02:00
2019-09-16 15:14:10 +02:00
2019-10-10 12:50:03 +02:00
2019-07-17 12:52:55 +02:00
2019-11-01 10:49:29 +01:00
2019-10-11 09:30:53 +10:00
2019-10-17 13:59:16 +02:00
2019-11-04 09:28:51 +10:00
2019-09-08 19:04:23 +02:00
2019-09-16 15:13:02 -07:00
2019-10-17 13:59:16 +02:00
2019-10-29 13:10:07 +01:00
2019-10-23 11:14:11 -04:00
2019-08-13 09:09:30 +02:00
2019-09-24 15:54:08 -07:00
2019-10-22 11:34:03 +02:00
2019-10-10 15:45:35 +02:00
2019-10-25 11:40:50 +02:00
2019-10-24 13:55:56 +02:00
2019-07-22 21:24:10 +02:00
2019-07-19 23:24:16 +02:00
2019-07-16 11:25:02 +02:00
2019-10-03 16:38:50 +02:00
2019-09-18 18:43:36 +02:00
2019-10-03 16:38:50 +02:00
2019-09-23 15:31:53 +08:00
2019-10-09 20:04:55 +02:00
2019-06-13 13:00:29 -04:00
2019-07-15 19:04:27 -07:00
2019-10-25 09:35:06 +02:00
2019-10-03 16:38:50 +02:00
2019-08-01 15:01:29 +02:00
2019-09-20 18:46:18 +03:00
2019-09-16 15:13:02 -07:00
2019-10-03 16:38:50 +02:00
2019-06-08 16:46:37 +02:00
2019-06-13 16:39:16 +02:00
2019-10-08 09:41:06 -04:00
2019-09-30 20:17:31 +03:00
2019-06-14 16:59:51 +02:00
2019-07-16 11:25:02 +02:00
2019-07-25 16:39:35 -04:00
2019-10-08 18:29:00 +02:00
2019-10-23 18:22:10 +02:00
2019-09-03 19:30:06 -04:00
2019-11-06 05:45:29 +10:00
2019-10-03 16:38:50 +02:00
2019-09-30 20:15:53 +03:00
2019-08-07 11:56:48 -04:00
2019-10-02 16:28:55 +03:00
2019-10-23 11:14:11 -04:00
2019-08-28 22:11:03 +02:00
2019-05-30 11:26:37 -07:00
2019-10-28 10:07:54 +01:00
2019-06-21 11:48:09 +02:00
2019-07-22 16:04:53 -04:00
2019-06-19 12:07:29 +02:00
2019-08-13 09:09:30 +02:00
2019-10-29 13:29:21 -05:00
2019-10-17 13:59:16 +02:00
2019-10-25 11:40:51 +02:00
2019-10-29 13:29:21 -05:00
2019-08-06 13:18:42 +05:30
2019-06-17 17:37:01 +02:00
2019-07-22 21:24:10 +02:00
2019-09-18 18:42:21 +02:00
2019-08-22 10:41:06 +03:00
2019-06-19 12:07:29 +02:00
2019-07-16 11:25:02 +02:00
2019-07-16 11:25:02 +02:00
2019-09-30 20:16:28 +03:00
2019-10-22 15:09:15 +02:00
2019-07-30 13:07:41 +02:00
2019-10-04 13:43:43 +01:00
2019-10-23 11:00:41 +02:00
2019-09-18 11:27:18 +02:00
2019-09-19 16:24:24 -07:00
2019-07-16 12:21:41 -07:00
2019-09-20 15:03:42 -04:00
2019-07-01 16:58:09 +02:00
2019-09-08 19:04:01 +02:00
2019-10-17 13:59:16 +02:00
2019-10-02 16:28:55 +03:00
2019-09-16 15:13:53 -07:00
2019-07-16 11:25:02 +02:00
2019-09-19 10:03:32 -04:00
2019-10-24 13:55:56 +02:00
2019-10-18 12:24:56 +02:00
2019-08-06 13:16:54 +05:30
2019-09-03 09:46:18 +02:00
2019-10-08 18:43:26 -04:00
2019-07-16 11:25:02 +02:00
2019-09-12 19:54:42 +02:00
2019-09-23 15:32:53 +08:00
2019-10-30 09:51:03 +10:00
2019-10-03 16:38:50 +02:00