Li Zefan 7b574b7b01 cgroups: fix a race between cgroup_clone and umount ...

The race is calling cgroup_clone() while umounting the ns cgroup subsys,
and thus cgroup_clone() might access invalid cgroup_fs, or kill_sb() is
called after cgroup_clone() created a new dir in it.

The BUG I triggered is BUG_ON(root->number_of_cgroups != 1);

  ------------[ cut here ]------------
  kernel BUG at kernel/cgroup.c:1093!
  invalid opcode: 0000 [#1] SMP
  ...
  Process umount (pid: 5177, ti=e411e000 task=e40c4670 task.ti=e411e000)
  ...
  Call Trace:
   [<c0493df7>] ? deactivate_super+0x3f/0x51
   [<c04a3600>] ? mntput_no_expire+0xb3/0xdd
   [<c04a3ab2>] ? sys_umount+0x265/0x2ac
   [<c04a3b06>] ? sys_oldumount+0xd/0xf
   [<c0403911>] ? sysenter_do_call+0x12/0x31
  ...
  EIP: [<c0456e76>] cgroup_kill_sb+0x23/0xe0 SS:ESP 0068:e411ef2c
  ---[ end trace c766c1be3bf944ac ]---

Cc: Serge E. Hallyn <serue@us.ibm.com>
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Cc: Paul Menage <menage@google.com>
Cc: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2009-01-04 13:33:19 -08:00

..

irq

Merge branch 'cpus4096-for-linus-3' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-01-03 12:04:39 -08:00

power

cpumask: convert rest of files in kernel/

2009-01-01 10:12:28 +10:30

time

Merge branch 'cpus4096-for-linus-3' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-01-03 12:04:39 -08:00

trace

Merge branch 'cpus4096-for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-01-02 11:44:09 -08:00

.gitignore

Update kernel/.gitignore with new auto-generated files

2008-02-09 23:27:01 -08:00

acct.c

CRED: Wrap task credential accesses in the core kernel

2008-11-14 10:39:12 +11:00

audit_tree.c

Fix inotify watch removal/umount races

2008-11-15 12:26:44 -08:00

audit.c

[PATCH] fix broken timestamps in AVC generated by kernel threads

2008-12-09 02:27:41 -05:00

audit.h

[PATCH 1/2] audit: move extern declarations to audit.h

2008-04-28 06:28:04 -04:00

auditfilter.c

Fix inotify watch removal/umount races

2008-11-15 12:26:44 -08:00

auditsc.c

Merge branch 'next' into for-linus

2008-12-25 11:40:09 +11:00

backtracetest.c

backtrace: replace timer with tasklet + completions

2008-06-27 18:09:16 +02:00

bounds.c

Add kbuild.h that contains common definitions for kbuild users

2008-04-29 08:06:29 -07:00

capability.c

CRED: Inaugurate COW credentials

2008-11-14 10:39:23 +11:00

cgroup_debug.c

cgroups: fix probable race with put_css_set[_taskexit] and find_css_set

2008-10-20 08:52:38 -07:00

cgroup_freezer.c

freezer_cg: disable writing freezer.state of root cgroup

2008-11-12 17:17:16 -08:00

cgroup.c

cgroups: fix a race between cgroup_clone and umount

2009-01-04 13:33:19 -08:00

compat.c

cpumask: convert kernel/compat.c

2009-01-01 10:12:24 +10:30

configs.c

kernel/configs.c: remove useless comments

2008-10-20 08:52:34 -07:00

cpu.c

cpumask: convert kernel/cpu.c

2009-01-01 10:12:28 +10:30

cpuset.c

cpumask: change cpumask_scnprintf, cpumask_parse_user, cpulist_parse, and cpulist_scnprintf to take pointers.

2008-12-13 21:20:25 +10:30

cred-internals.h

CRED: Inaugurate COW credentials

2008-11-14 10:39:23 +11:00

cred.c

User namespaces: set of cleanups (v2)

2008-11-24 18:57:41 -05:00

delayacct.c

schedstat: consolidate per-task cpu runtime stats

2008-12-18 13:54:01 +01:00

dma-coherent.c

dma-coherent: export dma_[alloc|release]_from_coherent methods

2008-08-22 08:34:53 +02:00

dma.c

kernel/dma.c: remove a CVS keyword

2008-10-16 11:21:30 -07:00

exec_domain.c

proc: move /proc/execdomains to kernel/exec_domain.c

2008-10-23 14:30:41 +04:00

exit.c

Merge branch 'for-2.6.29' of git://git.kernel.dk/linux-2.6-block

2008-12-30 17:20:05 -08:00

extable.c

Merge branch 'core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2008-12-30 16:10:19 -08:00

fork.c

aio: make the lookup_ioctx() lockless

2008-12-29 08:29:50 +01:00

freezer.c

freezer_cg: use thaw_process() in unfreeze_cgroup()

2008-10-30 11:38:45 -07:00

futex_compat.c

CRED: Use RCU to access another task's creds and to release a task's own creds

2008-11-14 10:39:19 +11:00

futex.c

Merge branch 'core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2008-12-30 16:10:19 -08:00

hrtimer.c

Merge branch 'irq-fixes-for-linus-4' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2008-12-31 09:00:59 -08:00

itimer.c

timers: fix itimer/many thread hang

2008-09-14 16:25:35 +02:00

kallsyms.c

allow stripping of generated symbols under CONFIG_KALLSYMS_ALL

2008-12-19 22:47:10 +01:00

Kconfig.freezer

container freezer: implement freezer cgroup subsystem

2008-10-20 08:52:34 -07:00

Kconfig.hz

sched: fix SCHED_HRTICK dependency

2008-07-28 14:37:38 +02:00

Kconfig.preempt

rcu: provide RCU options on non-preempt architectures too

2008-12-25 09:31:28 +01:00

kexec.c

cpumask: prepare for iterators to only go to nr_cpu_ids/nr_cpumask_bits.: core

2009-01-01 10:12:15 +10:30

kfifo.c

…

kgdb.c

kgdb: call touch_softlockup_watchdog on resume

2008-10-06 13:50:59 -05:00

kmod.c

CRED: Inaugurate COW credentials

2008-11-14 10:39:23 +11:00

kprobes.c

kernel/kprobes.c: don't pad kretprobe_table_locks[] on uniprocessor builds

2008-11-12 17:17:17 -08:00

ksysfs.c

profiling: dynamically enable readprofile at runtime

2008-10-16 11:21:31 -07:00

kthread.c

tracepoints: add DECLARE_TRACE() and DEFINE_TRACE()

2008-11-16 09:01:36 +01:00

latencytop.c

KSYM_SYMBOL_LEN fixes

2008-12-10 08:01:54 -08:00

lockdep_internals.h

lockdep: build fix

2008-08-13 12:55:10 +02:00

lockdep_proc.c

lockstat: contend with points

2008-10-20 15:43:10 +02:00

lockdep.c

Merge branch 'core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2008-12-30 16:10:19 -08:00

Makefile

Merge branch 'core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2008-12-30 16:10:19 -08:00

marker.c

markers/tracpoints: fix non-modular build

2008-11-16 09:52:03 +01:00

module.c

tracing/function-graph-tracer: introduce __notrace_funcgraph to filter special functions

2008-12-08 15:11:44 +01:00

mutex-debug.c

mutex-debug: check mutex magic before owner

2008-05-16 16:53:35 +02:00

mutex-debug.h

…

mutex.c

mutex: __used is needed for function referenced only from inline asm

2008-11-24 10:00:28 +01:00

mutex.h

…

notifier.c

Merge commit 'v2.6.28-rc6' into core/debug

2008-11-26 08:22:50 +01:00

ns_cgroup.c

cgroup_clone: use pid of newly created task for new cgroup

2008-07-25 10:53:37 -07:00

nsproxy.c

User namespaces: set of cleanups (v2)

2008-11-24 18:57:41 -05:00

panic.c

Merge branch 'core/debug' into core/core

2008-12-25 13:53:11 +01:00

params.c

Fix compile warning in kernel/params.c

2008-10-23 12:09:00 -07:00

pid_namespace.c

pid_ns: (BUG 11391) change ->child_reaper when init->group_leader exits

2008-09-02 19:21:38 -07:00

pid.c

pidns: remove now unused find_pid function.

2008-07-25 10:53:45 -07:00

pm_qos_params.c

pm_qos_requirement might sleep

2008-09-02 19:21:40 -07:00

posix-cpu-timers.c

Merge commit 'v2.6.28' into core/core

2008-12-25 13:51:46 +01:00

posix-timers.c

Merge branches 'timers/clocksource', 'timers/hpet', 'timers/hrtimers', 'timers/nohz', 'timers/ntp', 'timers/posixtimers' and 'timers/rtc' into timers/core

2008-12-25 18:02:25 +01:00

printk.c

printk: fix discarding message when recursion_bug

2008-12-19 22:52:47 +01:00

profile.c

cpumask: convert kernel/profile.c

2009-01-01 10:12:27 +10:30

ptrace.c

Merge branch 'tracing-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2008-12-28 12:21:10 -08:00

rcuclassic.c

cpumask: convert RCU implementations, fix

2009-01-03 18:59:25 +01:00

rcupdate.c

rcupdate: fix bug of rcu_barrier*()

2008-10-21 15:59:53 +02:00

rcupreempt_trace.c

"Tree RCU": scalable classic RCU implementation

2008-12-18 21:56:04 +01:00

rcupreempt.c

cpumask: convert RCU implementations

2009-01-01 10:12:26 +10:30

rcutorture.c

cpumask: convert RCU implementations

2009-01-01 10:12:26 +10:30

rcutree_trace.c

"Tree RCU": scalable classic RCU implementation

2008-12-18 21:56:04 +01:00

rcutree.c

"Tree RCU": scalable classic RCU implementation

2008-12-18 21:56:04 +01:00

relay.c

relayfs: fix infinite loop with splice()

2008-12-10 08:01:52 -08:00

res_counter.c

cgroup files: convert res_counter_write() to be a cgroups write_string() handler

2008-07-25 10:53:36 -07:00

resource.c

resources: skip sanity check of busy resources

2008-12-16 23:30:49 +01:00

rtmutex_common.h

Don't operate with pid_t in rtmutex tester

2008-02-08 09:22:41 -08:00

rtmutex-debug.c

Don't operate with pid_t in rtmutex tester

2008-02-08 09:22:41 -08:00

rtmutex-debug.h

…

rtmutex-tester.c

sysdev: Pass the attribute to the low level sysdev show/store function

2008-07-21 21:55:02 -07:00

rtmutex.c

hrtimer: convert kernel/* to the new hrtimer apis

2008-09-05 21:35:13 -07:00

rtmutex.h

…

rwsem.c

sched: mark rwsem functions as __sched for wchan/profiling

2007-12-18 15:21:13 +01:00

sched_clock.c

Revert "sched_clock: prevent scd->clock from moving backwards"

2008-12-14 16:23:17 -08:00

sched_cpupri.c

sched: convert struct cpupri_vec cpumask_var_t.

2008-11-24 17:52:22 +01:00

sched_cpupri.h

sched: convert struct cpupri_vec cpumask_var_t.

2008-11-24 17:52:22 +01:00

sched_debug.c

sched: add uid information to sched_debug for CONFIG_USER_SCHED

2008-12-01 20:39:50 +01:00

sched_fair.c

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-cpumask into merge-rr-cpumask

2009-01-03 18:53:31 +01:00

sched_features.h

sched: backward looking buddy

2008-11-05 10:30:14 +01:00

sched_idletask.c

sched: add CONFIG_SMP consistency

2008-10-22 10:01:52 +02:00

sched_rt.c

sched: put back some stack hog changes that were undone in kernel/sched.c

2009-01-03 19:00:09 +01:00

sched_stats.h

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-cpumask into merge-rr-cpumask

2009-01-03 18:53:31 +01:00

sched.c

Merge branch 'cpus4096-for-linus-3' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-01-03 12:04:39 -08:00

seccomp.c

…

semaphore.c

semaphore: __down_common: use signal_pending_state()

2008-08-05 14:33:47 -07:00

signal.c

Merge branch 'tracing-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2008-12-28 12:21:10 -08:00

smp.c

cpumask: prepare for iterators to only go to nr_cpu_ids/nr_cpumask_bits.: core

2009-01-01 10:12:15 +10:30

softirq.c

Merge branch 'cpus4096-for-linus-3' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-01-03 12:04:39 -08:00

softlockup.c

cpumask: convert rest of files in kernel/

2009-01-01 10:12:28 +10:30

spinlock.c

lockdep: spin_lock_nest_lock(), checkpatch fixes

2008-08-13 13:56:51 +02:00

srcu.c

make srcu_readers_active() static

2008-02-06 10:41:02 -08:00

stacktrace.c

stacktrace: provide save_stack_trace_tsk() weak alias

2008-12-25 11:44:43 +01:00

stop_machine.c

cpumask: convert rest of files in kernel/

2009-01-01 10:12:28 +10:30

sys_ni.c

reintroduce accept4

2008-11-19 18:49:57 -08:00

sys.c

Merge branch 'core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2008-12-30 16:10:19 -08:00

sysctl_check.c

[XFS] remove restricted chown parameter from xfs linux

2008-10-30 18:30:09 +11:00

sysctl.c

Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux-2.6

2008-12-28 20:19:47 -08:00

taskstats.c

cpumask: convert rest of files in kernel/

2009-01-01 10:12:28 +10:30

test_kprobes.c

kprobes: kretprobe user entry-handler

2008-02-06 10:41:11 -08:00

time.c

select: add a timespec_add_safe() function

2008-09-05 21:34:57 -07:00

timeconst.pl

Make constants in kernel/timeconst.h fixed 64 bits

2008-05-02 16:18:42 -07:00

timer.c

[PATCH] idle cputime accounting

2008-12-31 15:11:46 +01:00

tracepoint.c

markers/tracpoints: fix non-modular build

2008-11-16 09:52:03 +01:00

tsacct.c

CRED: Use RCU to access another task's creds and to release a task's own creds

2008-11-14 10:39:19 +11:00

uid16.c

CRED: Wrap current->cred and a few other accessors

2008-11-14 10:39:18 +11:00

user_namespace.c

User namespaces: set of cleanups (v2)

2008-11-24 18:57:41 -05:00

user.c

Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2008-12-28 12:27:58 -08:00

utsname_sysctl.c

sysctl: simplify ->strategy

2008-10-16 11:21:47 -07:00

utsname.c

removed unused #include <linux/version.h>'s

2008-08-23 12:14:12 -07:00

wait.c

wait: kill is_sync_wait()

2008-10-16 11:21:31 -07:00

workqueue.c

cpumask: convert kernel/workqueue.c

2009-01-01 10:12:25 +10:30