
The aim of this locking rework is that ioctls which a compositor should be might call for every frame (set_cursor, page_flip, addfb, rmfb and getfb/create_handle) should not be able to block on kms background activities like output detection. And since each EDID read takes about 25ms (in the best case), that always means we'll drop at least one frame. The solution is to add per-crtc locking for these ioctls, and restrict background activities to only use the global lock. Change-the-world type of events (modeset, dpms, ...) need to grab all locks. Two tricky parts arose in the conversion: - A lot of current code assumes that a kms fb object can't disappear while holding the global lock, since the current code serializes fb destruction with it. Hence proper lifetime management using the already created refcounting for fbs need to be instantiated for all ioctls and interfaces/users. - The rmfb ioctl removes the to-be-deleted fb from all active users. But unconditionally taking the global kms lock to do so introduces an unacceptable potential stall point. And obviously changing the userspace abi isn't on the table, either. Hence this conversion opportunistically checks whether the rmfb ioctl holds the very last reference, which guarantees that the fb isn't in active use on any crtc or plane (thanks to the conversion to the new lifetime rules using proper refcounting). Only if this is not the case will the code go through the slowpath and grab all modeset locks. Sane compositors will never hit this path and so avoid the stall, but userspace relying on these semantics will also not break. All these cases are exercised by the newly added subtests for the i-g-t kms_flip, tested on a machine where a full detect cycle takes around 100 ms. It works, and no frames are dropped any more with these patches applied. kms_flip also contains a special case to exercise the above-describe rmfb slowpath. * 'drm-kms-locking' of git://people.freedesktop.org/~danvet/drm-intel: (335 commits) drm/fb_helper: check whether fbcon is bound drm/doc: updates for new framebuffer lifetime rules drm: don't hold crtc mutexes for connector ->detect callbacks drm: only grab the crtc lock for pageflips drm: optimize drm_framebuffer_remove drm/vmwgfx: add proper framebuffer refcounting drm/i915: dump refcount into framebuffer debugfs file drm: refcounting for crtc framebuffers drm: refcounting for sprite framebuffers drm: fb refcounting for dirtyfb_ioctl drm: don't take modeset locks in getfb ioctl drm: push modeset_lock_all into ->fb_create driver callbacks drm: nest modeset locks within fpriv->fbs_lock drm: reference framebuffers which are on the idr drm: revamp framebuffer cleanup interfaces drm: create drm_framebuffer_lookup drm: revamp locking around fb creation/destruction drm: only take the crtc lock for ->cursor_move drm: only take the crtc lock for ->cursor_set drm: add per-crtc locks ...
313 lines
8.2 KiB
C
313 lines
8.2 KiB
C
/*
|
|
* Copyright © 2007 David Airlie
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* Authors:
|
|
* David Airlie
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/string.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/tty.h>
|
|
#include <linux/sysrq.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/fb.h>
|
|
#include <linux/init.h>
|
|
#include <linux/vga_switcheroo.h>
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/drm_crtc.h>
|
|
#include <drm/drm_fb_helper.h>
|
|
#include "intel_drv.h"
|
|
#include <drm/i915_drm.h>
|
|
#include "i915_drv.h"
|
|
|
|
static struct fb_ops intelfb_ops = {
|
|
.owner = THIS_MODULE,
|
|
.fb_check_var = drm_fb_helper_check_var,
|
|
.fb_set_par = drm_fb_helper_set_par,
|
|
.fb_fillrect = cfb_fillrect,
|
|
.fb_copyarea = cfb_copyarea,
|
|
.fb_imageblit = cfb_imageblit,
|
|
.fb_pan_display = drm_fb_helper_pan_display,
|
|
.fb_blank = drm_fb_helper_blank,
|
|
.fb_setcmap = drm_fb_helper_setcmap,
|
|
.fb_debug_enter = drm_fb_helper_debug_enter,
|
|
.fb_debug_leave = drm_fb_helper_debug_leave,
|
|
};
|
|
|
|
static int intelfb_create(struct intel_fbdev *ifbdev,
|
|
struct drm_fb_helper_surface_size *sizes)
|
|
{
|
|
struct drm_device *dev = ifbdev->helper.dev;
|
|
struct drm_i915_private *dev_priv = dev->dev_private;
|
|
struct fb_info *info;
|
|
struct drm_framebuffer *fb;
|
|
struct drm_mode_fb_cmd2 mode_cmd = {};
|
|
struct drm_i915_gem_object *obj;
|
|
struct device *device = &dev->pdev->dev;
|
|
int size, ret;
|
|
|
|
/* we don't do packed 24bpp */
|
|
if (sizes->surface_bpp == 24)
|
|
sizes->surface_bpp = 32;
|
|
|
|
mode_cmd.width = sizes->surface_width;
|
|
mode_cmd.height = sizes->surface_height;
|
|
|
|
mode_cmd.pitches[0] = ALIGN(mode_cmd.width * ((sizes->surface_bpp + 7) /
|
|
8), 64);
|
|
mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp,
|
|
sizes->surface_depth);
|
|
|
|
size = mode_cmd.pitches[0] * mode_cmd.height;
|
|
size = ALIGN(size, PAGE_SIZE);
|
|
obj = i915_gem_object_create_stolen(dev, size);
|
|
if (obj == NULL)
|
|
obj = i915_gem_alloc_object(dev, size);
|
|
if (!obj) {
|
|
DRM_ERROR("failed to allocate framebuffer\n");
|
|
ret = -ENOMEM;
|
|
goto out;
|
|
}
|
|
|
|
mutex_lock(&dev->struct_mutex);
|
|
|
|
/* Flush everything out, we'll be doing GTT only from now on */
|
|
ret = intel_pin_and_fence_fb_obj(dev, obj, NULL);
|
|
if (ret) {
|
|
DRM_ERROR("failed to pin fb: %d\n", ret);
|
|
goto out_unref;
|
|
}
|
|
|
|
info = framebuffer_alloc(0, device);
|
|
if (!info) {
|
|
ret = -ENOMEM;
|
|
goto out_unpin;
|
|
}
|
|
|
|
info->par = ifbdev;
|
|
|
|
ret = intel_framebuffer_init(dev, &ifbdev->ifb, &mode_cmd, obj);
|
|
if (ret)
|
|
goto out_unpin;
|
|
|
|
fb = &ifbdev->ifb.base;
|
|
|
|
ifbdev->helper.fb = fb;
|
|
ifbdev->helper.fbdev = info;
|
|
|
|
strcpy(info->fix.id, "inteldrmfb");
|
|
|
|
info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
|
|
info->fbops = &intelfb_ops;
|
|
|
|
ret = fb_alloc_cmap(&info->cmap, 256, 0);
|
|
if (ret) {
|
|
ret = -ENOMEM;
|
|
goto out_unpin;
|
|
}
|
|
/* setup aperture base/size for vesafb takeover */
|
|
info->apertures = alloc_apertures(1);
|
|
if (!info->apertures) {
|
|
ret = -ENOMEM;
|
|
goto out_unpin;
|
|
}
|
|
info->apertures->ranges[0].base = dev->mode_config.fb_base;
|
|
info->apertures->ranges[0].size =
|
|
dev_priv->mm.gtt->gtt_mappable_entries << PAGE_SHIFT;
|
|
|
|
info->fix.smem_start = dev->mode_config.fb_base + obj->gtt_offset;
|
|
info->fix.smem_len = size;
|
|
|
|
info->screen_base =
|
|
ioremap_wc(dev_priv->mm.gtt_base_addr + obj->gtt_offset,
|
|
size);
|
|
if (!info->screen_base) {
|
|
ret = -ENOSPC;
|
|
goto out_unpin;
|
|
}
|
|
info->screen_size = size;
|
|
|
|
// memset(info->screen_base, 0, size);
|
|
|
|
drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth);
|
|
drm_fb_helper_fill_var(info, &ifbdev->helper, sizes->fb_width, sizes->fb_height);
|
|
|
|
/* If the object is shmemfs backed, it will have given us zeroed pages.
|
|
* If the object is stolen however, it will be full of whatever
|
|
* garbage was left in there.
|
|
*/
|
|
if (ifbdev->ifb.obj->stolen)
|
|
memset_io(info->screen_base, 0, info->screen_size);
|
|
|
|
/* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */
|
|
|
|
DRM_DEBUG_KMS("allocated %dx%d fb: 0x%08x, bo %p\n",
|
|
fb->width, fb->height,
|
|
obj->gtt_offset, obj);
|
|
|
|
|
|
mutex_unlock(&dev->struct_mutex);
|
|
vga_switcheroo_client_fb_set(dev->pdev, info);
|
|
return 0;
|
|
|
|
out_unpin:
|
|
i915_gem_object_unpin(obj);
|
|
out_unref:
|
|
drm_gem_object_unreference(&obj->base);
|
|
mutex_unlock(&dev->struct_mutex);
|
|
out:
|
|
return ret;
|
|
}
|
|
|
|
static int intel_fb_find_or_create_single(struct drm_fb_helper *helper,
|
|
struct drm_fb_helper_surface_size *sizes)
|
|
{
|
|
struct intel_fbdev *ifbdev = (struct intel_fbdev *)helper;
|
|
int new_fb = 0;
|
|
int ret;
|
|
|
|
if (!helper->fb) {
|
|
ret = intelfb_create(ifbdev, sizes);
|
|
if (ret)
|
|
return ret;
|
|
new_fb = 1;
|
|
}
|
|
return new_fb;
|
|
}
|
|
|
|
static struct drm_fb_helper_funcs intel_fb_helper_funcs = {
|
|
.gamma_set = intel_crtc_fb_gamma_set,
|
|
.gamma_get = intel_crtc_fb_gamma_get,
|
|
.fb_probe = intel_fb_find_or_create_single,
|
|
};
|
|
|
|
static void intel_fbdev_destroy(struct drm_device *dev,
|
|
struct intel_fbdev *ifbdev)
|
|
{
|
|
struct fb_info *info;
|
|
struct intel_framebuffer *ifb = &ifbdev->ifb;
|
|
|
|
if (ifbdev->helper.fbdev) {
|
|
info = ifbdev->helper.fbdev;
|
|
unregister_framebuffer(info);
|
|
iounmap(info->screen_base);
|
|
if (info->cmap.len)
|
|
fb_dealloc_cmap(&info->cmap);
|
|
framebuffer_release(info);
|
|
}
|
|
|
|
drm_fb_helper_fini(&ifbdev->helper);
|
|
|
|
drm_framebuffer_unregister_private(&ifb->base);
|
|
drm_framebuffer_cleanup(&ifb->base);
|
|
if (ifb->obj) {
|
|
drm_gem_object_unreference_unlocked(&ifb->obj->base);
|
|
ifb->obj = NULL;
|
|
}
|
|
}
|
|
|
|
int intel_fbdev_init(struct drm_device *dev)
|
|
{
|
|
struct intel_fbdev *ifbdev;
|
|
drm_i915_private_t *dev_priv = dev->dev_private;
|
|
int ret;
|
|
|
|
ifbdev = kzalloc(sizeof(struct intel_fbdev), GFP_KERNEL);
|
|
if (!ifbdev)
|
|
return -ENOMEM;
|
|
|
|
dev_priv->fbdev = ifbdev;
|
|
ifbdev->helper.funcs = &intel_fb_helper_funcs;
|
|
|
|
ret = drm_fb_helper_init(dev, &ifbdev->helper,
|
|
dev_priv->num_pipe,
|
|
INTELFB_CONN_LIMIT);
|
|
if (ret) {
|
|
kfree(ifbdev);
|
|
return ret;
|
|
}
|
|
|
|
drm_fb_helper_single_add_all_connectors(&ifbdev->helper);
|
|
|
|
return 0;
|
|
}
|
|
|
|
void intel_fbdev_initial_config(struct drm_device *dev)
|
|
{
|
|
drm_i915_private_t *dev_priv = dev->dev_private;
|
|
|
|
/* Due to peculiar init order wrt to hpd handling this is separate. */
|
|
drm_fb_helper_initial_config(&dev_priv->fbdev->helper, 32);
|
|
}
|
|
|
|
void intel_fbdev_fini(struct drm_device *dev)
|
|
{
|
|
drm_i915_private_t *dev_priv = dev->dev_private;
|
|
if (!dev_priv->fbdev)
|
|
return;
|
|
|
|
intel_fbdev_destroy(dev, dev_priv->fbdev);
|
|
kfree(dev_priv->fbdev);
|
|
dev_priv->fbdev = NULL;
|
|
}
|
|
|
|
void intel_fbdev_set_suspend(struct drm_device *dev, int state)
|
|
{
|
|
drm_i915_private_t *dev_priv = dev->dev_private;
|
|
if (!dev_priv->fbdev)
|
|
return;
|
|
|
|
fb_set_suspend(dev_priv->fbdev->helper.fbdev, state);
|
|
}
|
|
|
|
MODULE_LICENSE("GPL and additional rights");
|
|
|
|
void intel_fb_output_poll_changed(struct drm_device *dev)
|
|
{
|
|
drm_i915_private_t *dev_priv = dev->dev_private;
|
|
drm_fb_helper_hotplug_event(&dev_priv->fbdev->helper);
|
|
}
|
|
|
|
void intel_fb_restore_mode(struct drm_device *dev)
|
|
{
|
|
int ret;
|
|
drm_i915_private_t *dev_priv = dev->dev_private;
|
|
struct drm_mode_config *config = &dev->mode_config;
|
|
struct drm_plane *plane;
|
|
|
|
drm_modeset_lock_all(dev);
|
|
|
|
ret = drm_fb_helper_restore_fbdev_mode(&dev_priv->fbdev->helper);
|
|
if (ret)
|
|
DRM_DEBUG("failed to restore crtc mode\n");
|
|
|
|
/* Be sure to shut off any planes that may be active */
|
|
list_for_each_entry(plane, &config->plane_list, head)
|
|
plane->funcs->disable_plane(plane);
|
|
|
|
drm_modeset_unlock_all(dev);
|
|
}
|