Files
android_kernel_xiaomi_sm8450/drivers/scsi
Iustin Pop 6f46f718fc scsi: st: osst: Remove negative constant left-shifts
Negative constant left-shift is undefined behaviour in the C standard, and
as such newer versions of clang (at least) warn against it. GCC supports it
for a long time, but it would be better to remove it and rely on defined
behaviour.

My understanding is "~(-1 << N)" in 2's complement is intended to generate
a bit pattern of zeroes ending with N '1' bits. The same can be achieved by
"(1 << N) - 1" in a well-defined way, so switch to it to remove the
warning.

Tested: building a kernel with generic SCSI tape, and checking basic
operations (mt status, mt eject) on a real LTO unit. Cannot test the osst
driver.

Signed-off-by: Iustin Pop <iustin@k1024.org>
Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2019-02-27 09:10:16 -05:00
..
2018-12-18 23:19:21 -05:00
2017-12-04 20:32:53 -05:00
2018-12-18 23:19:21 -05:00
2018-12-18 23:19:21 -05:00
2018-06-19 22:02:25 -04:00
2018-12-18 23:19:21 -05:00
2019-01-08 21:58:35 -05:00
2019-01-08 21:58:35 -05:00
2019-01-08 21:58:35 -05:00
2018-12-18 23:19:21 -05:00
2018-12-18 23:13:12 -05:00
2018-12-18 23:19:21 -05:00
2018-11-06 21:31:28 -05:00
2019-02-05 21:28:52 -05:00
2018-12-18 23:19:21 -05:00
2019-02-05 21:28:52 -05:00
2018-12-18 23:13:12 -05:00
2018-12-18 23:19:21 -05:00
2018-12-18 23:13:12 -05:00
2018-11-07 13:42:32 -07:00
2018-11-07 13:42:32 -07:00
2018-11-07 13:42:32 -07:00
2018-11-07 13:42:32 -07:00
2018-11-07 13:42:32 -07:00
2018-06-19 22:02:25 -04:00
2019-02-12 22:33:00 -05:00
2018-06-12 16:19:22 -07:00
2018-12-18 23:19:21 -05:00
2019-02-05 21:29:49 -05:00
2018-12-18 23:19:21 -05:00