Eric Dumazet
c3f9b01849
tcp: tcp_release_cb() should release socket ownership
Lars Persson reported following deadlock :
-000 |M:0x0:0x802B6AF8(asm) <-- arch_spin_lock
-001 |tcp_v4_rcv(skb = 0x8BD527A0) <-- sk = 0x8BE6B2A0
-002 |ip_local_deliver_finish(skb = 0x8BD527A0)
-003 |__netif_receive_skb_core(skb = 0x8BD527A0, ?)
-004 |netif_receive_skb(skb = 0x8BD527A0)
-005 |elk_poll(napi = 0x8C770500, budget = 64)
-006 |net_rx_action(?)
-007 |__do_softirq()
-008 |do_softirq()
-009 |local_bh_enable()
-010 |tcp_rcv_established(sk = 0x8BE6B2A0, skb = 0x87D3A9E0, th = 0x814EBE14, ?)
-011 |tcp_v4_do_rcv(sk = 0x8BE6B2A0, skb = 0x87D3A9E0)
-012 |tcp_delack_timer_handler(sk = 0x8BE6B2A0)
-013 |tcp_release_cb(sk = 0x8BE6B2A0)
-014 |release_sock(sk = 0x8BE6B2A0)
-015 |tcp_sendmsg(?, sk = 0x8BE6B2A0, ?, ?)
-016 |sock_sendmsg(sock = 0x8518C4C0, msg = 0x87D8DAA8, size = 4096)
-017 |kernel_sendmsg(?, ?, ?, ?, size = 4096)
-018 |smb_send_kvec()
-019 |smb_send_rqst(server = 0x87C4D400, rqst = 0x87D8DBA0)
-020 |cifs_call_async()
-021 |cifs_async_writev(wdata = 0x87FD6580)
-022 |cifs_writepages(mapping = 0x852096E4, wbc = 0x87D8DC88)
-023 |__writeback_single_inode(inode = 0x852095D0, wbc = 0x87D8DC88)
-024 |writeback_sb_inodes(sb = 0x87D6D800, wb = 0x87E4A9C0, work = 0x87D8DD88)
-025 |__writeback_inodes_wb(wb = 0x87E4A9C0, work = 0x87D8DD88)
-026 |wb_writeback(wb = 0x87E4A9C0, work = 0x87D8DD88)
-027 |wb_do_writeback(wb = 0x87E4A9C0, force_wait = 0)
-028 |bdi_writeback_workfn(work = 0x87E4A9CC)
-029 |process_one_work(worker = 0x8B045880, work = 0x87E4A9CC)
-030 |worker_thread(__worker = 0x8B045880)
-031 |kthread(_create = 0x87CADD90)
-032 |ret_from_kernel_thread(asm)
Bug occurs because __tcp_checksum_complete_user() enables BH, assuming
it is running from softirq context.
Lars trace involved a NIC without RX checksum support but other points
are problematic as well, like the prequeue stuff.
Problem is triggered by a timer, that found socket being owned by user.
tcp_release_cb() should call tcp_write_timer_handler() or
tcp_delack_timer_handler() in the appropriate context :
BH disabled and socket lock held, but 'owned' field cleared,
as if they were running from timer handlers.
Fixes: 6f458dfb40
("tcp: improve latencies of timer triggered events")
Reported-by: Lars Persson <lars.persson@axis.com>
Tested-by: Lars Persson <lars.persson@axis.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-03-11 16:45:59 -04:00
..
2013-09-11 12:34:13 -07:00
2014-01-04 20:10:40 +02:00
2013-09-23 16:29:41 -04:00
2013-12-06 12:37:56 -05:00
2013-04-08 17:16:57 -04:00
2014-02-06 11:46:06 +01:00
2014-01-19 17:12:31 -08:00
2014-01-17 14:43:17 -05:00
2012-06-17 16:29:38 -07:00
2014-02-17 00:16:56 -05:00
2013-12-06 12:37:56 -05:00
2014-01-21 14:43:16 -08:00
2014-01-22 21:57:05 -08:00
2009-08-12 21:54:50 -07:00
2013-07-31 17:50:01 -07:00
2013-08-10 01:16:44 -07:00
2013-07-27 22:14:06 -07:00
2011-01-13 21:48:25 -08:00
2013-12-28 17:02:46 -05:00
2011-11-30 18:51:03 -05:00
2013-07-31 17:50:02 -07:00
2009-03-24 23:32:03 -07:00
2014-01-13 17:39:11 +01:00
2011-08-08 14:26:29 -04:00
2014-01-09 14:24:24 +01:00
2013-11-04 15:27:08 -05:00
2013-12-10 17:56:54 -05:00
2014-01-03 23:41:41 +01:00
2014-01-21 23:17:20 -08:00
2013-09-20 14:49:32 -04:00
2014-02-09 17:32:50 -08:00
2013-12-06 12:37:56 -05:00
2013-12-06 12:37:56 -05:00
2013-12-10 21:50:00 -05:00
2013-09-20 14:49:32 -04:00
2013-09-20 14:49:32 -04:00
2013-09-20 14:49:32 -04:00
2014-02-09 17:32:49 -08:00
2014-02-09 17:32:49 -08:00
2011-12-01 11:41:06 -05:00
2013-01-09 23:59:53 -08:00
2012-07-19 10:43:03 -07:00
2013-12-17 16:36:21 -05:00
2013-11-07 19:28:58 -05:00
2014-02-04 20:19:51 -08:00
2013-09-20 14:49:33 -04:00
2013-03-26 12:32:13 -04:00
2013-10-03 15:36:37 -04:00
2013-12-06 07:24:39 +01:00
2013-09-20 14:49:33 -04:00
2013-09-20 14:49:33 -04:00
2014-01-06 15:51:53 -08:00
2014-01-06 20:28:34 -05:00
2013-01-27 22:46:33 -05:00
2013-09-20 14:49:33 -04:00
2013-07-16 09:58:05 +03:00
2013-04-08 12:00:16 -04:00
2011-11-14 00:19:42 -05:00
2014-01-18 00:55:41 -08:00
2013-09-21 14:01:38 -04:00
2013-10-19 19:45:34 -04:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2013-05-28 23:49:07 -07:00
2013-10-23 17:01:41 -04:00
2013-10-08 23:19:24 -04:00
2013-10-19 19:45:35 -04:00
2014-01-17 17:56:33 -08:00
2013-12-28 17:03:20 -05:00
2013-10-09 13:04:03 -04:00
2014-01-02 03:30:35 -05:00
2014-01-07 15:51:39 -05:00
2014-01-04 20:10:24 -05:00
2013-09-21 14:01:38 -04:00
2014-02-20 13:13:50 -05:00
2013-11-11 00:19:35 -05:00
2014-01-19 19:53:18 -08:00
2010-02-16 23:05:38 -08:00
2014-01-21 16:59:19 -08:00
2014-02-09 17:32:50 -08:00
2013-09-21 14:01:39 -04:00
2013-09-21 14:01:38 -04:00
2013-04-29 15:41:56 -04:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2014-01-01 22:22:43 -05:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2014-01-03 20:56:48 -05:00
2014-01-10 09:50:02 +01:00
2013-10-21 18:56:23 -04:00
2013-12-06 12:37:56 -05:00
2013-09-04 14:53:20 -04:00
2013-10-01 17:06:14 -04:00
2013-09-21 14:01:39 -04:00
2014-01-16 11:31:58 -08:00
2014-02-09 17:32:50 -08:00
2011-05-27 13:41:33 -04:00
2009-01-06 11:38:15 -07:00
2013-09-21 14:01:39 -04:00
2014-01-25 11:17:34 -08:00
2013-09-21 14:01:39 -04:00
2014-01-03 23:41:42 +01:00
2013-09-21 14:01:39 -04:00
2009-08-19 23:08:22 +04:00
2013-09-21 14:01:39 -04:00
2014-01-19 19:53:18 -08:00
2014-01-13 11:50:15 -08:00
2013-12-09 19:54:47 -05:00
2014-01-21 18:05:04 -08:00
2013-09-23 01:51:08 -04:00
2013-09-23 01:51:08 -04:00
2013-09-23 01:51:08 -04:00
2014-01-21 23:17:20 -08:00
2014-01-13 14:46:58 -05:00
2013-10-10 00:08:07 -04:00
2013-09-23 01:51:08 -04:00
2014-01-13 11:22:54 -08:00
2014-01-22 21:57:05 -08:00
2014-01-13 11:50:14 -08:00
2013-09-23 01:51:09 -04:00
2013-10-01 17:06:14 -04:00
2012-08-06 13:40:47 -07:00
2014-03-11 16:45:59 -04:00
2013-12-19 18:51:20 -05:00
2013-09-23 01:51:09 -04:00
2013-10-21 18:43:02 -04:00
2014-02-22 00:05:21 -05:00
2012-06-09 14:56:12 -07:00
2014-01-19 19:53:18 -08:00
2013-11-07 02:14:33 -05:00
2013-09-23 16:29:40 -04:00
2013-07-27 22:14:06 -07:00
2014-01-21 18:05:04 -08:00
2013-09-23 16:29:40 -04:00
2013-09-23 16:29:41 -04:00
2012-05-16 15:17:08 -04:00
2013-09-23 16:29:41 -04:00
2010-04-22 16:12:36 -07:00
2014-02-20 14:30:10 +01:00