Eugeniu Rosca 60e3f6e4ac usb: core: hub: do error out if usb_autopm_get_interface() fails ...

Reviewing a fresh portion of coverity defects in USB core
(specifically CID 1458999), Alan Stern noted below in [1]:

On Tue, Feb 25, 2020 at 02:39:23PM -0500, Alan Stern wrote:
 > A revised search finds line 997 in drivers/usb/core/hub.c and lines
 > 216, 269 in drivers/usb/core/port.c.  (I didn't try looking in any
 > other directories.)  AFAICT all three of these should check the
 > return value, although a error message in the kernel log probably
 > isn't needed.

Factor out the usb_remove_device() change into a standalone patch to
allow conflict-free integration on top of the earliest stable branches.

[1] https://lore.kernel.org/lkml/Pine.LNX.4.44L0.2002251419120.1485-100000@iolanthe.rowland.org

Fixes: 253e05724f ("USB: add a "remove hardware" sysfs attribute")
Cc: stable@vger.kernel.org # v2.6.33+
Suggested-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20200226175036.14946-2-erosca@de.adit-jv.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2020-03-04 10:58:16 +01:00

..

buffer.c

usb: add a hcd_uses_dma helper

2019-08-15 15:18:05 +02:00

config.c

USB: core: clean up endpoint-descriptor parsing

2020-02-10 11:14:22 -08:00

devices.c

Remove 'type' argument from access_ok() function

2019-01-03 18:57:57 -08:00

devio.c

USB: usbfs: Always unlink URBs in reverse order

2020-01-17 17:57:04 +01:00

driver.c

USB: add support for dev_groups to struct usb_device_driver

2019-08-07 14:05:04 +02:00

endpoint.c

USB: core: move existing SPDX tags to top of the file

2017-11-03 10:12:26 +01:00

file.c

USB: core: Fix races in character device registration and deregistraion

2019-08-12 22:47:24 +02:00

generic.c

usbfs: Add ioctls for runtime power management

2019-08-09 07:55:45 +02:00

hcd-pci.c

remove ioremap_nocache and devm_ioremap_nocache

2020-01-06 09:45:59 +01:00

hcd.c

USB: Fix incorrect DMA allocations for local memory pool drivers

2019-12-11 09:06:41 +01:00

hub.c

usb: core: hub: do error out if usb_autopm_get_interface() fails

2020-03-04 10:58:16 +01:00

hub.h

USB: hub: Fix the broken detection of USB3 device in SMSC hub

2020-02-10 11:08:26 -08:00

Kconfig

usb: remove redundant 'default n' from Kconfig-s

2019-05-21 10:06:22 +02:00

ledtrig-usbport.c

USB: leds: fix regression in usbport led trigger

2019-01-18 09:55:05 +01:00

Makefile

usb: core: add a wrapper for the USB PHYs on the HCD

2018-03-09 09:43:53 -08:00

message.c

USB: CDC: fix sanity checks in CDC union parser

2019-08-15 14:49:16 +02:00

notify.c

USB: core: Remove usbfs_mutex

2019-06-26 10:28:09 +08:00

of.c

usb: Change usb_of_get_companion_dev() place to usb/common

2018-09-10 20:40:29 +02:00

otg_whitelist.h

USB: core: Remove redundant license text

2017-11-04 11:55:39 +01:00

phy.c

usb: core: phy: add support for PHY calibration

2019-09-03 15:54:55 +02:00

phy.h

usb: core: phy: add support for PHY calibration

2019-09-03 15:54:55 +02:00

port.c

USB: Disable USB2 LPM at shutdown

2019-08-05 17:19:46 +02:00

quirks.c

usb: quirks: add NO_LPM quirk for Logitech Screen Share

2020-03-04 10:56:26 +01:00

sysfs.c

usb: setup authorized_default attributes using usb_bus_notify

2019-08-08 16:07:34 +02:00

urb.c

usb: core: urb: fix URB structure initialization function

2019-12-10 11:41:19 +01:00

usb-acpi.c

usb: assign ACPI companions for embedded USB devices

2019-01-25 08:46:26 +01:00

usb.c

usb: remove commented out dma wrappers

2019-09-03 15:26:12 +02:00

usb.h

USB: core: add endpoint-blacklist quirk

2020-02-10 11:14:22 -08:00