Daniel Borkmann 5f52a8a71b bpf: Fix signed_{sub,add32}_overflows type handling ...

commit bc895e8b2a64e502fbba72748d59618272052a8b upstream.

Fix incorrect signed_{sub,add32}_overflows() input types (and a related buggy
comment). It looks like this might have slipped in via copy/paste issue, also
given prior to 3f50f132d8 ("bpf: Verifier, do explicit ALU32 bounds tracking")
the signature of signed_sub_overflows() had s64 a and s64 b as its input args
whereas now they are truncated to s32. Thus restore proper types. Also, the case
of signed_add32_overflows() is not consistent to signed_sub32_overflows(). Both
have s32 as inputs, therefore align the former.

Fixes: 3f50f132d8 ("bpf: Verifier, do explicit ALU32 bounds tracking")
Reported-by: De4dCr0w <sa516203@mail.ustc.edu.cn>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2021-01-23 16:03:58 +01:00

..

preload

bpf: BPF_PRELOAD depends on BPF_SYSCALL

2020-11-05 18:49:29 -08:00

arraymap.c

bpf: Allow for map-in-map with dynamic inner array map entries

2020-10-11 10:21:04 -07:00

bpf_inode_storage.c

bpf: Allow specifying a BTF ID per argument in function protos

2020-09-21 15:00:40 -07:00

bpf_iter.c

bpf: Bump iter seq size to support BTF representation of large data structures

2020-09-28 18:26:58 -07:00

bpf_local_storage.c

bpf: Use hlist_add_head_rcu when linking to local_storage

2020-09-19 01:12:35 +02:00

bpf_lru_list.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 206

2019-05-30 11:29:53 -07:00

bpf_lru_list.h

bpf: Fix a typo "inacitve" -> "inactive"

2020-04-06 21:54:10 +02:00

bpf_lsm.c

bpf: Update verification logic for LSM programs

2020-11-06 13:15:21 -08:00

bpf_struct_ops_types.h

bpf: tcp: Support tcp_congestion_ops in bpf

2020-01-09 08:46:18 -08:00

bpf_struct_ops.c

bpf: Move btf_resolve_size into __btf_resolve_size

2020-08-25 15:37:41 -07:00

btf.c

bpf: Introduce bpf_per_cpu_ptr()

2020-10-02 15:00:49 -07:00

cgroup.c

Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2020-10-22 09:59:21 -07:00

core.c

bpf: Don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-29 20:01:46 -07:00

cpumap.c

bpf, cpumap: Remove rcpu pointer from cpu_map_build_skb signature

2020-09-28 23:30:42 +02:00

devmap.c

bpf: {cpu,dev}map: Change various functions return type from int to void

2020-09-01 15:45:58 +02:00

disasm.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295

2019-06-05 17:36:38 +02:00

disasm.h

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295

2019-06-05 17:36:38 +02:00

dispatcher.c

bpf: Remove bpf_image tree

2020-03-13 12:49:52 -07:00

hashtab.c

bpf: Zero-fill re-used per-cpu map element

2020-11-05 19:55:57 -08:00

helpers.c

bpf: Fix enum names for bpf_this_cpu_ptr() and bpf_per_cpu_ptr() helpers

2020-12-11 14:19:07 -08:00

inode.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2020-09-22 16:45:34 -07:00

local_storage.c

bpf/local_storage: Fix build without CONFIG_CGROUP

2020-07-25 20:16:36 -07:00

lpm_trie.c

bpf: Add map_meta_equal map ops

2020-08-28 15:41:30 +02:00

Makefile

bpf: Don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-29 20:01:46 -07:00

map_in_map.c

bpf: Relax max_entries check for most of the inner map types

2020-08-28 15:41:30 +02:00

map_in_map.h

bpf: Add map_meta_equal map ops

2020-08-28 15:41:30 +02:00

map_iter.c

bpf: Implement link_query callbacks in map element iterators

2020-08-21 14:01:39 -07:00

net_namespace.c

bpf: Add support for forced LINK_DETACH command

2020-08-01 20:38:28 -07:00

offload.c

bpf, offload: Replace bitwise AND by logical AND in bpf_prog_offload_info_fill

2020-02-17 16:53:49 +01:00

percpu_freelist.c

bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI

2020-10-06 00:04:11 +02:00

percpu_freelist.h

bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI

2020-10-06 00:04:11 +02:00

prog_iter.c

bpf: Refactor bpf_iter_reg to have separate seq_info member

2020-07-25 20:16:32 -07:00

queue_stack_maps.c

bpf: Add map_meta_equal map ops

2020-08-28 15:41:30 +02:00

reuseport_array.c

bpf, net: Rework cookie generator as per-cpu one

2020-09-30 11:50:35 -07:00

ringbuf.c

bpf: Add map_meta_equal map ops

2020-08-28 15:41:30 +02:00

stackmap.c

bpf: Allow specifying a BTF ID per argument in function protos

2020-09-21 15:00:40 -07:00

syscall.c

bpf: Remove unneeded break

2020-10-19 20:40:21 +02:00

sysfs_btf.c

bpf: Fix sysfs export of empty BTF section

2020-09-21 21:50:24 +02:00

task_iter.c

bpf: Save correct stopping point in file seq iteration

2021-01-19 18:27:28 +01:00

tnum.c

bpf: Verifier, do explicit ALU32 bounds tracking

2020-03-30 14:59:53 -07:00

trampoline.c

bpf: Move prog->aux->linked_prog and trampoline into bpf_link on attach

2020-09-29 13:09:23 -07:00

verifier.c

bpf: Fix signed_{sub,add32}_overflows type handling

2021-01-23 16:03:58 +01:00