David S. Miller
5c668704b7
[UDP]: Fix reversed logic in udp_get_port().
...
When this code was converted to use sk_for_each() the
logic for the "best hash chain length" code was reversed,
breaking everything.
The original code was of the form:
size = 0;
do {
if (++size >= best_size_so_far)
goto next;
} while ((sk = sk->next) != NULL);
best_size_so_far = size;
best = result;
next:;
and this got converted into:
sk_for_each(sk2, node, head)
if (++size < best_size_so_far) {
best_size_so_far = size;
best = result;
}
Which does something very very different from the original.
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-12-22 11:42:26 -08:00
..
2006-12-11 14:35:03 -08:00
2006-12-13 16:48:23 -08:00
2006-12-02 21:22:50 -08:00
2006-12-02 21:21:17 -08:00
2006-12-02 21:22:50 -08:00
2006-12-02 21:31:38 -08:00
2006-09-28 17:54:06 -07:00
2006-12-10 09:55:41 -08:00
2006-12-02 21:21:17 -08:00
2006-12-02 21:30:43 -08:00
2006-12-07 08:39:25 -08:00
2006-09-28 18:02:23 -07:00
2006-12-02 21:22:11 -08:00
2006-12-02 21:22:11 -08:00
2006-12-07 08:39:25 -08:00
2006-12-02 21:23:34 -08:00
2006-12-02 21:23:27 -08:00
2006-12-02 21:21:44 -08:00
2006-09-28 18:02:29 -07:00
2006-12-07 08:39:25 -08:00
2006-12-07 09:05:15 -08:00
2006-12-07 08:39:25 -08:00
2006-06-30 19:25:36 +02:00
2006-12-12 19:48:59 +01:00
2006-12-02 21:23:34 -08:00
2006-07-24 23:45:16 -07:00
2006-10-30 15:24:49 -08:00
2006-12-08 17:19:20 -08:00
2006-12-02 21:22:50 -08:00
2006-10-04 00:31:09 -07:00
2006-12-02 21:21:09 -08:00
2006-12-02 21:21:17 -08:00
2006-12-07 08:39:25 -08:00
2006-12-02 21:31:47 -08:00
2006-12-02 21:22:46 -08:00
2006-06-30 19:25:36 +02:00
2006-06-30 19:25:36 +02:00
2006-06-30 19:25:36 +02:00
2006-09-28 18:01:17 -07:00
2005-04-16 15:20:36 -07:00
2006-12-02 21:23:38 -08:00
2006-12-02 21:22:46 -08:00
2006-06-30 19:25:36 +02:00
2006-12-02 21:22:50 -08:00
2006-12-18 00:26:35 -08:00
2006-12-02 21:22:50 -08:00
2006-12-10 09:55:41 -08:00
2006-09-22 15:18:04 -07:00
2006-12-02 21:21:50 -08:00
2006-10-25 23:04:12 -07:00
2006-06-30 19:25:36 +02:00
2006-09-22 15:18:13 -07:00
2006-12-02 21:22:14 -08:00
2006-09-22 15:18:13 -07:00
2006-12-07 00:11:33 -08:00
2006-12-17 21:59:26 -08:00
2006-09-28 18:03:07 -07:00
2006-12-05 14:37:56 +00:00
2006-12-02 21:22:39 -08:00
2006-11-25 15:16:49 -08:00
2006-06-30 19:25:36 +02:00
2006-12-02 21:22:50 -08:00
2006-12-02 21:31:03 -08:00
2006-09-22 15:18:13 -07:00
2006-09-22 15:18:13 -07:00
2006-12-13 16:48:26 -08:00
2006-04-09 22:25:25 -07:00
2006-12-02 21:22:46 -08:00
2006-12-22 11:42:26 -08:00
2006-12-02 21:31:51 -08:00
2006-09-28 18:02:39 -07:00
2006-10-04 00:31:09 -07:00
2006-09-22 15:18:48 -07:00
2006-09-22 15:18:48 -07:00
2006-09-22 15:18:48 -07:00
2006-12-06 23:45:15 -08:00
2006-09-28 18:02:33 -07:00
2006-09-22 15:05:15 -07:00