Files
android_kernel_xiaomi_sm8450/include/linux
Linus Torvalds 5336377d62 modules: Fix module_bug_list list corruption race
With all the recent module loading cleanups, we've minimized the code
that sits under module_mutex, fixing various deadlocks and making it
possible to do most of the module loading in parallel.

However, that whole conversion totally missed the rather obscure code
that adds a new module to the list for BUG() handling.  That code was
doubly obscure because (a) the code itself lives in lib/bugs.c (for
dubious reasons) and (b) it gets called from the architecture-specific
"module_finalize()" rather than from generic code.

Calling it from arch-specific code makes no sense what-so-ever to begin
with, and is now actively wrong since that code isn't protected by the
module loading lock any more.

So this commit moves the "module_bug_{finalize,cleanup}()" calls away
from the arch-specific code, and into the generic code - and in the
process protects it with the module_mutex so that the list operations
are now safe.

Future fixups:
 - move the module list handling code into kernel/module.c where it
   belongs.
 - get rid of 'module_bug_list' and just use the regular list of modules
   (called 'modules' - imagine that) that we already create and maintain
   for other reasons.

Reported-and-tested-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Adrian Bunk <bunk@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-10-05 11:29:27 -07:00
..
2010-08-05 13:26:20 +01:00
2010-08-12 06:38:24 +10:00
2010-09-08 10:50:00 -06:00
2010-06-04 16:00:42 -04:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2010-03-12 15:53:10 -08:00
2009-06-17 00:36:36 -04:00
2008-10-20 11:01:52 -07:00
2010-06-15 09:56:01 +10:00
2009-01-30 23:38:03 +05:30
2010-05-27 09:12:53 -07:00
2009-09-08 17:42:50 -07:00
2010-05-19 13:38:54 -04:00
2009-01-30 23:38:37 +05:30
2008-12-03 22:12:38 -08:00
2009-04-01 08:59:23 -07:00
2009-01-30 23:39:42 +05:30
2010-08-12 08:43:30 -07:00
2008-10-20 08:52:42 -07:00
2009-01-30 23:40:06 +05:30
2010-08-12 08:43:30 -07:00
2010-08-12 08:43:30 -07:00
2009-01-04 13:33:20 -08:00
2010-06-24 21:30:09 -07:00
2009-11-20 20:13:39 +01:00
2009-11-20 20:13:39 +01:00
2009-11-20 20:13:39 +01:00
2010-08-18 01:09:01 -04:00
2009-06-11 21:36:09 -04:00
2009-01-30 23:44:08 +05:30
2010-09-09 18:57:23 -07:00
2010-08-06 15:36:47 -05:00
2009-07-12 12:22:34 -07:00
2008-12-25 11:01:43 +11:00
2010-05-19 22:41:57 -04:00
2010-05-10 16:08:01 -07:00
2010-08-04 11:00:45 +02:00
2009-12-10 23:52:01 +00:00
2010-08-12 04:14:05 +01:00
2009-05-18 14:46:26 +01:00
2009-11-04 09:50:58 -08:00
2009-10-01 21:17:49 +02:00
2009-09-14 17:41:42 -07:00
2009-01-30 23:46:40 +05:30
2009-12-15 08:53:33 -08:00
2009-11-04 09:50:58 -08:00
2009-03-16 08:32:27 -06:00
2009-12-23 13:33:54 +01:00
2010-08-18 08:35:46 -04:00
2010-07-12 14:41:40 +02:00
2009-06-18 13:04:05 -07:00
2009-11-04 09:50:58 -08:00
2010-03-16 08:55:32 +01:00
2010-05-25 08:07:01 -07:00
2010-05-21 09:34:29 -07:00
2009-09-01 01:13:31 -07:00
2010-07-19 11:54:16 +02:00
2009-01-30 23:51:17 +05:30
2010-02-09 11:13:56 +01:00
2010-03-07 22:17:09 +01:00
2010-08-11 09:23:22 +02:00
2010-03-02 12:23:42 +01:00
2010-08-11 18:21:02 +02:00
2010-06-16 18:08:13 +02:00
2009-04-02 19:04:53 -07:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-01-30 23:53:12 +05:30
2010-06-03 03:21:52 -07:00
2009-11-04 09:50:58 -08:00
2009-01-30 23:55:45 +05:30
2009-01-30 23:56:13 +05:30
2009-01-30 23:56:48 +05:30
2010-02-02 07:32:29 -08:00
2010-06-23 13:16:38 -07:00
2010-03-03 11:26:01 +01:00
2010-08-09 20:45:05 -07:00
2010-05-11 12:01:10 -07:00
2010-06-22 08:07:01 +02:00
2010-03-12 15:52:40 -08:00
2009-09-26 10:17:19 -07:00
2009-04-21 13:41:48 -07:00
2009-04-21 13:41:48 -07:00
2009-01-30 23:59:44 +05:30
2009-01-31 00:00:06 +05:30
2010-05-03 11:50:57 +02:00
2009-08-29 15:53:00 +02:00
2010-06-03 03:21:52 -07:00
2010-08-10 11:49:21 -07:00
2009-01-05 08:40:30 -08:00
2010-08-12 11:27:58 +02:00
2010-05-21 09:37:29 -07:00
2010-09-09 18:57:24 -07:00
2010-06-29 10:07:09 +02:00
2010-05-14 15:09:32 -04:00
2010-08-02 06:39:44 +03:00
2010-08-01 10:47:00 +03:00
2010-04-03 14:56:05 -07:00
2009-04-06 16:06:26 +01:00
2009-07-30 16:03:45 +09:30
2010-07-06 13:45:24 -04:00
2009-12-26 20:40:34 -08:00
2009-04-28 07:37:28 +02:00
2010-06-16 18:03:15 +02:00
2010-02-19 03:35:12 -05:00
2009-06-16 19:47:48 -07:00
2010-08-09 16:48:45 -04:00
2010-07-14 17:14:00 +10:00
2009-09-22 07:17:35 -07:00
2009-06-16 08:40:20 +02:00
2009-04-29 17:32:35 -07:00
2009-01-31 00:00:35 +05:30
2010-06-03 03:21:52 -07:00
2010-09-09 09:05:06 -07:00
2010-08-11 00:29:47 -04:00
2010-05-11 14:40:55 +02:00
2010-04-13 14:49:34 -07:00
2010-02-10 23:49:08 +09:00
2010-06-03 03:21:52 -07:00
2010-05-17 05:27:42 +02:00
2009-11-04 09:50:58 -08:00
2010-07-02 21:59:08 -07:00
2009-06-17 18:02:11 -07:00
2009-06-17 18:02:11 -07:00
2009-06-17 18:02:11 -07:00
2009-06-15 21:44:43 -07:00
2010-07-05 16:14:52 -06:00
2010-07-05 16:14:25 -06:00
2010-07-31 19:53:06 +08:00
2009-04-01 08:59:13 -07:00
2009-04-01 08:59:13 -07:00
2009-01-08 08:31:12 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2010-07-19 01:58:48 +02:00
2010-07-19 01:58:48 +02:00
2010-03-12 15:53:11 -08:00
2009-12-03 11:43:23 +00:00
2010-08-04 21:53:17 -07:00
2009-06-18 13:04:04 -07:00
2009-07-29 19:10:36 -07:00
2009-12-02 09:55:33 +01:00
2009-09-23 07:39:41 -07:00
2009-03-30 15:22:01 +02:00
2009-06-11 21:36:12 -04:00
2010-02-10 17:47:17 -08:00
2010-05-03 15:53:54 -07:00
2010-06-03 03:21:52 -07:00
2010-03-12 15:52:44 -08:00
2010-08-09 16:47:27 -04:00
2010-05-27 09:12:50 -07:00
2010-05-30 09:02:47 -07:00
2009-05-09 10:49:41 -04:00
2009-11-04 09:50:58 -08:00
2010-05-11 10:09:47 +02:00
2010-03-12 15:53:10 -08:00
2010-07-22 13:46:21 -07:00
2010-07-23 17:08:41 +04:00
2010-06-03 03:21:52 -07:00
2010-09-08 15:04:10 +02:00
2009-04-08 14:33:38 -07:00
2010-05-25 11:41:43 -04:00
2009-11-30 12:02:53 +09:00
2009-04-13 15:04:29 -07:00
2010-03-12 15:52:44 -08:00
2009-01-31 00:06:33 +05:30
2010-09-27 20:24:54 -07:00
2009-12-16 22:32:29 -05:00
2009-01-31 00:07:00 +05:30
2010-05-10 11:08:35 -07:00
2010-08-09 16:48:44 -04:00
2010-01-14 22:38:09 -05:00
2009-04-02 19:05:01 -07:00
2010-05-15 23:28:39 -07:00
2010-02-18 15:43:09 -08:00
2010-03-25 17:18:43 -07:00
2009-02-18 15:37:53 -08:00
2010-03-23 17:19:38 +01:00
2010-05-12 23:02:23 -07:00
2009-10-29 11:17:40 +11:00
2010-08-18 08:35:47 -04:00
2010-08-06 10:37:02 -04:00
2009-11-10 20:54:38 -08:00
2009-09-23 18:13:10 -07:00
2010-05-19 22:40:47 -04:00
2009-08-26 12:39:29 +01:00
2010-08-11 08:59:02 -07:00
2009-09-23 22:26:32 +09:30
2010-05-19 22:15:46 +09:30
2010-06-03 03:21:52 -07:00
2010-09-13 10:26:52 +02:00
2010-04-06 20:35:58 +04:00