xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
4dc0484e90a3cde1cb1514f1db1de3145d99cb18
android_kernel_xiaomi_sm8450/drivers/tty
History
Pavel Krasavin 2ed25af15b tty: serial: meson: fix hard LOCKUP on crtscts mode 
[ Upstream commit 2a1d728f20edeee7f26dc307ed9df4e0d23947ab ]

There might be hard lockup if we set crtscts mode on port without RTS/CTS configured:

# stty -F /dev/ttyAML6 crtscts; echo 1 > /dev/ttyAML6; echo 2 > /dev/ttyAML6
[   95.890386] rcu: INFO: rcu_preempt detected stalls on CPUs/tasks:
[   95.890857] rcu:     3-...0: (201 ticks this GP) idle=e33c/1/0x4000000000000000 softirq=5844/5846 fqs=4984
[   95.900212] rcu:     (detected by 2, t=21016 jiffies, g=7753, q=296 ncpus=4)
[   95.906972] Task dump for CPU 3:
[   95.910178] task:bash            state:R  running task     stack:0     pid:205   ppid:1      flags:0x00000202
[   95.920059] Call trace:
[   95.922485]  __switch_to+0xe4/0x168
[   95.925951]  0xffffff8003477508
[   95.974379] watchdog: Watchdog detected hard LOCKUP on cpu 3
[   95.974424] Modules linked in: 88x2cs(O) rtc_meson_vrtc

Possible solution would be to not allow to setup crtscts on such port.

Tested on S905X3 based board.

Fixes: ff7693d079 ("ARM: meson: serial: add MesonX SoC on-chip uart driver")
Cc: stable@vger.kernel.org
Signed-off-by: Pavel Krasavin <pkrasavin@imaqliq.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Dmitry Rokosov <ddrokosov@salutedevices.com>

v6: stable tag added
v5: https://lore.kernel.org/lkml/OF43DA36FF.2BD3BB21-ON00258A47.005A8125-00258A47.005A9513@gdc.ru/
added missed Reviewed-by tags, Fixes tag added according to Dmitry and Neil notes
v4: https://lore.kernel.org/lkml/OF55521400.7512350F-ON00258A47.003F7254-00258A47.0040E15C@gdc.ru/
More correct patch subject according to Jiri's note
v3: https://lore.kernel.org/lkml/OF6CF5FFA0.CCFD0E8E-ON00258A46.00549EDF-00258A46.0054BB62@gdc.ru/
"From:" line added to the mail
v2: https://lore.kernel.org/lkml/OF950BEF72.7F425944-ON00258A46.00488A76-00258A46.00497D44@gdc.ru/
braces for single statement removed according to Dmitry's note
v1: https://lore.kernel.org/lkml/OF28B2B8C9.5BC0CD28-ON00258A46.0037688F-00258A46.0039155B@gdc.ru/
Link: https://lore.kernel.org/r/OF66360032.51C36182-ON00258A48.003F656B-00258A48.0040092C@gdc.ru

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-11-28 16:54:59 +00:00
..
hvc
hvc/xen: fix error path in xen_hvc_init() to always register frontend driver
2023-11-28 16:54:56 +00:00
ipwireless
tty: ipwireless: fix error handling
2020-09-04 18:08:16 +02:00
serdev
serdev: Fix detection of UART devices on Apple machines.
2020-03-06 14:10:44 +01:00
serial
tty: serial: meson: fix hard LOCKUP on crtscts mode
2023-11-28 16:54:59 +00:00
vt
vc_screen: reload load of struct vc_data pointer in vcs_write() to avoid UAF
2023-05-30 12:57:55 +01:00
amiserial.c
tty: amiserial: fix TIOCSSERIAL permission check
2021-05-14 09:49:55 +02:00
cyclades.c
tty: drivers/tty/, stop using tty_schedule_flip()
2022-07-29 17:19:27 +02:00
ehv_bytechan.c
tty: evh_bytechan: Fix out of bounds accesses
2020-03-17 23:40:31 +11:00
goldfish.c
tty: drivers/tty/, stop using tty_schedule_flip()
2022-07-29 17:19:27 +02:00
isicom.c
treewide: Remove uninitialized_var() usage
2020-07-16 12:35:15 -07:00
Kconfig
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
Makefile
tty: Add NULL TTY driver
2019-04-16 15:21:34 +02:00
mips_ejtag_fdc.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
moxa.c
tty: drivers/tty/, stop using tty_schedule_flip()
2022-07-29 17:19:27 +02:00
moxa.h
tty: fix spelling mistake
2020-06-27 16:21:20 +02:00
mxser.c
mxser: fix xmit_buf leak in activate when LSR == 0xff
2022-04-08 14:40:23 +02:00
mxser.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
n_gsm.c
Revert "tty: n_gsm: fix UAF in gsm_cleanup_mux"
2023-10-10 21:53:34 +02:00
n_hdlc.c
tty: clean include/linux/tty.h up
2023-05-17 11:48:09 +02:00
n_null.c
tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer
2021-03-04 11:37:36 +01:00
n_r3964.c
tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer
2021-03-04 11:37:36 +01:00
n_tracerouter.c
tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer
2021-03-04 11:37:36 +01:00
n_tracesink.c
tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer
2021-03-04 11:37:36 +01:00
n_tracesink.h
tty: n_tracesink: Use the correct style for SPDX License Identifier
2020-03-18 13:01:31 +01:00
n_tty.c
tty: create internal tty.h file
2023-05-17 11:48:08 +02:00
nozomi.c
tty: nozomi: Fix the error handling path of 'nozomi_card_init()'
2021-07-14 16:56:39 +02:00
pty.c
tty: create internal tty.h file
2023-05-17 11:48:08 +02:00
rocket_int.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
rocket.c
Merge 5.7-rc3 into tty-next
2020-04-27 09:33:21 +02:00
rocket.h
tty: rocket: Remove RCPK_GET_STRUCT ioctl
2019-04-25 11:58:56 +02:00
synclink_gt.c
tty: synclink_gt: Fix null-pointer-dereference in slgt_clean()
2022-06-14 18:32:41 +02:00
synclink.c
tty: synclink, fix kernel-doc
2020-08-18 13:51:18 +02:00
synclinkmp.c
tty: synclink, fix kernel-doc
2020-08-18 13:51:18 +02:00
sysrq.c
tty/sysrq: replace smp_processor_id() with get_cpu()
2023-11-28 16:54:56 +00:00
tty_audit.c
tty: audit: move some local functions out of tty.h
2023-05-17 11:48:08 +02:00
tty_baudrate.c
tty: clean include/linux/tty.h up
2023-05-17 11:48:09 +02:00
tty_buffer.c
tty: move some internal tty lock enums and functions out of tty.h
2023-05-17 11:48:08 +02:00
tty_io.c
tty: Prevent writing chars during tcsetattr TCSADRAIN/FLUSH
2023-05-17 11:48:09 +02:00
tty_ioctl.c
tty: Prevent writing chars during tcsetattr TCSADRAIN/FLUSH
2023-05-17 11:48:09 +02:00
tty_jobctrl.c
tty: tty_jobctrl: fix pid memleak in disassociate_ctty()
2023-11-20 11:06:52 +01:00
tty_ldisc.c
tty: create internal tty.h file
2023-05-17 11:48:08 +02:00
tty_ldsem.c
locking/lockdep: Remove unused @nested argument from lock_release()
2019-10-09 12:46:10 +02:00
tty_mutex.c
tty: move some internal tty lock enums and functions out of tty.h
2023-05-17 11:48:08 +02:00
tty_port.c
tty: create internal tty.h file
2023-05-17 11:48:08 +02:00
tty.h
tty: Prevent writing chars during tcsetattr TCSADRAIN/FLUSH
2023-05-17 11:48:09 +02:00
ttynull.c
tty: Add NULL TTY driver
2019-04-16 15:21:34 +02:00
vcc.c
tty: vcc: Add check for kstrdup() in vcc_probe()
2023-11-28 16:54:52 +00:00