f3396f6d83
commit c302c98da646409d657a473da202f10f417f3ff1 upstream.
Macros SUN8I_CSC_CTRL() and SUN8I_CSC_COEFF() don't follow usual
recommendation of having arguments enclosed in parenthesis. While that
didn't change anything for quite sometime, it actually become important
after CSC code rework with commit ea067aee45a8 ("drm/sun4i: de2/de3:
Remove redundant CSC matrices").
Without this fix, colours are completely off for supported YVU formats
on SoCs with DE2 (A64, H3, R40, etc.).
Fix the issue by enclosing macro arguments in parenthesis.
Cc: stable@vger.kernel.org # 5.12+
Fixes: 8830293905 ("drm/sun4i: Add DE2 CSC library")
Reported-by: Roman Stratiienko <r.stratiienko@gmail.com>
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20210831184819.93670-1-jernej.skrabec@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
37 lines
884 B
C
37 lines
884 B
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) Jernej Skrabec <jernej.skrabec@siol.net>
|
|
*/
|
|
|
|
#ifndef _SUN8I_CSC_H_
|
|
#define _SUN8I_CSC_H_
|
|
|
|
#include <drm/drm_color_mgmt.h>
|
|
|
|
struct sun8i_mixer;
|
|
|
|
/* VI channel CSC units offsets */
|
|
#define CCSC00_OFFSET 0xAA050
|
|
#define CCSC01_OFFSET 0xFA050
|
|
#define CCSC10_OFFSET 0xA0000
|
|
#define CCSC11_OFFSET 0xF0000
|
|
|
|
#define SUN8I_CSC_CTRL(base) ((base) + 0x0)
|
|
#define SUN8I_CSC_COEFF(base, i) ((base) + 0x10 + 4 * (i))
|
|
|
|
#define SUN8I_CSC_CTRL_EN BIT(0)
|
|
|
|
enum sun8i_csc_mode {
|
|
SUN8I_CSC_MODE_OFF,
|
|
SUN8I_CSC_MODE_YUV2RGB,
|
|
SUN8I_CSC_MODE_YVU2RGB,
|
|
};
|
|
|
|
void sun8i_csc_set_ccsc_coefficients(struct sun8i_mixer *mixer, int layer,
|
|
enum sun8i_csc_mode mode,
|
|
enum drm_color_encoding encoding,
|
|
enum drm_color_range range);
|
|
void sun8i_csc_enable_ccsc(struct sun8i_mixer *mixer, int layer, bool enable);
|
|
|
|
#endif
|