Vitaly Prosyak
53b2393eeb
drm/amdgpu: fix software pci_unplug on some chips
[ Upstream commit 4638e0c29a3f2294d5de0d052a4b8c9f33ccb957 ]
When software 'pci unplug' using IGT is executed we got a sysfs directory
entry is NULL for differant ras blocks like hdp, umc, etc.
Before call 'sysfs_remove_file_from_group' and 'sysfs_remove_group'
check that 'sd' is not NULL.
[ +0.000001] RIP: 0010:sysfs_remove_group+0x83/0x90
[ +0.000002] Code: 31 c0 31 d2 31 f6 31 ff e9 9a a8 b4 00 4c 89 e7 e8 f2 a2 ff ff eb c2 49 8b 55 00 48 8b 33 48 c7 c7 80 65 94 82 e8 cd 82 bb ff <0f> 0b eb cc 66 0f 1f 84 00 00 00 00 00 90 90 90 90 90 90 90 90 90
[ +0.000001] RSP: 0018:ffffc90002067c90 EFLAGS: 00010246
[ +0.000002] RAX: 0000000000000000 RBX: ffffffff824ea180 RCX: 0000000000000000
[ +0.000001] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
[ +0.000001] RBP: ffffc90002067ca8 R08: 0000000000000000 R09: 0000000000000000
[ +0.000001] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
[ +0.000001] R13: ffff88810a395f48 R14: ffff888101aab0d0 R15: 0000000000000000
[ +0.000001] FS: 00007f5ddaa43a00(0000) GS:ffff88841e800000(0000) knlGS:0000000000000000
[ +0.000002] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ +0.000001] CR2: 00007f8ffa61ba50 CR3: 0000000106432000 CR4: 0000000000350ef0
[ +0.000001] Call Trace:
[ +0.000001] <TASK>
[ +0.000001] ? show_regs+0x72/0x90
[ +0.000002] ? sysfs_remove_group+0x83/0x90
[ +0.000002] ? __warn+0x8d/0x160
[ +0.000001] ? sysfs_remove_group+0x83/0x90
[ +0.000001] ? report_bug+0x1bb/0x1d0
[ +0.000003] ? handle_bug+0x46/0x90
[ +0.000001] ? exc_invalid_op+0x19/0x80
[ +0.000002] ? asm_exc_invalid_op+0x1b/0x20
[ +0.000003] ? sysfs_remove_group+0x83/0x90
[ +0.000001] dpm_sysfs_remove+0x61/0x70
[ +0.000002] device_del+0xa3/0x3d0
[ +0.000002] ? ktime_get_mono_fast_ns+0x46/0xb0
[ +0.000002] device_unregister+0x18/0x70
[ +0.000001] i2c_del_adapter+0x26d/0x330
[ +0.000002] arcturus_i2c_control_fini+0x25/0x50 [amdgpu]
[ +0.000236] smu_sw_fini+0x38/0x260 [amdgpu]
[ +0.000241] amdgpu_device_fini_sw+0x116/0x670 [amdgpu]
[ +0.000186] ? mutex_lock+0x13/0x50
[ +0.000003] amdgpu_driver_release_kms+0x16/0x40 [amdgpu]
[ +0.000192] drm_minor_release+0x4f/0x80 [drm]
[ +0.000025] drm_release+0xfe/0x150 [drm]
[ +0.000027] __fput+0x9f/0x290
[ +0.000002] ____fput+0xe/0x20
[ +0.000002] task_work_run+0x61/0xa0
[ +0.000002] exit_to_user_mode_prepare+0x150/0x170
[ +0.000002] syscall_exit_to_user_mode+0x2a/0x50
Cc: Hawking Zhang <hawking.zhang@amd.com>
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Signed-off-by: Vitaly Prosyak <vitaly.prosyak@amd.com>
Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-11-28 16:54:53 +00:00
..
2021-09-15 09:50:34 +02:00
2020-10-09 15:16:10 -04:00
2019-06-10 23:02:48 +02:00
2020-08-26 16:40:18 -04:00
2019-01-14 15:04:29 -05:00
2020-10-15 10:46:16 -07:00
2020-10-15 10:46:16 -07:00
2020-10-15 10:46:16 -07:00
2020-10-15 10:46:16 -07:00
2021-06-03 09:00:31 +02:00
2020-10-15 10:46:16 -07:00
2022-04-20 09:23:08 +02:00
2022-07-07 17:52:15 +02:00
2021-12-14 11:32:35 +01:00
2020-08-24 13:06:06 -04:00
2020-07-21 15:37:37 -04:00
2020-10-01 10:43:02 -04:00
2020-07-01 01:59:14 -04:00
2020-09-15 17:52:43 -04:00
2020-04-28 16:20:29 -04:00
2023-01-14 10:15:35 +01:00
2021-11-18 14:04:04 +01:00
2021-11-18 14:04:04 +01:00
2020-04-09 10:43:18 -04:00
2022-12-08 11:23:54 +01:00
2023-09-23 11:01:10 +02:00
2019-10-25 11:40:50 +02:00
2018-11-05 14:21:50 -05:00
2021-06-10 13:39:27 +02:00
2020-04-09 10:43:14 -04:00
2023-11-28 16:54:50 +00:00
2020-05-18 11:23:37 -04:00
2023-11-28 16:54:50 +00:00
2020-09-15 17:52:42 -04:00
2022-01-05 12:40:32 +01:00
2020-07-02 12:02:51 -04:00
2022-10-26 13:25:56 +02:00
2019-07-30 23:48:32 -05:00
2021-06-30 08:47:16 -04:00
2020-08-11 11:47:35 -04:00
2020-07-01 01:59:07 -04:00
2023-01-14 10:16:40 +01:00
2020-08-24 13:06:06 -04:00
2021-06-03 09:00:44 +02:00
2021-05-11 14:47:23 +02:00
2021-06-18 10:00:06 +02:00
2020-09-29 16:11:50 -04:00
2019-11-13 15:29:44 -05:00
2018-11-05 14:21:16 -05:00
2019-08-12 12:47:47 -05:00
2022-12-02 17:40:06 +01:00
2019-09-16 09:59:21 -05:00
2022-04-13 21:01:03 +02:00
2020-12-30 11:53:09 +01:00
2020-09-30 13:50:13 -04:00
2020-12-30 11:53:54 +01:00
2020-09-25 16:55:16 -04:00
2020-10-28 11:41:15 -06:00
2021-09-18 13:40:28 +02:00
2021-07-19 09:44:45 +02:00
2021-05-14 09:50:01 +02:00
2020-09-17 19:21:16 +02:00
2019-11-19 10:12:54 -05:00
2019-03-19 15:36:58 -05:00
2019-06-10 23:02:48 +02:00
2022-01-27 10:54:12 +01:00
2019-02-13 17:47:11 -05:00
2020-08-18 18:20:17 -04:00
2020-04-28 16:20:29 -04:00
2020-07-01 01:59:19 -04:00
2020-07-01 01:59:19 -04:00
2023-09-19 12:20:12 +02:00
2020-07-01 01:59:11 -04:00
2020-03-10 15:55:11 -04:00
2020-09-22 17:37:38 -04:00
2019-11-23 19:56:45 -04:00
2019-11-23 19:56:45 -04:00
2020-09-15 17:52:39 -04:00
2020-03-10 15:55:11 -04:00
2020-04-01 14:44:42 -04:00
2023-01-24 07:20:01 +01:00
2020-08-06 13:19:21 +10:00
2019-06-10 23:02:48 +02:00
2020-08-24 13:06:06 -04:00
2019-06-20 11:36:22 -05:00
2022-09-20 12:38:32 +02:00
2021-06-18 10:00:06 +02:00
2020-08-24 13:06:06 -04:00
2020-08-14 16:22:40 -04:00
2021-09-18 13:40:17 +02:00
2020-08-04 17:26:54 -04:00
2023-11-28 16:54:53 +00:00
2020-12-09 10:06:39 -05:00
2020-08-24 13:06:06 -04:00
2020-08-18 18:20:17 -04:00
2019-12-03 11:57:00 -05:00
2020-10-21 17:33:42 -04:00
2019-06-10 23:02:48 +02:00
2023-05-17 11:48:12 +02:00
2020-08-18 18:20:26 -04:00
2020-03-10 15:55:11 -04:00
2020-04-28 16:20:29 -04:00
2019-06-21 18:59:34 -05:00
2020-07-01 01:59:22 -04:00
2020-07-01 01:59:22 -04:00
2020-04-28 16:20:30 -04:00
2019-06-10 23:02:48 +02:00
2021-03-04 11:37:38 +01:00
2022-02-23 12:01:00 +01:00
2020-09-14 18:11:40 +02:00
2022-06-09 10:20:53 +02:00
2020-10-21 17:33:42 -04:00
2020-08-04 17:27:20 -04:00
2021-07-19 09:44:51 +02:00
2021-05-11 14:47:30 +02:00
2020-11-24 12:29:35 -05:00
2020-04-28 16:20:30 -04:00
2019-10-25 16:15:00 -04:00
2020-11-04 08:33:47 -05:00
2020-10-14 15:27:50 -04:00
2022-11-10 18:14:23 +01:00
2023-01-14 10:16:16 +01:00
2020-09-15 17:52:42 -04:00
2020-09-15 17:52:42 -04:00
2023-09-02 09:18:13 +02:00
2021-05-14 09:50:01 +02:00
2020-10-28 11:41:15 -06:00
2022-09-15 11:32:02 +02:00
2020-08-24 12:24:14 -04:00
2022-09-05 10:28:58 +02:00
2020-09-25 16:55:44 -04:00
2019-10-03 09:11:05 -05:00
2020-08-24 13:06:05 -04:00
2019-08-12 12:47:48 -05:00
2020-01-22 16:55:27 -05:00
2019-06-20 21:35:29 -05:00
2020-07-15 12:47:25 -04:00
2020-07-01 01:59:07 -04:00
2020-08-14 16:22:40 -04:00
2019-06-10 23:00:01 +02:00
2020-08-24 13:06:06 -04:00
2020-09-08 16:40:13 +10:00
2020-08-24 13:06:06 -04:00
2020-08-24 13:06:06 -04:00
2020-09-22 17:37:37 -04:00
2020-10-30 01:16:54 -04:00
2023-09-19 12:20:15 +02:00
2020-01-14 10:18:08 -05:00
2020-07-02 12:02:50 -04:00
2019-06-20 21:16:37 -05:00
2021-03-07 12:34:11 +01:00
2020-08-24 13:06:06 -04:00
2020-08-24 13:06:06 -04:00
2020-08-24 13:06:06 -04:00
2020-08-24 13:06:06 -04:00
2020-10-09 15:15:48 -04:00
2020-01-14 10:18:58 -05:00
2020-09-15 17:52:42 -04:00
2019-06-20 11:35:45 -05:00
2020-05-18 11:24:21 -04:00
2020-07-02 12:02:50 -04:00
2020-12-30 11:53:09 +01:00
2023-06-21 15:45:36 +02:00
2020-09-30 13:50:06 -04:00
2020-09-22 17:37:38 -04:00
2020-09-22 17:37:38 -04:00
2023-06-21 15:45:36 +02:00
2019-06-21 18:59:23 -05:00
2020-09-30 13:50:13 -04:00
2020-09-30 13:50:13 -04:00
2020-09-30 13:50:13 -04:00
2020-09-30 13:50:13 -04:00
2020-09-30 13:50:13 -04:00
2020-09-30 13:50:13 -04:00
2020-09-30 13:50:13 -04:00
2020-09-30 13:50:13 -04:00
2021-11-18 14:04:12 +01:00
2020-08-24 12:22:56 -04:00
2022-01-27 10:54:19 +01:00
2023-05-17 11:48:15 +02:00
2020-08-26 16:40:18 -04:00
2022-09-05 10:28:58 +02:00
2019-06-20 21:35:29 -05:00
2021-03-07 12:34:11 +01:00
2020-10-14 15:27:50 -04:00
2019-11-19 10:12:49 -05:00
2021-06-03 09:00:31 +02:00
2019-11-19 10:12:50 -05:00
2021-06-10 13:39:23 +02:00
2019-11-19 10:12:50 -05:00
2021-06-10 13:39:23 +02:00
2020-07-01 01:59:09 -04:00
2019-12-11 15:22:08 -05:00
2020-08-14 16:22:41 -04:00
2020-07-01 01:59:11 -04:00
2020-09-22 17:37:37 -04:00
2019-07-08 13:56:02 -05:00
2022-09-15 11:32:03 +02:00
2020-08-14 16:22:40 -04:00
2020-09-25 16:55:16 -04:00
2020-08-14 16:22:40 -04:00
2020-09-25 16:55:16 -04:00
2020-08-14 16:22:40 -04:00
2019-12-18 16:33:26 -05:00
2020-03-06 14:34:42 -05:00
2020-07-15 12:45:05 -04:00
2020-09-15 17:24:18 -04:00
2020-04-24 11:42:11 -04:00
2020-09-15 17:24:18 -04:00
2020-04-24 11:42:11 -04:00
2019-04-19 11:33:27 -05:00
2020-04-01 14:44:43 -04:00
2020-09-03 14:47:48 -04:00
2019-06-20 21:35:30 -05:00
2019-10-03 09:11:05 -05:00
2020-04-28 15:58:12 -04:00
2019-10-03 09:11:05 -05:00
2019-10-03 09:11:05 -05:00
2020-07-01 01:59:07 -04:00
2019-09-13 17:11:03 -05:00
2020-04-01 14:44:42 -04:00
2019-09-13 17:11:03 -05:00
2020-04-01 14:44:42 -04:00
2019-09-13 17:11:03 -05:00
2020-08-14 16:12:22 -04:00
2019-09-13 17:11:03 -05:00
2021-03-09 11:11:12 +01:00
2020-07-02 12:02:50 -04:00
2020-05-14 16:42:43 -04:00
2022-04-20 09:23:18 +02:00
2021-01-27 11:55:02 +01:00
2021-06-18 10:00:06 +02:00
2020-05-22 13:41:53 -04:00
2021-06-18 10:00:06 +02:00
2018-08-27 11:10:34 -05:00
2021-08-04 12:46:41 +02:00
2019-08-12 12:47:50 -05:00
2020-06-03 13:52:04 -04:00
2020-04-28 16:20:29 -04:00
2020-04-28 16:20:29 -04:00
2023-05-17 11:48:16 +02:00
2021-05-26 12:06:53 +02:00
2020-06-03 13:52:04 -04:00
2021-06-03 09:00:45 +02:00
2020-06-03 13:52:04 -04:00
2020-04-28 16:20:29 -04:00
2020-07-02 12:02:50 -04:00
2020-07-01 01:59:24 -04:00
2023-09-19 12:20:15 +02:00
2020-07-02 12:02:50 -04:00
2020-06-03 13:52:00 -04:00
2020-08-14 16:22:41 -04:00
2020-07-21 15:37:49 -04:00
2020-07-01 01:59:24 -04:00
2023-03-17 08:45:06 +01:00
2020-07-02 12:02:50 -04:00
2020-05-14 16:42:43 -04:00
2020-08-14 16:22:39 -04:00
2020-04-30 16:48:27 -04:00
2018-11-06 14:02:41 -05:00
2021-03-07 12:34:11 +01:00
2019-10-03 09:11:01 -05:00
2019-10-03 09:11:01 -05:00
2020-07-23 10:45:00 -04:00
2019-12-11 15:22:07 -05:00
2021-07-19 09:44:51 +02:00
2020-07-27 16:23:00 -04:00
2020-11-24 12:30:37 -05:00
2020-07-01 01:59:24 -04:00
2020-09-22 17:37:38 -04:00
2020-09-22 17:37:38 -04:00
2021-06-10 13:39:27 +02:00
2020-09-22 17:37:38 -04:00
2020-04-09 10:43:14 -04:00
2020-04-09 10:43:14 -04:00
2020-07-08 09:03:25 -04:00
2022-01-05 12:40:32 +01:00
2020-10-14 15:27:50 -04:00
2021-11-18 14:03:54 +01:00
2020-01-27 16:46:44 -05:00
2021-11-18 14:03:54 +01:00
2019-07-18 14:18:05 -05:00
2022-04-20 09:23:20 +02:00
2020-07-01 01:59:09 -04:00
2020-01-22 16:55:27 -05:00
2019-10-03 09:11:05 -05:00
2019-10-03 09:11:05 -05:00
2023-06-14 11:09:49 +02:00
2020-07-02 12:02:50 -04:00
2020-07-02 12:02:50 -04:00