Eric Dumazet 4b7e90672a devlink: fix netns refcount leak in devlink_nl_cmd_reload() ...

commit 4dbb0dad8e63fcd0b5a117c2861d2abe7ff5f186 upstream.

While preparing my patch series adding netns refcount tracking,
I spotted bugs in devlink_nl_cmd_reload()

Some error paths forgot to release a refcount on a netns.

To fix this, we can reduce the scope of get_net()/put_net()
section around the call to devlink_reload().

Fixes: ccdf07219d ("devlink: Add reload action option to devlink reload command")
Fixes: dc64cc7c63 ("devlink: Add devlink reload limit option")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Moshe Shemesh <moshe@mellanox.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20211205192822.1741045-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2021-12-14 11:32:37 +01:00

..

bpf_sk_storage.c

bpf: Change bpf_sk_storage_*() to accept ARG_PTR_TO_BTF_ID_SOCK_COMMON

2020-09-25 13:58:01 -07:00

datagram.c

udp: fix skb_copy_and_csum_datagram with odd segment sizes

2021-02-17 11:02:28 +01:00

datagram.h

net/core: Allow the compiler to verify declaration and definition consistency

2019-03-27 13:49:44 -07:00

dev_addr_lists.c

net: core: add nested_level variable in net_device

2020-09-28 15:00:15 -07:00

dev_ioctl.c

net: fix dev_ifsioc_locked() race condition

2021-03-07 12:34:07 +01:00

dev.c

net: annotate data-races on txq->xmit_lock_owner

2021-12-08 09:03:25 +01:00

devlink.c

devlink: fix netns refcount leak in devlink_nl_cmd_reload()

2021-12-14 11:32:37 +01:00

drop_monitor.c

drop_monitor: Perform cleanup upon probe registration failure

2021-03-30 14:31:57 +02:00

dst_cache.c

wireguard: device: reset peer src endpoint when netns exits

2021-12-08 09:03:22 +01:00

dst.c

net, bpf: Fix ip6ip6 crash with collect_md populated skbs

2021-03-30 14:32:05 +02:00

failover.c

failover: allow name change on IFF_UP slave interfaces

2019-04-10 22:12:26 -07:00

fib_notifier.c

net: fib_notifier: propagate extack down to the notifier block callback

2019-10-04 11:10:56 -07:00

fib_rules.c

ipv6: fix memory leak in fib6_rule_suppress

2021-12-08 09:03:21 +01:00

filter.c

bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding

2021-11-18 14:04:27 +01:00

flow_dissector.c

flow_dissector: Fix out-of-bounds warnings

2021-09-18 13:40:22 +02:00

flow_offload.c

net: Fix offloading indirect devices dependency on qdisc order creation

2021-09-18 13:40:30 +02:00

gen_estimator.c

net_sched: gen_estimator: support large ewma log

2021-01-27 11:55:23 +01:00

gen_stats.c

docs: networking: convert gen_stats.txt to ReST

2020-04-28 14:39:46 -07:00

gro_cells.c

gro_cells: reduce number of synchronize_net() calls

2020-11-25 11:28:12 -08:00

hwbm.c

net: hwbm: Make the hwbm_pool lock a mutex

2019-06-09 19:40:10 -07:00

link_watch.c

net: linkwatch: fix failure to restore device state across suspend/resume

2021-08-18 08:59:13 +02:00

lwt_bpf.c

lwt_bpf: Replace preempt_disable() with migrate_disable()

2020-12-07 11:53:40 -08:00

lwtunnel.c

net: ipv6: add rpl sr tunnel

2020-03-29 22:30:57 -07:00

Makefile

ethtool: move to its own directory

2019-12-12 17:07:05 -08:00

neighbour.c

net, neigh: Enable state migration between NUD_PERMANENT and NTF_USE

2021-11-18 14:04:29 +01:00

net_namespace.c

net: net_namespace: Fix undefined member in key_remove_domain()

2021-11-18 14:04:02 +01:00

net-procfs.c

net-sysfs: add backlog len and CPU id to softnet data

2020-09-21 13:56:37 -07:00

net-sysfs.c

net-sysfs: try not to restart the syscall if it will fail eventually

2021-11-18 14:03:56 +01:00

net-sysfs.h

net-sysfs: add netdev_change_owner()

2020-02-26 20:07:25 -08:00

net-traces.c

page_pool: add tracepoints for page_pool with details need by XDP

2019-06-19 11:23:13 -04:00

netclassid_cgroup.c

cgroup, netclassid: remove double cond_resched

2020-04-21 15:44:30 -07:00

netevent.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

2019-05-30 11:26:32 -07:00

netpoll.c

net: Have netpoll bring-up DSA management interface

2020-11-18 11:04:11 -08:00

netprio_cgroup.c

netprio_cgroup: Fix unlimited memory leak of v2 cgroups

2020-05-09 20:59:21 -07:00

page_pool.c

mm: fix struct page layout on 32-bit systems

2021-05-19 10:13:17 +02:00

pktgen.c

pktgen: fix misuse of BUG_ON() in pktgen_thread_worker()

2021-03-07 12:34:09 +01:00

ptp_classifier.c

ptp: Add generic ptp v2 header parsing function

2020-08-19 16:07:49 -07:00

request_sock.c

tcp: add rcu protection around tp->fastopen_rsk

2019-10-13 10:13:08 -07:00

rtnetlink.c

rtnetlink: fix if_nlmsg_stats_size() under estimation

2021-10-13 10:04:28 +02:00

scm.c

fs: Add receive_fd() wrapper for __receive_fd()

2020-07-13 11:03:44 -07:00

secure_seq.c

crypto: lib/sha1 - remove unnecessary includes of linux/cryptohash.h

2020-05-08 15:32:17 +10:00

skbuff.c

net: Fix zero-copy head len calculation.

2021-08-08 09:05:23 +02:00

skmsg.c

skmsg: Make sk_psock_destroy() static

2021-08-04 12:46:44 +02:00

sock_diag.c

bpf, net: Rework cookie generator as per-cpu one

2020-09-30 11:50:35 -07:00

sock_map.c

net, sockmap: Don't call bpf_prog_put() on NULL pointer

2020-10-15 21:05:23 +02:00

sock_reuseport.c

udp: Prevent reuseport_select_sock from reading uninitialized socks

2021-01-23 16:03:59 +01:00

sock.c

sock: fix /proc/net/sockstat underflow in sk_clone_lock()

2021-11-26 10:39:14 +01:00

stream.c

net: stream: don't purge sk_error_queue in sk_stream_kill_queues()

2021-11-18 14:04:08 +01:00

sysctl_net_core.c

bpf: Prevent increasing bpf_jit_limit above max

2021-11-18 14:03:42 +01:00

timestamping.c

net: Introduce a new MII time stamping interface.

2019-12-25 19:51:33 -08:00

tso.c

net: tso: add UDP segmentation support

2020-06-18 20:46:23 -07:00

utils.c

net: Fix skb->csum update in inet_proto_csum_replace16().

2020-01-24 20:54:30 +01:00

xdp.c

xdp: fix xdp_return_frame() kernel BUG throw for page_pool memory model

2021-04-14 08:42:09 +02:00