Colin Ian King 3993b112da btrfs: avoid null pointer dereference on fs_info when calling btrfs_crit ...

There are checks on fs_info in __btrfs_panic to avoid dereferencing a
null fs_info, however, there is a call to btrfs_crit that may also
dereference a null fs_info. Fix this by adding a check to see if fs_info
is null and only print the s_id if fs_info is non-null.

Detected by CoverityScan CID#401973 ("Dereference after null check")

Fixes: efe120a067 ("Btrfs: convert printk to btrfs_ and fix BTRFS prefix")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

2017-10-30 12:27:56 +01:00

..

tests

btrfs: tests: Fix a memory leak in error handling path in 'run_test()'

2017-10-30 12:27:56 +01:00

acl.c

btrfs: preserve i_mode if __btrfs_set_acl() fails

2017-08-21 17:47:42 +02:00

async-thread.c

btrfs: constify tracepoint arguments

2017-08-16 14:19:53 +02:00

async-thread.h

btrfs: constify tracepoint arguments

2017-08-16 14:19:53 +02:00

backref.c

Btrfs: convert to use btrfs_get_extent_inline_ref_type

2017-08-21 17:47:43 +02:00

backref.h

btrfs: backref, add tracepoints for prelim_ref insertion and merging

2017-08-16 16:12:01 +02:00

btrfs_inode.h

btrfs: separate defrag and property compression

2017-08-16 16:12:05 +02:00

check-integrity.c

Merge branch 'for-4.14' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux

2017-09-09 13:27:51 -07:00

check-integrity.h

btrfs: take an fs_info directly when the root is not used otherwise

2016-12-06 16:06:59 +01:00

compression.c

Merge branch 'for-4.14-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux

2017-09-29 12:57:35 -07:00

compression.h

Merge branch 'zstd-minimal' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs

2017-09-14 17:30:49 -07:00

ctree.c

btrfs: Remove unused arguments from btrfs_changed_cb_t

2017-10-30 12:27:56 +01:00

ctree.h

btrfs: Remove unused arguments from btrfs_changed_cb_t

2017-10-30 12:27:56 +01:00

dedupe.h

btrfs: expand cow_file_range() to support in-band dedup and subpage-blocksize

2016-07-26 13:52:25 +02:00

delayed-inode.c

btrfs: increase ctx->pos for delayed dir index

2017-08-18 16:36:20 +02:00

delayed-inode.h

btrfs: convert btrfs_delayed_item.refs from atomic_t to refcount_t

2017-04-18 14:07:23 +02:00

delayed-ref.c

Btrfs: return old and new total ref mods when adding delayed refs

2017-06-29 20:17:01 +02:00

delayed-ref.h

Btrfs: return old and new total ref mods when adding delayed refs

2017-06-29 20:17:01 +02:00

dev-replace.c

Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2017-09-14 18:54:01 -07:00

dev-replace.h

btrfs: constify device path passed to relevant helpers

2017-02-28 14:26:07 +01:00

dir-item.c

btrfs: fix validation of XATTR_ITEM dir items

2017-06-29 20:06:11 +02:00

disk-io.c

btrfs: copy fsid to super_block s_uuid

2017-10-30 12:27:55 +01:00

disk-io.h

btrfs: use named constant for bdev blocksize

2017-08-16 16:12:04 +02:00

export.c

btrfs: Check name_len before reading btrfs_get_name

2017-06-21 19:16:04 +02:00

export.h

…

extent_io.c

Merge branch 'for-4.14-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux

2017-10-06 09:03:08 -07:00

extent_io.h

btrfs: struct-funcs, constify readers

2017-08-16 14:19:53 +02:00

extent_map.c

btrfs: convert extent_map.refs from atomic_t to refcount_t

2017-04-18 14:07:23 +02:00

extent_map.h

btrfs: convert extent_map.refs from atomic_t to refcount_t

2017-04-18 14:07:23 +02:00

extent-tree.c

btrfs: Remove redundant argument of __link_block_group

2017-10-30 12:27:56 +01:00

file-item.c

Merge branch 'for-4.13-part1' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux

2017-07-05 16:41:23 -07:00

file.c

Merge branch 'work.read_write' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2017-09-14 19:29:55 -07:00

free-space-cache.c

btrfs: drop newlines from strings when using btrfs_* helpers

2017-08-16 16:12:02 +02:00

free-space-cache.h

btrfs: free-space-cache, clean up unnecessary root arguments

2017-02-17 12:03:56 +01:00

free-space-tree.c

btrfs: pass fs_info to btrfs_del_root instead of tree_root

2017-08-21 17:49:54 +02:00

free-space-tree.h

btrfs: expose internal free space tree routine only if sanity tests are enabled

2017-08-18 16:36:29 +02:00

hash.c

crypto: Work around deallocated stack frame reference gcc bug on sparc.

2017-06-08 17:36:03 +08:00

hash.h

btrfs: advertise which crc32c implementation is being used at module load

2016-06-06 14:08:28 +02:00

inode-item.c

btrfs: take an fs_info directly when the root is not used otherwise

2016-12-06 16:06:59 +01:00

inode-map.c

btrfs: qgroup: Introduce extent changeset for qgroup reserve functions

2017-06-29 20:17:02 +02:00

inode-map.h

Btrfs: Initialize btrfs_root->highest_objectid when loading tree root and subvolume roots

2016-01-15 19:25:02 +01:00

inode.c

btrfs: Remove unused parameter from check_direct_IO

2017-10-30 12:27:56 +01:00

ioctl.c

Btrfs: fix __user casting in ioctl.c

2017-10-30 12:27:55 +01:00

Kconfig

btrfs: Add zstd support

2017-08-15 09:02:09 -07:00

locking.c

btrfs: cleanup, remove stray return statements

2016-01-07 14:30:52 +01:00

locking.h

btrfs: fix lockups from btrfs_clear_path_blocking

2014-11-19 10:34:35 -08:00

lzo.c

btrfs: switch to kvmalloc and GFP_KERNEL in lzo/zlib alloc_workspace

2017-06-19 18:26:02 +02:00

Makefile

btrfs: Add zstd support

2017-08-15 09:02:09 -07:00

math.h

btrfs: cleanup 64bit/32bit divs, compile time constants

2015-03-03 17:23:57 +01:00

ordered-data.c

btrfs: fix integer overflow in calc_reclaim_items_nr

2017-06-29 20:17:02 +02:00

ordered-data.h

btrfs: fix integer overflow in calc_reclaim_items_nr

2017-06-29 20:17:02 +02:00

orphan.c

btrfs: kill the key type accessor helpers

2014-09-17 13:37:12 -07:00

print-tree.c

Btrfs: add one more sanity check for shared ref type

2017-08-21 17:47:43 +02:00

print-tree.h

btrfs: get fs_info from eb in btrfs_print_tree, remove argument

2017-08-16 16:12:03 +02:00

props.c

Merge branch 'zstd-minimal' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs

2017-09-14 17:30:49 -07:00

props.h

Btrfs: add support for inode properties

2014-01-28 13:20:24 -08:00

qgroup.c

btrfs: Report error on removing qgroup if del_qgroup_item fails

2017-09-26 14:54:01 +02:00

qgroup.h

btrfs: qgroup: Fix qgroup reserved space underflow by only freeing reserved ranges

2017-06-29 20:17:02 +02:00

raid56.c

Btrfs: search parity device wisely

2017-10-30 12:27:55 +01:00

raid56.h

btrfs: take an fs_info directly when the root is not used otherwise

2016-12-06 16:06:59 +01:00

rcu-string.h

…

reada.c

btrfs: remove unused member err from reada_extent

2017-06-19 18:25:59 +02:00

relocation.c

btrfs: fix NULL pointer dereference from free_reloc_roots()

2017-09-26 14:51:49 +02:00

root-tree.c

btrfs: Clean up dead code in root-tree

2017-10-30 12:27:56 +01:00

scrub.c

Merge branch 'for-4.14' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux

2017-09-09 13:27:51 -07:00

send.c

btrfs: Remove unused arguments from btrfs_changed_cb_t

2017-10-30 12:27:56 +01:00

send.h

Btrfs: use linux/sizes.h to represent constants

2016-01-07 14:38:02 +01:00

struct-funcs.c

btrfs: struct-funcs, constify readers

2017-08-16 14:19:53 +02:00

super.c

btrfs: avoid null pointer dereference on fs_info when calling btrfs_crit

2017-10-30 12:27:56 +01:00

sysfs.c

Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2017-09-14 18:54:01 -07:00

sysfs.h

btrfs: sysfs: introduce helper for syncing bits with sysfs files

2016-01-21 18:50:40 +01:00

transaction.c

btrfs: fix integer overflow in calc_reclaim_items_nr

2017-06-29 20:17:02 +02:00

transaction.h

btrfs: remove unused qgroup members from btrfs_trans_handle

2017-04-18 14:07:25 +02:00

tree-defrag.c

Btrfs: fix locking bugs when defragging leaves

2015-12-18 02:51:32 +00:00

tree-log.c

btrfs: Remove unused variable

2017-10-30 12:27:55 +01:00

tree-log.h

btrfs: Make btrfs_del_inode_ref take btrfs_inode

2017-02-14 15:50:54 +01:00

ulist.c

btrfs: ulist: rename ulist_fini to ulist_release

2017-02-17 12:03:50 +01:00

ulist.h

btrfs: ulist: rename ulist_fini to ulist_release

2017-02-17 12:03:50 +01:00

uuid-tree.c

btrfs: return the actual error value from from btrfs_uuid_tree_iterate

2016-12-19 18:08:15 +01:00

volumes.c

btrfs: Rework error handling of add_extent_mapping in __btrfs_alloc_chunk

2017-10-30 12:27:56 +01:00

volumes.h

Merge branch 'for-4.14' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux

2017-09-09 13:27:51 -07:00

xattr.c

btrfs: Check name_len with boundary in verify dir_item

2017-06-21 19:16:04 +02:00

xattr.h

btrfs: Switch to generic xattr handlers

2016-05-17 19:17:09 -04:00

zlib.c

btrfs: switch to kvmalloc and GFP_KERNEL in lzo/zlib alloc_workspace

2017-06-19 18:26:02 +02:00

zstd.c

btrfs: Add zstd support

2017-08-15 09:02:09 -07:00