
Panels drivers store their timings in a device data structure field that is initialized at probe time, either from hardcoded values or from firmware-supplied values. Those timings are then reported through the .get_timings() operation to construct the panel display mode. The panel timings are further modified by the .set_timings() operation, which is called with the timings retrieved by .get_timings(), and mangled by .check_timings(). The latter potentially adjusts the pixel clock only. Conceptually, modifying the panel timings is wrong, as the timings are an intrinsic property of the panel and should thus be fixed. Furthermore, modifying them this way at runtime can result in display modes reported to userspace varying between calls, which is also wrong. There's no actual need to store the mangled pixel clock value in the timings. Don't modify the panel timings in the .set_timings() operation, just forward it to the previous device in the display pipeline. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
282 lines
6.1 KiB
C
282 lines
6.1 KiB
C
/*
|
|
* LCD panel driver for Sharp LS037V7DW01
|
|
*
|
|
* Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
|
|
* Author: Tomi Valkeinen <tomi.valkeinen@ti.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License version 2 as published by
|
|
* the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/delay.h>
|
|
#include <linux/gpio/consumer.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/regulator/consumer.h>
|
|
|
|
#include "../dss/omapdss.h"
|
|
|
|
struct panel_drv_data {
|
|
struct omap_dss_device dssdev;
|
|
struct regulator *vcc;
|
|
|
|
struct videomode vm;
|
|
|
|
struct gpio_desc *resb_gpio; /* low = reset active min 20 us */
|
|
struct gpio_desc *ini_gpio; /* high = power on */
|
|
struct gpio_desc *mo_gpio; /* low = 480x640, high = 240x320 */
|
|
struct gpio_desc *lr_gpio; /* high = conventional horizontal scanning */
|
|
struct gpio_desc *ud_gpio; /* high = conventional vertical scanning */
|
|
};
|
|
|
|
static const struct videomode sharp_ls_vm = {
|
|
.hactive = 480,
|
|
.vactive = 640,
|
|
|
|
.pixelclock = 19200000,
|
|
|
|
.hsync_len = 2,
|
|
.hfront_porch = 1,
|
|
.hback_porch = 28,
|
|
|
|
.vsync_len = 1,
|
|
.vfront_porch = 1,
|
|
.vback_porch = 1,
|
|
|
|
.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW,
|
|
};
|
|
|
|
#define to_panel_data(p) container_of(p, struct panel_drv_data, dssdev)
|
|
|
|
static int sharp_ls_connect(struct omap_dss_device *src,
|
|
struct omap_dss_device *dst)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static void sharp_ls_disconnect(struct omap_dss_device *src,
|
|
struct omap_dss_device *dst)
|
|
{
|
|
}
|
|
|
|
static int sharp_ls_enable(struct omap_dss_device *dssdev)
|
|
{
|
|
struct panel_drv_data *ddata = to_panel_data(dssdev);
|
|
struct omap_dss_device *src = dssdev->src;
|
|
int r;
|
|
|
|
if (!omapdss_device_is_connected(dssdev))
|
|
return -ENODEV;
|
|
|
|
if (omapdss_device_is_enabled(dssdev))
|
|
return 0;
|
|
|
|
if (ddata->vcc) {
|
|
r = regulator_enable(ddata->vcc);
|
|
if (r != 0)
|
|
return r;
|
|
}
|
|
|
|
r = src->ops->enable(src);
|
|
if (r) {
|
|
regulator_disable(ddata->vcc);
|
|
return r;
|
|
}
|
|
|
|
/* wait couple of vsyncs until enabling the LCD */
|
|
msleep(50);
|
|
|
|
if (ddata->resb_gpio)
|
|
gpiod_set_value_cansleep(ddata->resb_gpio, 1);
|
|
|
|
if (ddata->ini_gpio)
|
|
gpiod_set_value_cansleep(ddata->ini_gpio, 1);
|
|
|
|
dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void sharp_ls_disable(struct omap_dss_device *dssdev)
|
|
{
|
|
struct panel_drv_data *ddata = to_panel_data(dssdev);
|
|
struct omap_dss_device *src = dssdev->src;
|
|
|
|
if (!omapdss_device_is_enabled(dssdev))
|
|
return;
|
|
|
|
if (ddata->ini_gpio)
|
|
gpiod_set_value_cansleep(ddata->ini_gpio, 0);
|
|
|
|
if (ddata->resb_gpio)
|
|
gpiod_set_value_cansleep(ddata->resb_gpio, 0);
|
|
|
|
/* wait at least 5 vsyncs after disabling the LCD */
|
|
|
|
msleep(100);
|
|
|
|
src->ops->disable(src);
|
|
|
|
if (ddata->vcc)
|
|
regulator_disable(ddata->vcc);
|
|
|
|
dssdev->state = OMAP_DSS_DISPLAY_DISABLED;
|
|
}
|
|
|
|
static void sharp_ls_set_timings(struct omap_dss_device *dssdev,
|
|
const struct videomode *vm)
|
|
{
|
|
struct omap_dss_device *src = dssdev->src;
|
|
|
|
src->ops->set_timings(src, vm);
|
|
}
|
|
|
|
static void sharp_ls_get_timings(struct omap_dss_device *dssdev,
|
|
struct videomode *vm)
|
|
{
|
|
struct panel_drv_data *ddata = to_panel_data(dssdev);
|
|
|
|
*vm = ddata->vm;
|
|
}
|
|
|
|
static const struct omap_dss_device_ops sharp_ls_ops = {
|
|
.connect = sharp_ls_connect,
|
|
.disconnect = sharp_ls_disconnect,
|
|
|
|
.enable = sharp_ls_enable,
|
|
.disable = sharp_ls_disable,
|
|
|
|
.set_timings = sharp_ls_set_timings,
|
|
.get_timings = sharp_ls_get_timings,
|
|
};
|
|
|
|
static int sharp_ls_get_gpio_of(struct device *dev, int index, int val,
|
|
const char *desc, struct gpio_desc **gpiod)
|
|
{
|
|
struct gpio_desc *gd;
|
|
|
|
*gpiod = NULL;
|
|
|
|
gd = devm_gpiod_get_index(dev, desc, index, GPIOD_OUT_LOW);
|
|
if (IS_ERR(gd))
|
|
return PTR_ERR(gd);
|
|
|
|
*gpiod = gd;
|
|
return 0;
|
|
}
|
|
|
|
static int sharp_ls_probe_of(struct platform_device *pdev)
|
|
{
|
|
struct panel_drv_data *ddata = platform_get_drvdata(pdev);
|
|
int r;
|
|
|
|
ddata->vcc = devm_regulator_get(&pdev->dev, "envdd");
|
|
if (IS_ERR(ddata->vcc)) {
|
|
dev_err(&pdev->dev, "failed to get regulator\n");
|
|
return PTR_ERR(ddata->vcc);
|
|
}
|
|
|
|
/* lcd INI */
|
|
r = sharp_ls_get_gpio_of(&pdev->dev, 0, 0, "enable", &ddata->ini_gpio);
|
|
if (r)
|
|
return r;
|
|
|
|
/* lcd RESB */
|
|
r = sharp_ls_get_gpio_of(&pdev->dev, 0, 0, "reset", &ddata->resb_gpio);
|
|
if (r)
|
|
return r;
|
|
|
|
/* lcd MO */
|
|
r = sharp_ls_get_gpio_of(&pdev->dev, 0, 0, "mode", &ddata->mo_gpio);
|
|
if (r)
|
|
return r;
|
|
|
|
/* lcd LR */
|
|
r = sharp_ls_get_gpio_of(&pdev->dev, 1, 1, "mode", &ddata->lr_gpio);
|
|
if (r)
|
|
return r;
|
|
|
|
/* lcd UD */
|
|
r = sharp_ls_get_gpio_of(&pdev->dev, 2, 1, "mode", &ddata->ud_gpio);
|
|
if (r)
|
|
return r;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int sharp_ls_probe(struct platform_device *pdev)
|
|
{
|
|
struct panel_drv_data *ddata;
|
|
struct omap_dss_device *dssdev;
|
|
int r;
|
|
|
|
ddata = devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL);
|
|
if (ddata == NULL)
|
|
return -ENOMEM;
|
|
|
|
platform_set_drvdata(pdev, ddata);
|
|
|
|
r = sharp_ls_probe_of(pdev);
|
|
if (r)
|
|
return r;
|
|
|
|
ddata->vm = sharp_ls_vm;
|
|
|
|
dssdev = &ddata->dssdev;
|
|
dssdev->dev = &pdev->dev;
|
|
dssdev->ops = &sharp_ls_ops;
|
|
dssdev->type = OMAP_DISPLAY_TYPE_DPI;
|
|
dssdev->owner = THIS_MODULE;
|
|
dssdev->of_ports = BIT(0);
|
|
|
|
/*
|
|
* Note: According to the panel documentation:
|
|
* DATA needs to be driven on the FALLING edge
|
|
*/
|
|
dssdev->bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_SYNC_NEGEDGE
|
|
| DRM_BUS_FLAG_PIXDATA_POSEDGE;
|
|
|
|
omapdss_display_init(dssdev);
|
|
omapdss_device_register(dssdev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int __exit sharp_ls_remove(struct platform_device *pdev)
|
|
{
|
|
struct panel_drv_data *ddata = platform_get_drvdata(pdev);
|
|
struct omap_dss_device *dssdev = &ddata->dssdev;
|
|
|
|
omapdss_device_unregister(dssdev);
|
|
|
|
sharp_ls_disable(dssdev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id sharp_ls_of_match[] = {
|
|
{ .compatible = "omapdss,sharp,ls037v7dw01", },
|
|
{},
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, sharp_ls_of_match);
|
|
|
|
static struct platform_driver sharp_ls_driver = {
|
|
.probe = sharp_ls_probe,
|
|
.remove = __exit_p(sharp_ls_remove),
|
|
.driver = {
|
|
.name = "panel-sharp-ls037v7dw01",
|
|
.of_match_table = sharp_ls_of_match,
|
|
.suppress_bind_attrs = true,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(sharp_ls_driver);
|
|
|
|
MODULE_AUTHOR("Tomi Valkeinen <tomi.valkeinen@ti.com>");
|
|
MODULE_DESCRIPTION("Sharp LS037V7DW01 Panel Driver");
|
|
MODULE_LICENSE("GPL");
|