Dave Hansen 30b0a105d9
mm: thp: give transparent hugepage code a separate copy_page ...
Right now, the migration code in migrate_page_copy() uses copy_huge_page()
for hugetlbfs and thp pages:
if (PageHuge(page) || PageTransHuge(page))
copy_huge_page(newpage, page);
So, yay for code reuse. But:
void copy_huge_page(struct page *dst, struct page *src)
{
struct hstate *h = page_hstate(src);
and a non-hugetlbfs page has no page_hstate(). This works 99% of the
time because page_hstate() determines the hstate from the page order
alone. Since the page order of a THP page matches the default hugetlbfs
page order, it works.
But, if you change the default huge page size on the boot command-line
(say default_hugepagesz=1G), then we might not even *have* a 2MB hstate
so page_hstate() returns null and copy_huge_page() oopses pretty fast
since copy_huge_page() dereferences the hstate:
void copy_huge_page(struct page *dst, struct page *src)
{
struct hstate *h = page_hstate(src);
if (unlikely(pages_per_huge_page(h) > MAX_ORDER_NR_PAGES)) {
...
Mel noticed that the migration code is really the only user of these
functions. This moves all the copy code over to migrate.c and makes
copy_huge_page() work for THP by checking for it explicitly.
I believe the bug was introduced in commit b32967ff10
2013-11-21 16:42:27 -08:00
2013-11-15 16:47:22 -08:00
2013-09-26 14:02:33 -04:00
2013-08-21 09:28:29 +02:00
2013-09-09 11:15:49 -07:00
2013-09-29 21:09:34 +02:00
2013-07-09 10:33:30 -07:00
2013-08-14 13:55:15 +05:30
2013-09-27 09:37:01 +09:00
2013-08-19 14:20:21 +05:30
2013-10-29 18:26:15 -07:00
2013-11-18 15:50:07 -08:00
2013-10-16 19:17:06 +01:00
2013-07-10 11:10:27 -07:00
2013-11-14 08:51:29 +09:00
2013-11-15 16:47:22 -08:00
2013-11-07 19:22:48 -05:00
2013-11-08 14:43:01 -08:00
2013-10-30 20:28:43 -04:00
2013-11-06 23:33:14 -08:00
2013-11-04 19:46:58 -05:00
2013-09-27 17:35:41 -07:00
2013-10-16 15:33:50 +02:00
2013-11-20 13:20:24 -08:00
2013-10-25 15:56:51 -07:00
2013-09-10 13:03:41 -07:00
2013-10-24 11:11:39 +01:00
2013-11-06 07:50:37 +01:00
2013-10-25 09:51:41 +01:00
2013-10-02 15:40:57 -04:00
2013-10-28 15:21:32 -04:00
2013-11-13 17:40:34 +09:00
2013-08-02 12:33:54 -07:00
2013-05-14 10:23:57 +05:30
2013-10-19 23:32:14 +02:00
2013-11-14 23:20:45 +01:00
2013-07-03 16:31:35 -07:00
2013-07-30 11:53:12 -04:00
2013-05-29 12:57:34 -07:00
2013-11-09 00:16:28 -05:00
2013-05-29 15:50:34 -04:00
2013-07-03 16:07:42 -07:00
2013-10-27 08:40:39 -04:00
2013-10-17 13:31:19 -07:00
2013-07-15 11:07:56 +01:00
2013-07-09 10:33:19 -07:00
2013-11-08 08:59:44 -07:00
2013-10-16 01:16:04 +02:00
2013-09-30 14:31:02 -07:00
2013-11-13 15:45:43 +09:00
2013-11-08 09:08:12 -07:00
2013-11-14 13:41:48 +09:00
2013-10-25 11:56:00 +01:00
2013-10-28 13:33:58 -06:00
2013-11-19 09:25:07 -07:00
2013-11-08 09:04:30 -07:00
2013-07-03 16:07:39 -07:00
2013-05-15 14:42:15 -07:00
2013-09-04 09:23:46 -04:00
2013-08-30 23:44:11 -07:00
2013-07-09 16:30:35 -07:00
2013-09-23 21:44:16 -04:00
2013-04-30 17:04:01 -07:00
2013-08-19 12:27:17 -07:00
2013-10-07 23:13:33 -07:00
2013-10-02 11:33:23 +02:00
2013-07-30 11:24:20 -07:00
2013-11-15 09:32:23 +09:00
2013-07-30 11:11:44 +02:00
2013-11-13 15:45:43 +09:00
2013-10-11 07:39:14 +02:00
2013-11-15 09:32:21 +09:00
2013-05-20 12:27:59 -07:00
2013-08-14 17:14:51 +02:00
2013-08-14 17:14:54 +02:00
2013-11-09 00:16:29 -05:00
2013-10-23 10:10:20 -07:00
2013-07-08 10:13:40 -04:00
2013-09-13 15:09:52 +02:00
2013-11-14 13:41:48 +09:00
2013-11-15 14:19:54 +09:00
2013-10-30 01:21:24 +01:00
2013-11-06 12:40:27 +01:00
2013-09-11 15:59:10 -07:00
2013-11-03 23:04:56 -05:00
2013-09-07 12:56:26 +10:00
2013-04-29 18:28:19 -07:00
2013-11-09 00:16:30 -05:00
2013-05-12 14:16:21 +02:00
2013-10-03 16:14:12 -07:00
2013-08-18 17:39:55 -07:00
2013-11-15 16:47:22 -08:00
2013-09-20 10:36:34 -04:00
2013-11-14 23:14:43 +01:00
2013-08-02 12:33:54 -07:00
2013-05-01 16:36:22 +05:30
2013-08-27 09:18:29 +02:00
2013-10-31 14:49:24 +00:00
2013-11-16 12:02:36 +05:30
2013-10-23 10:10:12 -07:00
2013-06-28 16:04:36 +02:00
2013-06-28 16:04:36 +02:00
2013-06-28 16:04:36 +02:00
2013-07-06 14:09:38 -07:00
2013-10-23 10:11:00 -07:00
2013-09-25 12:34:33 +01:00
2013-07-03 13:25:24 +02:00
2013-11-09 00:16:24 -05:00
2013-11-09 00:16:23 -05:00
2013-07-15 11:25:00 +09:30
2013-05-07 18:38:27 -07:00
2013-09-26 15:06:58 -07:00
2013-09-07 19:54:57 -04:00
2013-10-29 09:43:37 +10:30
2013-04-29 18:28:40 -07:00
2013-09-27 09:37:01 +09:00
2013-08-26 20:15:23 +09:00
2013-10-29 12:53:04 +02:00
2013-09-26 15:06:58 -07:00
2013-09-26 15:06:58 -07:00
2013-05-01 17:31:42 -04:00
2013-10-07 15:16:45 -04:00
2013-07-27 20:24:36 +02:00
2013-06-06 12:41:57 -07:00
2013-06-17 16:38:57 -07:00
2013-06-19 20:30:32 -07:00
2013-05-12 14:16:22 +02:00
2013-04-30 17:04:00 -07:00
2013-08-22 22:13:54 -07:00
2013-09-12 10:12:47 -07:00
2013-11-15 22:04:17 -05:00
2013-09-27 18:40:25 +01:00
2013-09-27 18:40:25 +01:00
2013-04-29 18:28:41 -07:00
2013-06-29 12:57:13 +04:00
2013-11-05 16:50:20 -05:00
2013-11-05 17:43:40 -05:00
2013-11-13 12:09:22 +09:00
2013-11-19 16:39:06 -05:00
2013-07-09 10:33:21 -07:00
2013-11-12 15:50:46 +09:00
2013-09-25 14:07:54 +02:00
2013-10-11 17:21:14 +11:00
2013-08-30 08:42:01 +10:00
2013-04-30 10:09:06 +02:00
2013-10-01 16:19:08 +01:00
2013-08-26 13:46:11 +02:00
2013-09-13 15:11:21 +02:00
2013-08-26 21:40:24 +02:00
2013-09-26 15:06:58 -07:00
2013-10-31 09:55:48 +01:00
2013-11-15 09:32:14 +09:00
2013-11-21 16:42:27 -08:00
2013-10-13 16:16:26 -07:00
2013-10-13 16:16:28 -07:00
2013-09-29 18:27:03 -07:00
2013-10-03 22:28:31 +02:00
2013-08-26 09:30:03 -07:00
2013-04-29 13:54:36 -04:00
2013-10-16 18:40:57 -07:00
2013-05-08 11:51:05 -07:00
2013-10-28 15:05:28 +01:00
2013-06-05 12:00:27 -07:00
2013-06-13 17:51:04 -07:00
2013-11-15 17:55:48 -05:00
2013-07-23 16:52:47 -07:00
2013-11-11 00:42:07 -05:00
2013-07-23 16:52:47 -07:00
2013-09-26 15:06:58 -07:00
2013-11-06 12:40:26 +01:00
2013-11-13 12:09:26 +09:00
2013-09-24 13:04:07 +02:00
2013-11-15 09:32:22 +09:00
2013-05-31 13:02:52 +10:00
2013-09-25 11:07:04 +02:00
2013-04-29 15:54:37 -07:00
2013-11-03 10:53:11 -08:00
2013-06-17 16:38:57 -07:00
2013-10-28 20:07:50 -04:00
2013-11-13 16:03:02 +01:00
2013-06-06 10:23:58 +09:00
2013-09-13 15:09:52 +02:00
2013-06-24 14:02:41 +01:00
2013-09-13 15:09:52 +02:00
2013-07-01 08:12:41 -04:00
2013-06-12 23:02:35 -04:00
2013-08-09 10:49:00 +02:00
2013-08-20 11:46:54 -07:00
2013-05-13 09:45:01 -04:00
2013-10-19 19:45:35 -04:00
2013-11-13 17:40:34 +09:00
2013-07-26 16:19:48 -07:00
2013-04-29 15:42:02 -04:00
2013-10-03 18:47:54 +02:00
2013-09-13 15:09:52 +02:00
2013-11-13 12:09:07 +09:00
2013-11-06 15:26:55 -05:00
2013-04-17 12:35:33 -07:00
2013-11-15 09:32:23 +09:00
2013-10-03 18:47:54 +02:00
2013-04-30 17:04:06 -07:00
2013-09-26 16:17:33 -07:00
2013-08-28 21:35:14 -07:00
2013-09-26 15:30:22 -07:00
2013-09-11 15:58:52 -07:00
2013-05-16 07:55:07 -07:00
2013-04-30 17:04:02 -07:00
2013-07-25 12:35:39 +02:00
2013-11-04 10:20:57 +02:00
2013-07-03 16:07:43 -07:00
2013-11-09 00:16:21 -05:00
2013-08-25 09:39:12 -04:00
2013-05-05 10:58:06 -07:00
2013-09-10 18:56:32 -04:00
2013-11-13 12:09:24 +09:00
2013-11-15 09:32:22 +09:00
2013-11-06 12:40:26 +01:00
2013-11-15 09:32:20 +09:00
2013-09-11 15:59:45 -07:00
2013-05-31 00:48:22 -07:00
2013-08-23 09:02:14 -04:00
2013-08-06 14:10:45 +00:00
2013-11-13 12:09:08 +09:00
2013-10-16 21:35:53 -07:00
2013-11-13 12:09:06 +09:00
2013-08-21 11:52:20 -07:00
2013-11-13 12:09:05 +09:00
2013-08-22 23:20:54 +08:00
2013-10-09 12:40:32 +02:00
2013-11-13 15:27:00 +09:00
2013-09-11 15:58:01 -07:00
2013-11-15 09:32:20 +09:00
2013-11-20 14:41:47 -08:00
2013-11-13 12:09:11 +09:00
2013-09-11 15:58:01 -07:00
2013-09-07 09:48:41 -07:00
2013-09-23 15:44:58 +09:30
2013-08-20 15:37:42 +09:30
2013-11-09 00:16:19 -05:00
2013-11-13 12:09:36 +09:00
2013-11-06 16:32:19 -07:00
2013-06-26 12:10:56 +02:00
2013-11-11 12:41:33 +01:00
2013-08-02 12:33:54 -07:00
2013-11-09 00:16:19 -05:00
2013-07-03 16:08:05 -07:00
2013-10-25 19:03:39 -04:00
2013-11-07 19:11:41 -05:00
2013-11-15 16:47:22 -08:00
2013-09-26 14:48:15 -07:00
2013-09-26 14:48:15 -07:00
2013-09-26 14:48:15 -07:00
2013-10-14 17:15:48 +02:00
2013-06-27 22:44:16 -07:00
2013-10-25 19:26:58 -04:00
2013-11-16 12:04:02 -08:00
2013-10-28 15:37:43 -04:00
2013-09-27 18:40:25 +01:00
2013-10-28 15:38:02 -04:00
2013-06-20 15:41:18 +02:00
2013-07-25 21:54:01 +02:00
2013-04-29 15:54:36 -07:00
2013-08-27 13:52:52 -04:00
2013-05-04 14:47:26 -04:00
2013-09-03 16:40:32 -04:00
2013-10-09 20:04:10 -05:00
2013-08-21 10:29:51 +01:00
2013-06-12 07:49:19 +05:30
2013-10-09 20:03:54 -05:00
2013-10-29 18:26:14 -07:00
2013-11-08 10:47:28 -06:00
2013-10-27 16:26:58 -07:00
2013-08-28 20:50:19 +01:00
2013-10-24 11:50:36 +01:00
2013-06-12 12:37:30 +01:00
2013-11-12 16:52:17 +09:00
2013-08-15 17:22:27 -07:00
2013-06-11 11:41:51 -05:00
2013-11-13 12:09:04 +09:00
2013-09-03 22:52:48 -04:00
2013-10-09 14:47:45 +02:00
2013-10-11 17:24:39 +11:00
2013-07-03 16:07:32 -07:00
2013-04-29 15:54:28 -07:00
2013-07-03 16:07:31 -07:00
2013-04-19 22:25:51 +02:00
2013-09-05 14:54:29 -07:00
2013-09-15 17:41:30 -04:00
2013-11-14 23:17:21 +01:00
2013-04-17 10:21:17 -06:00
2013-04-17 10:21:17 -06:00
2013-11-07 14:44:27 -07:00
2013-04-17 10:21:17 -06:00
2013-10-25 11:56:00 +01:00
2013-08-23 16:08:27 -04:00
2013-06-16 16:12:26 -07:00
2013-11-13 15:17:16 +09:00
2013-10-04 10:06:08 +02:00
2013-05-31 17:19:05 -07:00
2013-10-24 23:43:29 -04:00
2013-07-03 16:08:03 -07:00
2013-09-26 16:18:32 -07:00
2013-10-25 22:33:23 +02:00
2013-06-03 21:49:52 +02:00
2013-07-15 01:31:37 +02:00
2013-07-03 16:16:20 +02:00
2013-08-27 18:42:48 -07:00
2013-10-17 00:36:06 +02:00
2013-08-19 21:22:34 -07:00
2013-11-13 20:21:47 +01:00
2013-09-25 14:23:07 +02:00
2013-10-29 16:50:52 -07:00
2013-05-01 17:29:47 -04:00
2013-05-01 17:29:39 -04:00
2013-08-19 10:18:11 -07:00
2013-07-09 10:33:26 -07:00
2013-06-28 23:15:06 +02:00
2013-10-16 09:05:57 +02:00
2013-06-21 11:32:51 +02:00
2013-08-14 19:54:30 +01:00
2013-08-20 16:53:58 -05:00
2013-08-17 09:32:32 -04:00
2013-09-11 15:59:36 -07:00
2013-09-11 15:59:37 -07:00
2013-11-11 14:32:15 -05:00
2013-11-13 12:09:33 +09:00
2013-06-02 20:53:59 -07:00
2013-09-23 09:13:49 -07:00
2013-09-25 06:45:06 -07:00
2013-09-25 06:45:06 -07:00
2013-09-25 06:45:06 -07:00
2013-07-09 10:33:29 -07:00
2013-10-28 13:01:35 -07:00
2013-04-30 17:04:09 -07:00
2013-09-12 15:38:02 -07:00
2013-07-12 12:07:46 +02:00
2013-05-24 16:22:50 -07:00
2013-07-03 16:08:05 -07:00
2013-07-03 16:08:05 -07:00
2013-04-29 18:28:22 -07:00
2013-10-25 19:03:45 -04:00
2013-07-09 10:33:30 -07:00
2013-10-09 16:54:39 -07:00
2013-11-19 10:40:00 -08:00
2013-06-17 16:38:57 -07:00
2013-07-25 19:30:03 +10:00
2013-07-09 10:33:28 -07:00
2013-11-15 09:32:20 +09:00
2013-11-15 22:04:17 -05:00
2013-10-16 13:16:19 -07:00
2013-09-16 18:19:04 -07:00
2013-10-17 16:41:50 -07:00
2013-08-27 14:25:27 +05:30
2013-08-20 17:10:41 -07:00
2013-08-27 14:25:09 +05:30
2013-09-10 18:56:32 -04:00
2013-09-01 14:16:33 -07:00
2013-11-15 21:11:16 -05:00
2013-09-04 20:51:33 +03:00
2013-09-04 23:11:42 +03:00
2013-09-04 20:53:16 +03:00
2013-11-15 09:32:22 +09:00
2013-08-02 12:33:54 -07:00
2013-04-29 13:21:30 -04:00
2013-08-07 16:52:33 -07:00
2013-06-19 23:34:50 +02:00
2013-06-19 12:58:42 +02:00
2013-08-13 08:19:26 -07:00
2013-06-20 19:02:45 +04:00
2013-11-06 09:32:09 +02:00
2013-08-30 17:26:09 -04:00
2013-10-09 12:40:45 +02:00
2013-04-30 17:04:03 -07:00
2013-04-30 15:50:12 +05:30
2013-06-21 00:35:12 +02:00
2013-09-12 15:38:02 -07:00
2013-11-15 09:32:14 +09:00
2013-04-17 12:35:32 -07:00
2013-11-16 12:23:18 -08:00
2013-09-26 15:33:18 -07:00
2013-06-12 16:29:44 -07:00
2013-10-16 13:01:44 -07:00
2013-07-31 12:16:45 -07:00
2013-08-29 13:54:34 -07:00
2013-10-18 16:28:11 -06:00
2013-09-03 09:10:24 -04:00
2013-10-17 14:38:44 +02:00
2013-09-25 13:53:10 +02:00
2013-08-14 17:58:56 +02:00
2013-05-14 20:54:06 +02:00
2013-04-25 21:01:45 +08:00
2013-10-10 12:31:43 -07:00
2013-09-20 12:03:46 +02:00
2013-05-21 12:25:02 -05:00
2013-06-20 22:24:32 -07:00
2013-07-23 16:47:10 -07:00
2013-07-23 16:42:59 -07:00
2013-11-12 10:20:12 +09:00
2013-11-06 12:40:25 +01:00
2013-09-25 14:07:54 +02:00
2013-04-19 00:40:07 +02:00
2013-05-20 10:24:22 +09:30
2013-11-06 20:00:09 +01:00
2013-10-16 13:32:04 -07:00
2013-10-16 12:24:19 -07:00
2013-09-07 14:35:32 -07:00
2013-07-09 10:33:29 -07:00
2013-08-05 10:52:36 -06:00
2013-08-29 13:30:21 +10:00
2013-10-11 15:19:22 +10:00
2013-10-17 10:55:37 +10:30
2013-10-29 11:28:11 +10:30
2013-10-29 11:28:17 +10:30
2013-11-13 12:09:11 +09:00
2013-07-09 10:33:21 -07:00
2013-09-03 18:25:03 -07:00
2013-09-11 15:58:01 -07:00
2013-05-27 10:57:53 +09:00
2013-08-14 17:14:54 +02:00
2013-11-14 15:16:16 +11:00
2013-07-30 08:30:16 -04:00
2013-11-13 12:09:07 +09:00
2013-07-12 12:07:46 +02:00
2013-07-25 19:30:03 +10:00
2013-10-17 15:53:09 -04:00
2013-07-10 18:11:34 -07:00
30b0a105d9