30816ac049
host_unregister() gives us no chance between removing the device
and the mcp data structure being freed to access the data inbetween,
which drivers may need to do if they need to iounmap() pointers in
their private data structures.
Therefore, re-jig the interfaces, which are now, on creation:
mcp = mcp_host_alloc()
if (mcp) {
ret = mcp_host_add(mcp, data);
if (!ret)
mcp_host_free(mcp);
}
and on removal:
mcp_host_del(mcp);
... access mcp ...
mcp_host_free(mcp);
The free does the final put_device() on the struct device as one would
expect.
Acked-by: Jochen Friedrich <jochen@scram.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
74 lines
2.0 KiB
C
74 lines
2.0 KiB
C
/*
|
|
* linux/drivers/mfd/mcp.h
|
|
*
|
|
* Copyright (C) 2001 Russell King, All Rights Reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License.
|
|
*/
|
|
#ifndef MCP_H
|
|
#define MCP_H
|
|
|
|
#include <mach/dma.h>
|
|
|
|
struct mcp_ops;
|
|
|
|
struct mcp {
|
|
struct module *owner;
|
|
struct mcp_ops *ops;
|
|
spinlock_t lock;
|
|
int use_count;
|
|
unsigned int sclk_rate;
|
|
unsigned int rw_timeout;
|
|
dma_device_t dma_audio_rd;
|
|
dma_device_t dma_audio_wr;
|
|
dma_device_t dma_telco_rd;
|
|
dma_device_t dma_telco_wr;
|
|
struct device attached_device;
|
|
int gpio_base;
|
|
};
|
|
|
|
struct mcp_ops {
|
|
void (*set_telecom_divisor)(struct mcp *, unsigned int);
|
|
void (*set_audio_divisor)(struct mcp *, unsigned int);
|
|
void (*reg_write)(struct mcp *, unsigned int, unsigned int);
|
|
unsigned int (*reg_read)(struct mcp *, unsigned int);
|
|
void (*enable)(struct mcp *);
|
|
void (*disable)(struct mcp *);
|
|
};
|
|
|
|
void mcp_set_telecom_divisor(struct mcp *, unsigned int);
|
|
void mcp_set_audio_divisor(struct mcp *, unsigned int);
|
|
void mcp_reg_write(struct mcp *, unsigned int, unsigned int);
|
|
unsigned int mcp_reg_read(struct mcp *, unsigned int);
|
|
void mcp_enable(struct mcp *);
|
|
void mcp_disable(struct mcp *);
|
|
#define mcp_get_sclk_rate(mcp) ((mcp)->sclk_rate)
|
|
|
|
struct mcp *mcp_host_alloc(struct device *, size_t);
|
|
int mcp_host_add(struct mcp *);
|
|
void mcp_host_del(struct mcp *);
|
|
void mcp_host_free(struct mcp *);
|
|
|
|
struct mcp_driver {
|
|
struct device_driver drv;
|
|
int (*probe)(struct mcp *);
|
|
void (*remove)(struct mcp *);
|
|
int (*suspend)(struct mcp *, pm_message_t);
|
|
int (*resume)(struct mcp *);
|
|
};
|
|
|
|
int mcp_driver_register(struct mcp_driver *);
|
|
void mcp_driver_unregister(struct mcp_driver *);
|
|
|
|
#define mcp_get_drvdata(mcp) dev_get_drvdata(&(mcp)->attached_device)
|
|
#define mcp_set_drvdata(mcp,d) dev_set_drvdata(&(mcp)->attached_device, d)
|
|
|
|
static inline void *mcp_priv(struct mcp *mcp)
|
|
{
|
|
return mcp + 1;
|
|
}
|
|
|
|
#endif
|