0c8c77d355
commit 0b60f9ead5 (s390: use
device_remove_file_self() instead of device_schedule_callback())
caused random memory corruption on my s390 box. Turns out that the
last element of the ccwgroup structure is of dynamic size, so we
must move the newly introduced work structure _before_ the zero
length array.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
CC: Tejun Heo <tj@kernel.org>
CC: Martin Schwidefsky <schwidefsky@de.ibm.com>
CC: Heiko Carstens <heiko.carstens@de.ibm.com>
CC: Sebastian Ott <sebott@linux.vnet.ibm.com>
CC: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
72 lines
2.3 KiB
C
72 lines
2.3 KiB
C
#ifndef S390_CCWGROUP_H
|
|
#define S390_CCWGROUP_H
|
|
|
|
struct ccw_device;
|
|
struct ccw_driver;
|
|
|
|
/**
|
|
* struct ccwgroup_device - ccw group device
|
|
* @state: online/offline state
|
|
* @count: number of attached slave devices
|
|
* @dev: embedded device structure
|
|
* @cdev: variable number of slave devices, allocated as needed
|
|
*/
|
|
struct ccwgroup_device {
|
|
enum {
|
|
CCWGROUP_OFFLINE,
|
|
CCWGROUP_ONLINE,
|
|
} state;
|
|
/* private: */
|
|
atomic_t onoff;
|
|
struct mutex reg_mutex;
|
|
/* public: */
|
|
unsigned int count;
|
|
struct device dev;
|
|
struct work_struct ungroup_work;
|
|
struct ccw_device *cdev[0];
|
|
};
|
|
|
|
/**
|
|
* struct ccwgroup_driver - driver for ccw group devices
|
|
* @setup: function called during device creation to setup the device
|
|
* @remove: function called on remove
|
|
* @set_online: function called when device is set online
|
|
* @set_offline: function called when device is set offline
|
|
* @shutdown: function called when device is shut down
|
|
* @prepare: prepare for pm state transition
|
|
* @complete: undo work done in @prepare
|
|
* @freeze: callback for freezing during hibernation snapshotting
|
|
* @thaw: undo work done in @freeze
|
|
* @restore: callback for restoring after hibernation
|
|
* @driver: embedded driver structure
|
|
*/
|
|
struct ccwgroup_driver {
|
|
int (*setup) (struct ccwgroup_device *);
|
|
void (*remove) (struct ccwgroup_device *);
|
|
int (*set_online) (struct ccwgroup_device *);
|
|
int (*set_offline) (struct ccwgroup_device *);
|
|
void (*shutdown)(struct ccwgroup_device *);
|
|
int (*prepare) (struct ccwgroup_device *);
|
|
void (*complete) (struct ccwgroup_device *);
|
|
int (*freeze)(struct ccwgroup_device *);
|
|
int (*thaw) (struct ccwgroup_device *);
|
|
int (*restore)(struct ccwgroup_device *);
|
|
|
|
struct device_driver driver;
|
|
};
|
|
|
|
extern int ccwgroup_driver_register (struct ccwgroup_driver *cdriver);
|
|
extern void ccwgroup_driver_unregister (struct ccwgroup_driver *cdriver);
|
|
int ccwgroup_create_dev(struct device *root, struct ccwgroup_driver *gdrv,
|
|
int num_devices, const char *buf);
|
|
|
|
extern int ccwgroup_set_online(struct ccwgroup_device *gdev);
|
|
extern int ccwgroup_set_offline(struct ccwgroup_device *gdev);
|
|
|
|
extern int ccwgroup_probe_ccwdev(struct ccw_device *cdev);
|
|
extern void ccwgroup_remove_ccwdev(struct ccw_device *cdev);
|
|
|
|
#define to_ccwgroupdev(x) container_of((x), struct ccwgroup_device, dev)
|
|
#define to_ccwgroupdrv(x) container_of((x), struct ccwgroup_driver, driver)
|
|
#endif
|