Jie Liu 17ec81c15f
xfs: fix the wrong new_size/rnew_size at xfs_iext_realloc_direct() ...
At xfs_iext_realloc_direct(), the new_size is changed by adding
if_bytes if originally the extent records are stored at the inline
extent buffer, and we have to switch from it to a direct extent
list for those new allocated extents, this is wrong. e.g,
Create a file with three extents which was showing as following,
xfs_io -f -c "truncate 100m" /xfs/testme
for i in $(seq 0 5 10); do
offset=$(($i * $((1 << 20))))
xfs_io -c "pwrite $offset 1m" /xfs/testme
done
Inline
------
irec: if_bytes bytes_diff new_size
1st 0 16 16
2nd 16 16 32
Switching
--------- rnew_size
3rd 32 16 48 + 32 = 80 roundup=128
In this case, the desired value of new_size should be 48, and then
it will be roundup to 64 and be assigned to rnew_size.
However, this issue has been covered by resetting the if_bytes to
the new_size which is calculated at the begnning of xfs_iext_add()
before leaving out this function, and in turn make the rnew_size
correctly again. Hence, this can not be detected via xfstestes.
This patch fix above problem and revise the new_size comments at
xfs_iext_realloc_direct() to make it more readable. Also, fix the
comments while switching from the inline extent buffer to a direct
extent list to reflect this change.
Signed-off-by: Jie Liu <jeff.liu@oracle.com >
Reviewed-by: Dave Chinner <dchinner@redhat.com >
Signed-off-by: Ben Myers <bpm@sgi.com >
2013-10-01 17:33:10 -05:00
2013-05-07 18:45:36 -05:00
2013-09-10 13:57:03 -05:00
2013-09-10 13:57:03 -05:00
2013-08-12 17:49:38 -05:00
2013-05-07 18:45:36 -05:00
2011-08-12 16:21:35 -05:00
2011-08-12 16:21:35 -05:00
2012-11-19 20:11:24 -06:00
2013-09-10 13:57:03 -05:00
2013-06-06 10:52:15 -05:00
2013-08-12 17:44:36 -05:00
2013-05-07 18:45:36 -05:00
2013-04-21 14:53:46 -05:00
2013-08-12 16:57:51 -05:00
2012-11-15 21:35:12 -06:00
2013-10-01 15:42:34 -05:00
2013-09-04 09:23:46 -04:00
2013-08-12 17:47:34 -05:00
2013-08-30 15:20:50 -05:00
2013-08-12 16:35:41 -05:00
2013-08-12 16:41:29 -05:00
2013-08-12 16:52:54 -05:00
2013-05-30 17:26:31 -05:00
2010-01-20 10:47:48 +11:00
2013-08-13 15:48:01 -05:00
2013-08-12 16:53:39 -05:00
2013-09-12 09:42:08 -05:00
2013-09-10 12:49:57 -05:00
2013-09-10 13:57:03 -05:00
2013-08-12 16:56:06 -05:00
2013-09-09 17:43:05 -05:00
2013-08-12 16:58:37 -05:00
2013-09-10 12:49:57 -05:00
2013-09-10 12:49:57 -05:00
2013-09-24 12:31:41 -05:00
2013-08-12 16:06:37 -05:00
2013-09-10 18:56:32 -04:00
2013-09-10 18:56:31 -04:00
2012-11-19 20:11:24 -06:00
2013-09-26 10:38:17 -05:00
2013-08-30 09:48:59 -05:00
2013-07-25 10:41:42 -05:00
2013-09-30 17:49:28 -05:00
2013-08-22 08:44:49 -05:00
2013-09-30 17:49:28 -05:00
2013-09-09 17:43:58 -05:00
2013-08-22 08:44:49 -05:00
2013-08-22 08:40:24 -05:00
2013-09-30 17:49:28 -05:00
2013-09-30 17:49:28 -05:00
2013-08-30 09:48:59 -05:00
2013-09-03 14:51:16 -05:00
2013-08-12 16:36:16 -05:00
2011-08-12 16:21:35 -05:00
2013-09-09 17:43:05 -05:00
2011-08-12 16:21:35 -05:00
2013-09-30 17:48:25 -05:00
2013-07-11 10:35:32 -05:00
2013-08-12 16:55:17 -05:00
2011-03-07 10:09:35 +11:00
2013-08-12 16:53:39 -05:00
2011-08-12 16:21:35 -05:00
2013-09-09 17:43:05 -05:00
2012-05-14 16:21:04 -05:00
2013-08-13 16:10:21 -05:00
2013-08-12 16:07:13 -05:00
2013-08-12 16:53:39 -05:00
2013-08-12 16:55:17 -05:00
2013-08-12 17:00:11 -05:00
2013-08-12 16:43:38 -05:00
2013-09-24 12:35:08 -05:00
2013-08-12 17:47:34 -05:00
2011-01-11 20:28:17 -06:00
2012-11-08 15:34:59 -06:00
2013-05-07 18:45:36 -05:00
2013-04-21 14:53:46 -05:00
2013-08-30 13:48:35 -05:00
2013-06-27 14:26:21 -05:00
2013-09-24 12:32:57 -05:00
2013-09-12 16:13:41 -07:00
2013-08-13 16:10:21 -05:00
2013-08-12 16:10:35 -05:00
2013-09-10 14:07:54 -05:00
2013-09-10 12:49:57 -05:00
2013-10-01 17:33:10 -05:00
2013-08-12 16:37:32 -05:00
2013-08-13 16:10:21 -05:00
2013-08-12 16:05:19 -05:00
2013-08-20 15:44:36 -05:00
2013-08-12 16:55:17 -05:00
2012-05-14 16:20:54 -05:00
2013-09-10 13:57:03 -05:00
2011-08-12 16:21:35 -05:00
2013-09-10 13:57:03 -05:00
2013-08-12 16:56:06 -05:00
2013-10-01 15:42:34 -05:00
2013-10-01 15:42:34 -05:00
2013-08-22 08:40:24 -05:00
2013-08-12 16:53:39 -05:00
2013-09-10 13:57:03 -05:00
2010-06-24 11:35:17 +10:00
2013-08-20 15:30:23 -05:00
2013-08-13 16:21:21 -05:00
2013-09-10 12:49:57 -05:00
2013-08-13 16:21:21 -05:00
2013-10-01 10:26:24 -05:00
2010-05-24 10:33:39 -05:00
2013-08-13 14:19:11 -05:00
2013-09-09 17:43:05 -05:00
2013-08-13 16:12:30 -05:00
2013-05-07 18:45:36 -05:00
2013-05-07 18:45:36 -05:00
2013-08-22 14:05:27 -05:00
2013-08-12 17:45:49 -05:00
2011-02-01 11:42:43 +01:00
2010-01-15 15:34:22 -06:00
2013-08-12 16:09:52 -05:00
2013-08-20 17:00:38 -05:00
2013-09-10 18:56:32 -04:00
2013-09-10 18:56:31 -04:00
2013-08-12 16:20:18 -05:00
2012-03-14 11:09:06 -05:00
2013-09-03 15:00:06 -05:00
2013-08-20 17:00:38 -05:00
2013-08-12 17:47:34 -05:00
2013-08-12 16:13:10 -05:00
2013-08-20 15:51:49 -05:00
2013-08-22 08:49:59 -05:00
2012-03-14 11:09:06 -05:00
2012-03-14 11:09:06 -05:00
2013-09-10 18:56:31 -04:00
2012-10-17 12:01:25 -05:00
2013-08-12 17:44:36 -05:00
2013-09-10 12:57:09 -05:00
2013-08-12 16:43:38 -05:00
2013-06-17 17:42:25 -05:00
2012-11-08 15:34:59 -06:00
2013-08-12 16:09:52 -05:00
2013-07-09 12:29:12 -07:00
2013-08-30 14:14:35 -05:00
2013-08-30 14:14:35 -05:00
2013-08-12 16:09:52 -05:00
2012-05-14 16:20:54 -05:00
2013-06-28 13:00:05 -05:00
2013-08-23 12:57:43 -05:00
2013-08-30 13:59:30 -05:00
2013-08-12 17:48:08 -05:00
2009-02-09 08:37:14 +01:00
2013-08-30 14:14:35 -05:00
2013-08-30 14:14:35 -05:00
2013-08-22 08:40:24 -05:00
2012-03-15 13:40:16 -05:00
2013-08-12 16:53:39 -05:00
2013-05-07 18:45:36 -05:00
17ec81c15f