Eric Biggers 17329563a9 tty: fix compat TIOCGSERIAL leaking uninitialized memory ...

Commit 7765435030 ("take compat TIOC[SG]SERIAL treatment into
tty_compat_ioctl()") changed the compat version of TIOCGSERIAL to start
copying a whole 'serial_struct32' to userspace rather than individual
fields, but failed to initialize all padding and fields -- namely the
hole after the 'iomem_reg_shift' field, and the 'reserved' field.

Fix this by initializing the struct to zero.

[v2: use sizeof, and convert the adjacent line for consistency.]

Reported-by: syzbot+8da9175e28eadcb203ce@syzkaller.appspotmail.com
Fixes: 7765435030 ("take compat TIOC[SG]SERIAL treatment into tty_compat_ioctl()")
Cc: <stable@vger.kernel.org> # v4.20+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20200224182044.234553-2-ebiggers@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2020-03-18 13:15:13 +01:00

..

hvc

Merge tag 'tty-5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty

2019-12-03 14:09:14 -08:00

ipwireless

…

serdev

serdev: Fix detection of UART devices on Apple machines.

2020-03-06 14:10:44 +01:00

serial

tty: serial: fsl_lpuart: free IDs allocated by IDA

2020-03-06 14:10:44 +01:00

vt

vt: selection, push sel_lock up

2020-02-28 16:06:49 +01:00

amiserial.c

Remove every trace of SERIAL_MAGIC

2019-11-13 19:01:14 +08:00

cyclades.c

remove ioremap_nocache and devm_ioremap_nocache

2020-01-06 09:45:59 +01:00

ehv_bytechan.c

…

goldfish.c

…

isicom.c

…

Kconfig

tty: Fix Kconfig indentation, continued

2019-11-21 14:38:31 +01:00

Makefile

…

mips_ejtag_fdc.c

remove ioremap_nocache and devm_ioremap_nocache

2020-01-06 09:45:59 +01:00

moxa.c

remove ioremap_nocache and devm_ioremap_nocache

2020-01-06 09:45:59 +01:00

moxa.h

…

mxser.c

…

mxser.h

…

n_gsm.c

netdev: pass the stuck queue to the timeout handler

2019-12-12 21:38:57 -08:00

n_hdlc.c

tty: n_hdlc: Use flexible-array member and struct_size() helper

2020-01-23 19:22:49 +01:00

n_null.c

…

n_r3964.c

…

n_tracerouter.c

…

n_tracesink.c

…

n_tracesink.h

…

n_tty.c

…

nozomi.c

…

pty.c

…

rocket_int.h

…

rocket.c

tty: rocket: reduce stack usage

2019-11-04 17:42:28 +01:00

rocket.h

…

synclink_gt.c

Merge tag 'tty-5.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty

2020-01-29 10:13:27 -08:00

synclink.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next

2020-01-28 16:02:33 -08:00

synclinkmp.c

Merge tag 'tty-5.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty

2020-01-29 10:13:27 -08:00

sysrq.c

proc: convert everything to "struct proc_ops"

2020-02-04 03:05:26 +00:00

tty_audit.c

…

tty_baudrate.c

tty: baudrate: SPARC supports few more baud rates

2020-01-22 10:23:26 +01:00

tty_buffer.c

…

tty_io.c

tty: fix compat TIOCGSERIAL leaking uninitialized memory

2020-03-18 13:15:13 +01:00

tty_ioctl.c

…

tty_jobctrl.c

…

tty_ldisc.c

tty_ldisc: simplify tty_ldisc_autoload initialization

2019-10-04 15:11:25 +02:00

tty_ldsem.c

locking/lockdep: Remove unused @nested argument from lock_release()

2019-10-09 12:46:10 +02:00

tty_mutex.c

…

tty_port.c

serdev: ttyport: restore client ops on deregistration

2020-02-10 12:26:44 -08:00

ttynull.c

…

vcc.c

…