
Before this change of_get_phy_mode() returned an enum, phy_interface_t. On error, -ENODEV etc, is returned. If the result of the function is stored in a variable of type phy_interface_t, and the compiler has decided to represent this as an unsigned int, comparision with -ENODEV etc, is a signed vs unsigned comparision. Fix this problem by changing the API. Make the function return an error, or 0 on success, and pass a pointer, of type phy_interface_t, where the phy mode should be stored. v2: Return with *interface set to PHY_INTERFACE_MODE_NA on error. Add error checks to all users of of_get_phy_mode() Fixup a few reverse christmas tree errors Fixup a few slightly malformed reverse christmas trees v3: Fix 0-day reported errors. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
303 lines
7.3 KiB
C
303 lines
7.3 KiB
C
// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
|
|
/* Copyright 2019 NXP */
|
|
|
|
#include "dpaa2-eth.h"
|
|
#include "dpaa2-mac.h"
|
|
|
|
#define phylink_to_dpaa2_mac(config) \
|
|
container_of((config), struct dpaa2_mac, phylink_config)
|
|
|
|
static phy_interface_t phy_mode(enum dpmac_eth_if eth_if)
|
|
{
|
|
switch (eth_if) {
|
|
case DPMAC_ETH_IF_RGMII:
|
|
return PHY_INTERFACE_MODE_RGMII;
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
}
|
|
|
|
/* Caller must call of_node_put on the returned value */
|
|
static struct device_node *dpaa2_mac_get_node(u16 dpmac_id)
|
|
{
|
|
struct device_node *dpmacs, *dpmac = NULL;
|
|
u32 id;
|
|
int err;
|
|
|
|
dpmacs = of_find_node_by_name(NULL, "dpmacs");
|
|
if (!dpmacs)
|
|
return NULL;
|
|
|
|
while ((dpmac = of_get_next_child(dpmacs, dpmac)) != NULL) {
|
|
err = of_property_read_u32(dpmac, "reg", &id);
|
|
if (err)
|
|
continue;
|
|
if (id == dpmac_id)
|
|
break;
|
|
}
|
|
|
|
of_node_put(dpmacs);
|
|
|
|
return dpmac;
|
|
}
|
|
|
|
static int dpaa2_mac_get_if_mode(struct device_node *node,
|
|
struct dpmac_attr attr)
|
|
{
|
|
phy_interface_t if_mode;
|
|
int err;
|
|
|
|
err = of_get_phy_mode(node, &if_mode);
|
|
if (!err)
|
|
return if_mode;
|
|
|
|
if_mode = phy_mode(attr.eth_if);
|
|
if (if_mode >= 0)
|
|
return if_mode;
|
|
|
|
return -ENODEV;
|
|
}
|
|
|
|
static bool dpaa2_mac_phy_mode_mismatch(struct dpaa2_mac *mac,
|
|
phy_interface_t interface)
|
|
{
|
|
switch (interface) {
|
|
case PHY_INTERFACE_MODE_RGMII:
|
|
case PHY_INTERFACE_MODE_RGMII_ID:
|
|
case PHY_INTERFACE_MODE_RGMII_RXID:
|
|
case PHY_INTERFACE_MODE_RGMII_TXID:
|
|
return (interface != mac->if_mode);
|
|
default:
|
|
return true;
|
|
}
|
|
}
|
|
|
|
static void dpaa2_mac_validate(struct phylink_config *config,
|
|
unsigned long *supported,
|
|
struct phylink_link_state *state)
|
|
{
|
|
struct dpaa2_mac *mac = phylink_to_dpaa2_mac(config);
|
|
__ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };
|
|
|
|
if (state->interface != PHY_INTERFACE_MODE_NA &&
|
|
dpaa2_mac_phy_mode_mismatch(mac, state->interface)) {
|
|
goto empty_set;
|
|
}
|
|
|
|
phylink_set_port_modes(mask);
|
|
phylink_set(mask, Autoneg);
|
|
phylink_set(mask, Pause);
|
|
phylink_set(mask, Asym_Pause);
|
|
|
|
switch (state->interface) {
|
|
case PHY_INTERFACE_MODE_RGMII:
|
|
case PHY_INTERFACE_MODE_RGMII_ID:
|
|
case PHY_INTERFACE_MODE_RGMII_RXID:
|
|
case PHY_INTERFACE_MODE_RGMII_TXID:
|
|
phylink_set(mask, 10baseT_Full);
|
|
phylink_set(mask, 100baseT_Full);
|
|
phylink_set(mask, 1000baseT_Full);
|
|
break;
|
|
default:
|
|
goto empty_set;
|
|
}
|
|
|
|
linkmode_and(supported, supported, mask);
|
|
linkmode_and(state->advertising, state->advertising, mask);
|
|
|
|
return;
|
|
|
|
empty_set:
|
|
linkmode_zero(supported);
|
|
}
|
|
|
|
static void dpaa2_mac_config(struct phylink_config *config, unsigned int mode,
|
|
const struct phylink_link_state *state)
|
|
{
|
|
struct dpaa2_mac *mac = phylink_to_dpaa2_mac(config);
|
|
struct dpmac_link_state *dpmac_state = &mac->state;
|
|
int err;
|
|
|
|
if (state->speed != SPEED_UNKNOWN)
|
|
dpmac_state->rate = state->speed;
|
|
|
|
if (state->duplex != DUPLEX_UNKNOWN) {
|
|
if (!state->duplex)
|
|
dpmac_state->options |= DPMAC_LINK_OPT_HALF_DUPLEX;
|
|
else
|
|
dpmac_state->options &= ~DPMAC_LINK_OPT_HALF_DUPLEX;
|
|
}
|
|
|
|
if (state->an_enabled)
|
|
dpmac_state->options |= DPMAC_LINK_OPT_AUTONEG;
|
|
else
|
|
dpmac_state->options &= ~DPMAC_LINK_OPT_AUTONEG;
|
|
|
|
if (state->pause & MLO_PAUSE_RX)
|
|
dpmac_state->options |= DPMAC_LINK_OPT_PAUSE;
|
|
else
|
|
dpmac_state->options &= ~DPMAC_LINK_OPT_PAUSE;
|
|
|
|
if (!!(state->pause & MLO_PAUSE_RX) ^ !!(state->pause & MLO_PAUSE_TX))
|
|
dpmac_state->options |= DPMAC_LINK_OPT_ASYM_PAUSE;
|
|
else
|
|
dpmac_state->options &= ~DPMAC_LINK_OPT_ASYM_PAUSE;
|
|
|
|
err = dpmac_set_link_state(mac->mc_io, 0,
|
|
mac->mc_dev->mc_handle, dpmac_state);
|
|
if (err)
|
|
netdev_err(mac->net_dev, "dpmac_set_link_state() = %d\n", err);
|
|
}
|
|
|
|
static void dpaa2_mac_link_up(struct phylink_config *config, unsigned int mode,
|
|
phy_interface_t interface, struct phy_device *phy)
|
|
{
|
|
struct dpaa2_mac *mac = phylink_to_dpaa2_mac(config);
|
|
struct dpmac_link_state *dpmac_state = &mac->state;
|
|
int err;
|
|
|
|
dpmac_state->up = 1;
|
|
err = dpmac_set_link_state(mac->mc_io, 0,
|
|
mac->mc_dev->mc_handle, dpmac_state);
|
|
if (err)
|
|
netdev_err(mac->net_dev, "dpmac_set_link_state() = %d\n", err);
|
|
}
|
|
|
|
static void dpaa2_mac_link_down(struct phylink_config *config,
|
|
unsigned int mode,
|
|
phy_interface_t interface)
|
|
{
|
|
struct dpaa2_mac *mac = phylink_to_dpaa2_mac(config);
|
|
struct dpmac_link_state *dpmac_state = &mac->state;
|
|
int err;
|
|
|
|
dpmac_state->up = 0;
|
|
err = dpmac_set_link_state(mac->mc_io, 0,
|
|
mac->mc_dev->mc_handle, dpmac_state);
|
|
if (err)
|
|
netdev_err(mac->net_dev, "dpmac_set_link_state() = %d\n", err);
|
|
}
|
|
|
|
static const struct phylink_mac_ops dpaa2_mac_phylink_ops = {
|
|
.validate = dpaa2_mac_validate,
|
|
.mac_config = dpaa2_mac_config,
|
|
.mac_link_up = dpaa2_mac_link_up,
|
|
.mac_link_down = dpaa2_mac_link_down,
|
|
};
|
|
|
|
bool dpaa2_mac_is_type_fixed(struct fsl_mc_device *dpmac_dev,
|
|
struct fsl_mc_io *mc_io)
|
|
{
|
|
struct dpmac_attr attr;
|
|
bool fixed = false;
|
|
u16 mc_handle = 0;
|
|
int err;
|
|
|
|
err = dpmac_open(mc_io, 0, dpmac_dev->obj_desc.id,
|
|
&mc_handle);
|
|
if (err || !mc_handle)
|
|
return false;
|
|
|
|
err = dpmac_get_attributes(mc_io, 0, mc_handle, &attr);
|
|
if (err)
|
|
goto out;
|
|
|
|
if (attr.link_type == DPMAC_LINK_TYPE_FIXED)
|
|
fixed = true;
|
|
|
|
out:
|
|
dpmac_close(mc_io, 0, mc_handle);
|
|
|
|
return fixed;
|
|
}
|
|
|
|
int dpaa2_mac_connect(struct dpaa2_mac *mac)
|
|
{
|
|
struct fsl_mc_device *dpmac_dev = mac->mc_dev;
|
|
struct net_device *net_dev = mac->net_dev;
|
|
struct device_node *dpmac_node;
|
|
struct phylink *phylink;
|
|
struct dpmac_attr attr;
|
|
int err;
|
|
|
|
err = dpmac_open(mac->mc_io, 0, dpmac_dev->obj_desc.id,
|
|
&dpmac_dev->mc_handle);
|
|
if (err || !dpmac_dev->mc_handle) {
|
|
netdev_err(net_dev, "dpmac_open() = %d\n", err);
|
|
return -ENODEV;
|
|
}
|
|
|
|
err = dpmac_get_attributes(mac->mc_io, 0, dpmac_dev->mc_handle, &attr);
|
|
if (err) {
|
|
netdev_err(net_dev, "dpmac_get_attributes() = %d\n", err);
|
|
goto err_close_dpmac;
|
|
}
|
|
|
|
dpmac_node = dpaa2_mac_get_node(attr.id);
|
|
if (!dpmac_node) {
|
|
netdev_err(net_dev, "No dpmac@%d node found.\n", attr.id);
|
|
err = -ENODEV;
|
|
goto err_close_dpmac;
|
|
}
|
|
|
|
err = dpaa2_mac_get_if_mode(dpmac_node, attr);
|
|
if (err < 0) {
|
|
err = -EINVAL;
|
|
goto err_put_node;
|
|
}
|
|
mac->if_mode = err;
|
|
|
|
/* The MAC does not have the capability to add RGMII delays so
|
|
* error out if the interface mode requests them and there is no PHY
|
|
* to act upon them
|
|
*/
|
|
if (of_phy_is_fixed_link(dpmac_node) &&
|
|
(mac->if_mode == PHY_INTERFACE_MODE_RGMII_ID ||
|
|
mac->if_mode == PHY_INTERFACE_MODE_RGMII_RXID ||
|
|
mac->if_mode == PHY_INTERFACE_MODE_RGMII_TXID)) {
|
|
netdev_err(net_dev, "RGMII delay not supported\n");
|
|
err = -EINVAL;
|
|
goto err_put_node;
|
|
}
|
|
|
|
mac->phylink_config.dev = &net_dev->dev;
|
|
mac->phylink_config.type = PHYLINK_NETDEV;
|
|
|
|
phylink = phylink_create(&mac->phylink_config,
|
|
of_fwnode_handle(dpmac_node), mac->if_mode,
|
|
&dpaa2_mac_phylink_ops);
|
|
if (IS_ERR(phylink)) {
|
|
err = PTR_ERR(phylink);
|
|
goto err_put_node;
|
|
}
|
|
mac->phylink = phylink;
|
|
|
|
err = phylink_of_phy_connect(mac->phylink, dpmac_node, 0);
|
|
if (err) {
|
|
netdev_err(net_dev, "phylink_of_phy_connect() = %d\n", err);
|
|
goto err_phylink_destroy;
|
|
}
|
|
|
|
of_node_put(dpmac_node);
|
|
|
|
return 0;
|
|
|
|
err_phylink_destroy:
|
|
phylink_destroy(mac->phylink);
|
|
err_put_node:
|
|
of_node_put(dpmac_node);
|
|
err_close_dpmac:
|
|
dpmac_close(mac->mc_io, 0, dpmac_dev->mc_handle);
|
|
return err;
|
|
}
|
|
|
|
void dpaa2_mac_disconnect(struct dpaa2_mac *mac)
|
|
{
|
|
if (!mac->phylink)
|
|
return;
|
|
|
|
phylink_disconnect_phy(mac->phylink);
|
|
phylink_destroy(mac->phylink);
|
|
dpmac_close(mac->mc_io, 0, mac->mc_dev->mc_handle);
|
|
}
|