Arvind Yadav
45a6351849
rtc: constify i2c_device_id
...
i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by <linux/i2c.h> work with
const i2c_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com >
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com >
2017-09-01 01:10:11 +02:00
Alexandre Belloni
fa5691131a
rtc: remove useless DRV_VERSION
...
Many drivers are defining a DRV_VERSION. This is often only used for
MODULE_VERSION and sometimes to print an info message at probe time. This
is kind of pointless as they are all versionned with the kernel anyway.
Also the core will print a message when a new rtc is found.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com >
2016-05-20 12:33:51 +02:00
Axel Lin
8ad0f5b682
rtc: ds1672, max6900, max8998: Add MODULE_DEVICE_TABLE
...
The device table is required to load modules based on modaliases.
After adding MODULE_DEVICE_TABLE, below entries will be added to
modules.alias:
alias i2c:ds1672 rtc_ds1672
alias i2c:max6900 rtc_max6900
alias platform:lp3974-rtc rtc_max8998
alias platform:max8998-rtc rtc_max8998
Signed-off-by: Axel Lin <axel.lin@gmail.com >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: Dale Farnsworth <dale@farnsworth.org >
Cc: Minkyu Kang <mk7.kang@samsung.com >
Cc: Joonyoung Shim <jy0922.shim@samsung.com >
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com >
2015-06-25 01:13:36 +02:00
Sachin Kamat
f16189aca0
drivers/rtc/rtc-max6900.c: remove redundant checks
...
i2c_smbus_write_byte_data() returns negative errno on failure or 0 on
success. Return the value obtained from it directly.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Cc: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-11-13 12:09:27 +09:00
Sachin Kamat
a1396d9f12
drivers/rtc/rtc-max6900.c: remove empty function
...
After the switch to devm_* functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Cc: Dale Farnsworth <dale@farnsworth.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-07-03 16:07:57 -07:00
Jingoo Han
feb141d11a
rtc: rtc-max6900: use devm_rtc_device_register()
...
devm_rtc_device_register() is device managed and makes cleanup paths
simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:30 -07:00
Axel Lin
0abc920116
rtc: convert rtc i2c drivers to module_i2c_driver
...
Factor out some boilerplate code for i2c driver registration into
module_i2c_driver.
Signed-off-by: Axel Lin <axel.lin@gmail.com >
Cc: Piotr Ziecik <kosmo@semihalf.com >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: Scott Wood <scottwood@freescale.com >
Cc: Srikanth Srinivasan <srikanth.srinivasan@freescale.com >
Cc: Mike Rapoport <mike@compulab.co.il >
Cc: Sergey Lapin <slapin@ossfans.org >
Cc: Roman Fietze <roman.fietze@telemotive.de >
Cc: Herbert Valerio Riedel <hvr@gnu.org >
Cc: Alexander Bigga <ab@mycable.de >
Cc: Dale Farnsworth <dale@farnsworth.org >
Cc: Gregory Hermant <gregory.hermant@calao-systems.com >
Cc: Wolfgang Grandegger <wg@grandegger.com >
Cc: Martyn Welch <martyn.welch@ge.com >
Cc: Byron Bradley <byron.bbradley@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-03-23 16:58:39 -07:00
Wan ZongShun
c814dc136f
rtc/max6900: use rtc_valid_tm() to check returning tm
...
Use rtc_valid_tm() to check returning tm for max6900, it can avoid
returning wrong tm value.
Signed-off-by: Wan ZongShun <mcuos.com@gmail.com >
Acked-by: Dale Farnsworth <dale@farnsworth.org >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-08-11 08:59:07 -07:00
Alessandro Zummo
fe102c71a6
rtc: fix missing id_table in rtc-ds1672 and rtc-max6900 drivers
...
Add missing id_table to the drivers in subject. Patch is against the
latest git. It should go in with 2.6.28 if possible, the drivers won't
work without the id_table bits.
Signed-off-by: Alessandro Zummo <a.zummo@towertech.it >
Reported-by: Imre Kaloz <kaloz@openwrt.org >
Tested-by: Imre Kaloz <kaloz@openwrt.org >
Cc: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-12-10 08:01:52 -08:00
Adrian Bunk
fe20ba70ab
drivers/rtc/: use bcd2bin/bin2bcd
...
Change drivers/rtc/ to use the new bcd2bin/bin2bcd functions instead of
the obsolete BCD_TO_BIN/BIN_TO_BCD/BCD2BIN/BIN2BCD macros.
Signed-off-by: Adrian Bunk <bunk@kernel.org >
Acked-by: Alessandro Zummo <a.zummo@towertech.it >
Cc: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-10-20 08:52:41 -07:00
Alessandro Zummo
6fd5c03f82
rtc-max6900 new style driver
...
New style conversion and reformatting as per indent --linux-style
Signed-off-by: Alessandro Zummo <a.zummo@towertech.it >
Cc: Dale Farnsworth <dale@farnsworth.org >
Cc: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-10-16 11:21:40 -07:00
Harvey Harrison
2a4e2b8780
rtc: replace remaining __FUNCTION__ occurrences
...
__FUNCTION__ is gcc-specific, use __func__
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com >
Cc: David Brownell <david-b@pacbell.net >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-04-28 08:58:17 -07:00
Jean Delvare
922539a0a3
i2c: normal_i2c can be made const (rtc drivers)
...
Signed-off-by: Jean Delvare <khali@linux-fr.org >
Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it >
2008-01-27 18:14:47 +01:00
Dale Farnsworth
8a2601f6aa
rtc: update and use the MAX6900 century byte
...
We now read and write the century byte in the max6900 chip. We probably
don't need to do so on Linux-only system, but it's necessary when the chip
is shared by another OS that uses the century byte.
Signed-off-by: Dale Farnsworth <dale@farnsworth.org >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-07-21 17:49:17 -07:00
Dale Farnsworth
aa5bd7e929
rtc: add RTC class driver for the Maxim MAX6900
...
Signed-off-by: Dale Farnsworth.org <dale@farnsworth.org >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: David Brownell <david-b@pacbell.net >
Cc: Jean Delvare <khali@linux-fr.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:03 -07:00