Alexandre Belloni
22652ba724
rtc: stop validating rtc_time in .read_time
...
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2018-03-02 10:09:58 +01:00
Nobuhiro Iwamatsu
5c6e5eca79
rtc: r9701: Remove r9701_remove function
...
r9701_remove function is now empty, remove it.
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org >
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com >
2017-11-29 22:13:30 +01:00
Andrew F. Davis
3821a065f5
spi: Drop owner assignment from spi_drivers
...
An spi_driver does not need to set an owner, it will be populated by the
driver core.
Signed-off-by: Andrew F. Davis <afd@ti.com >
Acked-by: Jonathan Cameron <jic23@kernel.org >
Signed-off-by: Mark Brown <broonie@kernel.org >
2015-10-28 10:30:17 +09:00
Jingoo Han
fbf52c0d7e
rtc: rtc-r9701: use spi_set_drvdata()
...
Use the wrapper functions for getting and setting the driver data using
spi_device instead of using dev_{get|set}_drvdata with &spi->dev, so we
can directly pass a struct spi_device.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:34 -07:00
Jingoo Han
9b6d955aed
rtc: rtc-r9701: use devm_rtc_device_register()
...
devm_rtc_device_register() is device managed and makes cleanup paths
simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:31 -07:00
Greg Kroah-Hartman
5a167f4543
Drivers: rtc: remove __dev* attributes.
...
CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
markings need to be removed.
This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.
Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.
Cc: Bill Pemberton <wfp5p@virginia.edu >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com >
Cc: Linus Walleij <linus.walleij@linaro.org >
Cc: Mike Frysinger <vapier.adi@gmail.com >
Cc: Wan ZongShun <mcuos.com@gmail.com >
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn >
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-01-03 15:57:02 -08:00
Andrew Morton
8e74b6edc9
drivers/rtc/rtc-r9701.c: check that r9701_set_datetime() succeeded
...
When the driver detects that the clock time is invalid, it attempts to
write a sane time into the hardware. We curently assume that everything
is OK if those writes succeeded. But it is better to re-read the time
from the hardware to ensure that the new settings got there OK.
Cc: Devendra Naga <devendra.aaru@gmail.com >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: Anatolij Gustschin <agust@denx.de >
Cc: Andreas Dumberger <andreas.dumberger@tqs.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-07-30 17:25:18 -07:00
Devendra Naga
aa11ec593e
drivers/rtc/rtc-r9701.c: avoid second call to rtc_valid_tm()
...
r9701_get_datetime() calls rtc_valid_tm() and returns the value returned
by rtc_valid_tm(), which can be used in the `if', so calling
rtc_valid_tm() a second time is not required.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: Anatolij Gustschin <agust@denx.de >
Cc: Andreas Dumberger <andreas.dumberger@tqs.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-07-30 17:25:18 -07:00
Andreas Dumberger
bb58da08f0
drivers/rtc/rtc-r9701.c: reset registers if invalid values are detected
...
hwclock refuses to set date/time if RTC registers contain invalid
values. Check the date/time register values at probe time and
initialize them to make hwclock happy.
Signed-off-by: Andreas Dumberger <andreas.dumberger@tqs.de >
Signed-off-by: Anatolij Gustschin <agust@denx.de >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-04-12 13:12:12 -07:00
Axel Lin
109e941843
rtc: convert rtc spi drivers to module_spi_driver
...
Factor out some boilerplate code for spi driver registration into
module_spi_driver.
Signed-off-by: Axel Lin <axel.lin@gmail.com >
Cc: Mark Jackson <mpfj@mimc.co.uk >
Cc: Dennis Aberilla <denzzzhome@yahoo.com >
Cc: Nikolaus Voss <n.voss@weinmann.de >
Cc: "Kim B. Heino" <Kim.Heino@bluegiga.com >
Cc: Raphael Assenat <raph@raphnet.net >
Cc: Chris Verges <chrisv@cyberswitching.com >
Cc: Magnus Damm <damm@opensource.se >
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-03-23 16:58:39 -07:00
Anatolij Gustschin
73737b8787
drivers/rtc/rtc-r9701.c: fix crash in r9701_remove()
...
If probing the RTC didn't succeed due to failed RTC register access, the
RTC device will be unregistered. Then, when removing the module
r9701_remove() causes a kernel crash while trying to unregister a not
registered RTC device. Fix this by doing RTC register access test before
RTC device registration.
Signed-off-by: Anatolij Gustschin <agust@denx.de >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-03-05 15:49:43 -08:00
Anton Vorontsov
e0626e3844
spi: prefix modalias with "spi:"
...
This makes it consistent with other buses (platform, i2c, vio, ...). I'm
not sure why we use the prefixes, but there must be a reason.
This was easy enough to do it, and I did it.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com >
Cc: David Brownell <dbrownell@users.sourceforge.net >
Cc: David Woodhouse <dwmw2@infradead.org >
Cc: Grant Likely <grant.likely@secretlab.ca >
Cc: Jean Delvare <khali@linux-fr.org >
Cc: Ben Dooks <ben-linux@fluff.org >
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org >
Cc: Dmitry Torokhov <dtor@mail.ru >
Cc: Samuel Ortiz <sameo@openedhand.com >
Cc: "John W. Linville" <linville@tuxdriver.com >
Acked-by: Mike Frysinger <vapier.adi@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2009-09-23 07:39:43 -07:00
Adrian Bunk
fe20ba70ab
drivers/rtc/: use bcd2bin/bin2bcd
...
Change drivers/rtc/ to use the new bcd2bin/bin2bcd functions instead of
the obsolete BCD_TO_BIN/BIN_TO_BCD/BCD2BIN/BIN2BCD macros.
Signed-off-by: Adrian Bunk <bunk@kernel.org >
Acked-by: Alessandro Zummo <a.zummo@towertech.it >
Cc: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-10-20 08:52:41 -07:00
Adrian Bunk
7a8fc9b248
removed unused #include <linux/version.h>'s
...
This patch lets the files using linux/version.h match the files that
#include it.
Signed-off-by: Adrian Bunk <bunk@kernel.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-08-23 12:14:12 -07:00
S.Çağlar Onur
9820380a38
rtc-r9701.c: silence compiler warning
...
Commit 75b6102257caglar@pardus.org.tr >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-09 23:27:01 -08:00
Magnus Damm
75b6102257
rtc: add support for Epson RTC-9701JE V4
...
Add support for the Epson RTC-9701JE SPI RTC device.
Signed-off-by: Magnus Damm <damm@igel.co.jp >
Acked-by: Alessandro Zummo <a.zummo@towertech.it >
Acked-by: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:14 -08:00
Magnus Damm
2805b96984
rtc: add support for Epson RTC-9701JE V2
...
Add support for the Epson RTC-9701JE SPI RTC device.
Signed-off-by: Magnus Damm <damm@igel.co.jp >
Acked-by: Alessandro Zummo <a.zummo@towertech.it >
Acked-by: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:14 -08:00
