Thierry Reding
4c271bb67c
watchdog: Convert to devm_ioremap_resource()
...
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de >
Cc: Wim Van Sebroeck <wim@iguana.be >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-01-25 12:21:48 -08:00
Bill Pemberton
4b12b896c2
watchdog: remove use of __devexit
...
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu >
Cc: Wim Van Sebroeck <wim@iguana.be >
Cc: Wan ZongShun <mcuos.com@gmail.com >
Cc: Ben Dooks <ben-linux@fluff.org >
Cc: Kukjin Kim <kgene.kim@samsung.com >
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-28 12:00:24 -08:00
Bill Pemberton
2d991a164a
watchdog: remove use of __devinit
...
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu >
Cc: Wim Van Sebroeck <wim@iguana.be >
Cc: Wan ZongShun <mcuos.com@gmail.com >
Cc: Ben Dooks <ben-linux@fluff.org >
Cc: Kukjin Kim <kgene.kim@samsung.com >
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-28 12:00:24 -08:00
Bill Pemberton
82268714bd
watchdog: remove use of __devexit_p
...
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu >
Cc: Wim Van Sebroeck <wim@iguana.be >
Cc: Wan ZongShun <mcuos.com@gmail.com >
Cc: Ben Dooks <ben-linux@fluff.org >
Cc: Kukjin Kim <kgene.kim@samsung.com >
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2012-11-28 12:00:24 -08:00
John Crispin
cdb8612147
watchdog: MIPS: lantiq: implement OF support and minor fixes
...
Add support for OF. We also apply the following small fixes
* reduce boiler plate by using devm_request_and_ioremap
* sane error path for the clock
* move LTQ_RST_CAUSE_WDTRST to a soc specific header file
* add a message to show that the driver loaded
Signed-off-by: John Crispin <blogic@openwrt.org >
Acked-by: Wim Van Sebroeck <wim@iguana.be >
Cc: linux-watchdog@vger.kernel.org
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/3810/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org >
2012-05-21 14:31:54 +01:00
Wim Van Sebroeck
86a1e1896c
watchdog: nowayout is bool
...
nowayout is actually a boolean value.
So make it bool for all watchdog device drivers.
Signed-off-by: Wim Van Sebroeck <wim@iguana.be >
2012-03-27 20:06:02 +02:00
Joe Perches
27c766aaac
watchdog: Use pr_<fmt> and pr_<level>
...
Use the current logging styles.
Make sure all output has a prefix.
Add missing newlines.
Remove now unnecessary PFX, NAME, and miscellaneous other #defines.
Coalesce formats.
Signed-off-by: Joe Perches <joe@perches.com >
Signed-off-by: Wim Van Sebroeck <wim@iguana.be >
2012-03-27 19:59:26 +02:00
Julia Lawall
60daac4a90
drivers/watchdog/lantiq_wdt.c: drop iounmap for devm_ allocated data
...
Data allocated with devm_ioremap or devm_ioremap_nocache should not be
freed using iounmap, because doing so causes a dangling pointer, and a
subsequent double free.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/ )
// <smpl>
@r@
expression x;
@@
(
x = devm_ioremap(...)
|
x = devm_ioremap_nocache(...)
)
@@
expression r.x;
@@
* iounmap(x)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk >
Signed-off-by: Wim Van Sebroeck <wim@iguana.be >
2012-01-06 15:27:30 +01:00
John Crispin
9cfce47b14
watchdog: lantiq: fix watchdogs timeout handling
...
The enable function was using the global timeout variable for local operations.
This resulted in the value of the global variable being corrupted, thus
breaking the code.
Signed-off-by: John Crispin <blogic@openwrt.org >
Signed-off-by: Thomas Langer <thomas.langer@lantiq.com >
Signed-off-by: Wim Van Sebroeck <wim@iguana.be >
Cc: linux-watchdog@vger.kernel.org
Cc: linux-mips@linux-mips.org
2011-09-20 14:28:24 +02:00
John Crispin
2f58b8d04e
MIPS: Lantiq: Add watchdog support
...
This patch adds the driver for the watchdog found inside the Lantiq SoC family.
Signed-off-by: John Crispin <blogic@openwrt.org >
Signed-off-by: Ralph Hempel <ralph.hempel@lantiq.com >
Cc: Wim Van Sebroeck <wim@iguana.be >
Cc: linux-mips@linux-mips.org
Cc: linux-watchdog@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/2327/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org >
2011-05-19 09:55:43 +01:00