Alexandre Belloni
aef069a277
rtc: lpc32xx: remove .remove
...
dpm_sysfs_remove() and device_pm_remove() are already called by
device_del() on device removal so there is no need to call
device_init_wakeup(dev, false) from the driver and it allows to remove the
.remove callback.
Link: https://lore.kernel.org/r/20191021155806.3625-2-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-11-08 16:14:09 +01:00
YueHaibing
09ef18bcd5
rtc: use devm_platform_ioremap_resource() to simplify code
...
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com >
Link: https://lore.kernel.org/r/20191006102953.57536-2-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-3-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-4-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-5-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-6-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-7-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-8-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-9-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-10-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-11-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-12-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-13-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-14-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-15-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-16-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-17-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-18-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-19-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-20-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-21-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-22-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-23-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-24-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-25-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-26-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-27-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-28-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-29-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-30-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-31-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-32-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-33-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-34-yuehaibing@huawei.com
Link: https://lore.kernel.org/r/20191006102953.57536-35-yuehaibing@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-10-07 01:07:35 +02:00
Alexandre Belloni
7342e2a73a
rtc: lpc32xx: convert to SPDX identifier
...
Use SPDX-License-Identifier instead of a verbose license text.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-04-12 12:23:20 +02:00
Alexandre Belloni
34b21c9ee8
rtc: lpc32xx: use .set_time
...
Use .set_time instead of the deprecated .set_mmss.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-04-12 12:23:20 +02:00
Alexandre Belloni
f04dd349a3
rtc: lpc32xx: switch to rtc_time64_to_tm/rtc_tm_to_time64
...
Call the 64bit versions of rtc_tm time conversion now that the range is
enforced by the core.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-04-12 12:23:20 +02:00
Alexandre Belloni
ba4a84f5ab
rtc: lpc32xx: simplify IRQ setup
...
Move the optional IRQ setup to a single location.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-04-12 12:23:20 +02:00
Alexandre Belloni
3a13426908
rtc: lpc32xx: set range
...
The LPC32xx RTC is a 32bit second counter.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-04-12 12:23:20 +02:00
Alexandre Belloni
6bbad585fd
rtc: lpc32xx: convert to devm_rtc_allocate_device
...
This allows further improvement of the driver.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2019-04-12 12:23:20 +02:00
Wolfram Sang
85368bb9de
rtc: simplify getting .drvdata
...
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com >
Acked-by: Michal Simek <michal.simek@xilinx.com > (for zynqmp)
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2018-05-03 22:08:00 +02:00
Alexandre Belloni
ab62670e57
rtc: stop validating rtc_time after rtc_time_to_tm
...
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2018-03-01 10:49:41 +01:00
Vladimir Zapolskiy
529af7d198
rtc: lpc32xx: remove irq > NR_IRQS check from probe()
...
If the driver is used on an ARM platform with SPARSE_IRQ defined,
semantics of NR_IRQS is different (minimal value of virtual irqs)
and by default it is set to 16, see arch/arm/include/asm/irq.h.
This value may be less than the actual number of virtual irqs, which
may break the driver initialization. The check removal allows to use
the driver on such a platform, and, if irq controller driver works
correctly, the check is not needed on legacy platforms.
Fixes a runtime problem:
rtc-lpc32xx 40024000.rtc: Can't get interrupt resource
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com >
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com >
2016-01-11 20:19:59 +01:00
Wolfram Sang
0929ae376e
rtc: drop owner assignment from platform_drivers
...
A platform_driver does not need to set an owner, it will be populated by the
driver core.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de >
2014-10-20 16:21:31 +02:00
Jingoo Han
5c336b0a7a
rtc: rtc-lpc32xx: remove unnecessary OOM messages
...
The site-specific OOM messages are unnecessary, because they duplicate
the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2014-04-03 16:21:18 -07:00
Julia Lawall
7c1d69ee11
rtc: simplify devm_request_mem_region/devm_ioremap
...
Convert the composition of devm_request_mem_region and devm_ioremap to a
single call to devm_ioremap_resource. The associated call to
platform_get_resource is also simplified and moved next to the new call
to devm_ioremap_resource.
This was done using a combination of the semantic patches
devm_ioremap_resource.cocci and devm_request_and_ioremap.cocci, found in
the scripts/coccinelle/api directory.
In rtc-lpc32xx.c and rtc-mv.c, the local variable size is no longer needed.
In rtc-ds1511.c the size field of the local structure is not useful any
more, and is deleted.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-09-11 15:58:59 -07:00
Jingoo Han
99c3e1c59a
rtc: rtc-lpc32xx: remove unnecessary platform_set_drvdata()
...
The driver core clears the driver data to NULL after device_release or
on probe failure, since commit 0998d06310
("device-core: Ensure drvdata
= NULL when no driver is bound"). Thus, it is not needed to manually
clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-07-03 16:07:50 -07:00
Jingoo Han
bbd05b2db6
rtc: rtc-lpc32xx: use devm_rtc_device_register()
...
devm_rtc_device_register() is device managed and makes cleanup
paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:26 -07:00
Greg Kroah-Hartman
5a167f4543
Drivers: rtc: remove __dev* attributes.
...
CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
markings need to be removed.
This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.
Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.
Cc: Bill Pemberton <wfp5p@virginia.edu >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com >
Cc: Linus Walleij <linus.walleij@linaro.org >
Cc: Mike Frysinger <vapier.adi@gmail.com >
Cc: Wan ZongShun <mcuos.com@gmail.com >
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn >
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-01-03 15:57:02 -08:00
Roland Stigge
e862e7c4ee
drivers/rtc/rtc-lpc32xx.c: add device tree support
...
Adds device tree support for rtc-lpc32xx.c
Signed-off-by: Roland Stigge <stigge@antcom.de >
Acked-by: Rob Herring <rob.herring@calxeda.com >
Acked-by: Arnd Bergmann <arnd@arndb.de >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-05-29 16:22:34 -07:00
Yong Zhang
2f6e5f9458
drivers/rtc: remove IRQF_DISABLED
...
Since commit e58aa3d2d0
("genirq: run irq handlers with interrupts
disabled") we run all interrupt handlers with interrupts disabled and we
even check and yell when an interrupt handler returns with interrupts
enabled - see commit b738a50a20
("genirq: warn when handler enables
interrupts").
So now this flag is a NOOP and can be removed.
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com >
Acked-by: Linus Walleij <linus.walleij@linaro.org >
Acked-by: Wan ZongShun <mcuos.com@gmail.com >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: Thomas Gleixner <tglx@linutronix.de >
Cc: Ingo Molnar <mingo@elte.hu >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-03-23 16:58:39 -07:00
Axel Lin
0c4eae6659
rtc: convert drivers/rtc/* to use module_platform_driver()
...
This patch converts the drivers in drivers/rtc/* to use the
module_platform_driver() macro which makes the code smaller and a bit
simpler.
Signed-off-by: Axel Lin <axel.lin@gmail.com >
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com >
Acked-by: Mike Frysinger <vapier@gentoo.org >
Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn >
Acked-by: Linus Walleij <linus.walleij@linaro.org >
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com >
Cc: Lars-Peter Clausen <lars@metafoo.de >
Cc: Ben Dooks <ben@simtec.co.uk >
Cc: John Stultz <john.stultz@linaro.org >
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-01-10 16:30:53 -08:00
Lucas De Marchi
25985edced
Fix common misspellings
...
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi >
2011-03-31 11:26:23 -03:00
Kevin Wells
9aa449bed2
rtc: rtc-lpc32xx: introduce RTC driver for the LPC32XX SoC
...
Add an RTC driver for the built-in RTC in the LPC32XX SoC. This patch
includes updates from the initial review comments and updates from the v3
review.
Signed-off-by: Kevin Wells <wellsk40@gmail.com >
Signed-off-by: Durgesh Pattamatta <durgesh.pattamatta@nxp.com >
Reviewed-by: Wolfram Sang <w.sang@pengutronix.de >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-10-27 18:03:05 -07:00