Johan Hovold
870db5d101
can: ucan: fix non-atomic allocation in completion handler
...
USB completion handlers are called in atomic context and must
specifically not allocate memory using GFP_KERNEL.
Fixes: 9f2d3eae88
("can: ucan: add driver for Theobroma Systems UCAN devices")
Cc: stable <stable@vger.kernel.org > # 4.19
Cc: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com >
Cc: Martin Elshuber <martin.elshuber@theobroma-systems.com >
Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com >
Signed-off-by: Johan Hovold <johan@kernel.org >
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de >
2019-12-03 11:15:08 +01:00
Colin Ian King
3b17d41754
can: ucan: fix spelling mistake: "resumbmitting" -> "resubmitting"
...
Trivial fix to spelling mistake in netdev_dbg error message
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de >
2018-11-28 16:19:52 +01:00
YueHaibing
ff1f19d56c
can: ucan: remove duplicated include from ucan.c
...
Remove duplicated include.
Signed-off-by: YueHaibing <yuehaibing@huawei.com >
Reviewed-by: Martin Elshuber <martin.elshuber@theobroma-systems.com >
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de >
2018-11-09 17:20:07 +01:00
YueHaibing
207681fc5f
can: ucan: remove set but not used variable 'udev'
...
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/can/usb/ucan.c: In function 'ucan_disconnect':
drivers/net/can/usb/ucan.c:1578:21: warning:
variable 'udev' set but not used [-Wunused-but-set-variable]
struct usb_device *udev;
Signed-off-by: YueHaibing <yuehaibing@huawei.com >
Reviewed-by: Martin Elshuber <martin.elshuber@theobroma-systems.com >
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de >
2018-11-09 17:20:07 +01:00
Jakob Unterwurzacher
9f2d3eae88
can: ucan: add driver for Theobroma Systems UCAN devices
...
The UCAN driver supports the microcontroller-based USB/CAN
adapters from Theobroma Systems. There are two form-factors
that run essentially the same firmware:
* Seal: standalone USB stick ( https://www.theobroma-systems.com/seal )
* Mule: integrated on the PCB of various System-on-Modules from
Theobroma Systems like the A31-µQ7 and the RK3399-Q7
( https://www.theobroma-systems.com/rk3399-q7 )
The USB wire protocol has been designed to be as generic and
hardware-indendent as possible in the hope of being useful for
implementation on other microcontrollers.
Signed-off-by: Martin Elshuber <martin.elshuber@theobroma-systems.com >
Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com >
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com >
Acked-by: Wolfgang Grandegger <wg@grandegger.com >
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de >
2018-07-27 10:40:16 +02:00