Andy Shevchenko
0e1540208e
x86: pmc_atom: Expose contents of PSS
...
The PSS register reflects the power state of each island on SoC. It would be
useful to know which of the islands is on or off at the momemnt.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Acked-by: Aubrey Li <aubrey.li@linux.intel.com >
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
Cc: Kumar P. Mahesh <mahesh.kumar.p@intel.com >
Link: http://lkml.kernel.org/r/1421253575-22509-6-git-send-email-andriy.shevchenko@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
2015-01-20 12:50:14 +01:00
Andy Shevchenko
4b25f42a37
x86: pmc_atom: Clean up init function
...
There is no need to use err variable.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Acked-by: Aubrey Li <aubrey.li@linux.intel.com >
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
Cc: Kumar P. Mahesh <mahesh.kumar.p@intel.com >
Link: http://lkml.kernel.org/r/1421253575-22509-5-git-send-email-andriy.shevchenko@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
2015-01-20 12:50:14 +01:00
Andy Shevchenko
4922b9ce89
x86: pmc-atom: Remove unused macro
...
DRIVER_NAME seems unused. This patch just removes it. There is no functional
change.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Cc: Aubrey Li <aubrey.li@linux.intel.com >
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
Cc: Kumar P. Mahesh <mahesh.kumar.p@intel.com >
Link: http://lkml.kernel.org/r/1421253575-22509-4-git-send-email-andriy.shevchenko@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
2015-01-20 12:50:14 +01:00
Andy Shevchenko
d5df8fe34b
x86: pmc_atom: don%27t check for NULL twice
...
debugfs_remove_recursive() is NULL-aware, thus, we may safely remove the check
here. There is no need to assing NULL to variable since it will be not used
anywhere.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Acked-by: Aubrey Li <aubrey.li@linux.intel.com >
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
Cc: Kumar P. Mahesh <mahesh.kumar.p@intel.com >
Link: http://lkml.kernel.org/r/1421253575-22509-3-git-send-email-andriy.shevchenko@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
2015-01-20 12:50:14 +01:00
Andy Shevchenko
1b43d7125f
x86: pmc-atom: Assign debugfs node as soon as possible
...
pmc_dbgfs_unregister() will be called when pmc->dbgfs_dir is unconditionally
NULL on error path in pmc_dbgfs_register(). To prevent this we move the
assignment to where is should be.
Fixes: f855911c1f
(x86/pmc_atom: Expose PMC device state and platform sleep state)
Reported-by: Thomas Gleixner <tglx@linutronix.de >
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Cc: Aubrey Li <aubrey.li@linux.intel.com >
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
Cc: Kumar P. Mahesh <mahesh.kumar.p@intel.com >
Link: http://lkml.kernel.org/r/1421253575-22509-2-git-send-email-andriy.shevchenko@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
2015-01-20 12:50:14 +01:00
Martin Kelly
9575a6a23a
x86/platform/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n
...
When compiling with CONFIG_DEBUG_FS=n, GCC emits an unused
variable warning for pmc_atom.c because "ret" is used only
within the CONFIG_DEBUG_FS block.
This patch adds a dummy #ifdef for pmc_dbgfs_register() when
CONFIG_DEBUG_FS=n to simplify the code and remove the warning.
Signed-off-by: Martin Kelly <martkell@amazon.com >
Acked-by: "Li, Aubrey" <aubrey.li@linux.intel.com >
Cc: vishwesh.m.rudramuni@intel.com
Link: http://lkml.kernel.org/r/1410963476-8360-1-git-send-email-martin@martingkelly.com
Signed-off-by: Ingo Molnar <mingo@kernel.org >
2014-09-19 13:02:21 +02:00
Dan Carpenter
4c51cb005b
x86/pmc_atom: Silence shift wrapping warnings in pmc_sleep_tmr_show()
...
I don't know if we really need 64 bits here but these variables are
declared as u64 and it can't hurt to cast this so we prevent any shift
wrapping.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com >
Acked-by: Aubrey Li <aubrey.li@linux.intel.com >
Link: http://lkml.kernel.org/r/20140801082715.GE28869@mwanda
Signed-off-by: H. Peter Anvin <hpa@zytor.com >
2014-08-02 16:52:17 -07:00
Li, Aubrey
f855911c1f
x86/pmc_atom: Expose PMC device state and platform sleep state
...
Add the following interfaces to exposes PMC device state and sleep
state residency via debugfs:
/sys/kernel/debugfs/pmc_atom/dev_state
/sys/kernel/debugfs/pmc_atom/sleep_state
Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com >
Link: http://lkml.kernel.org/r/53B0FF59.8000600@linux.intel.com
Signed-off-by: Kasagar, Srinidhi <srinidhi.kasagar@intel.com >
Reviewed-by: Rudramuni, Vishwesh M <vishwesh.m.rudramuni@intel.com >
Reviewed-by: Joe Perches <joe@perches.com >
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com >
2014-07-25 14:12:14 -07:00
Li, Aubrey
b00055cade
x86/pmc_atom: Eisable a few S0ix wake up events for S0ix residency
...
Disable PMC S0IX_WAKE_EN events coming from LPC block(unused) and
also from GPIO_SUS ored dedicated IRQs (must be disabled as per PMC
programming rule), GPIOSCORE ored dedicated IRQs (must be disabled
as per PMC programming rule), GPIO_SUS shared IRQ (not necessary
since the IOAPIC_DS wake event will still work), GPIO_SCORE shared
IRQ (not necessary since the IOAPIC_DS wake event will still work).
Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com >
Link: http://lkml.kernel.org/r/53B0FF22.5080403@linux.intel.com
Signed-off-by: Olivier Leveque <olivier.leveque@intel.com >
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com >
2014-07-25 14:11:58 -07:00
Li, Aubrey
93e5eadd1f
x86/platform: New Intel Atom SOC power management controller driver
...
The Power Management Controller (PMC) controls many of the power
management features present in the Atom SoC. This driver provides
a native power off function via PMC PCI IO port.
On some ACPI hardware-reduced platforms(e.g. ASUS-T100), ACPI sleep
registers are not valid so that (*pm_power_off)() is not hooked by
acpi_power_off(). The power off function in this driver is installed
only when pm_power_off is NULL.
Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com >
Link: http://lkml.kernel.org/r/53B0FEEA.3010805@linux.intel.com
Signed-off-by: Lejun Zhu <lejun.zhu@linux.intel.com >
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com >
2014-07-25 14:11:29 -07:00