Al Viro
96d2ca4ec0
[IPVS] bug: endianness breakage in ip_vs_ftp
...
(p[3]<<24) | (p[2]<<16) | (p[1]<<8) | p[0] is not a valid
way to spell get_unaligned((__be32 *)p
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:03:05 -07:00
Al Viro
014d730d56
[IPVS]: ipvs annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:03:04 -07:00
Al Viro
d4263cde88
[NETFILTER]: h323 annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:03:03 -07:00
Al Viro
6a19d61472
[NETFILTER]: ipt annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:03:02 -07:00
Al Viro
a76b11dd25
[NETFILTER]: NAT annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:03:01 -07:00
Al Viro
cdcb71bf96
[NETFILTER]: conntrack annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:03:00 -07:00
Al Viro
59b8bfd8fd
[NETFILTER]: netfilter misc annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:59 -07:00
Simon Horman
28b06c380f
[IPVS]: Make sure ip_vs_ftp ports are valid: module_param_array approach
...
I'm not entirely sure what happens in the case of a valid port,
at best it'll be silently ignored. This patch ensures that
the port values are unsigned short values, and thus always valid.
This is a second take at fixing this problem, it is simpler
and arguably more correct than the previous approach
that was committed as 3f5af5b353
.
Prior to this patch a patch that reverses
3f5af5b353
was sent.
Signed-off-by: Simon Horman <horms@verge.net.au >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:56 -07:00
Simon Horman
e44fd82caf
[IPVS]: Reverse valid ip_vs_ftp ports fix: port check approach
...
This patch reverses 3f5af5b353
as
a better fix was suggested by Patrick McHardy.
Signed-off-by: Simon Horman <horms@verge.net.au >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:55 -07:00
Al Viro
4324a17430
[XFRM]: fl_ipsec_spi is net-endian
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:43 -07:00
Al Viro
6067b2baba
[XFRM]: xfrm_parse_spi() annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:39 -07:00
Al Viro
a94cfd1974
[XFRM]: xfrm_state_lookup() annotations
...
spi argument of xfrm_state_lookup() is net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:37 -07:00
Al Viro
8f83f23e6d
[XFRM]: ports in struct xfrm_selector annotated
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:33 -07:00
Al Viro
9f8552996d
[IPV4]: inet_diag annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:29 -07:00
Al Viro
82103232ed
[IPV4]: inet_rcv_saddr() annotations
...
inet_rcv_saddr() returns net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:28 -07:00
Al Viro
23f33c2d4f
[IPV4]: struct inet_timewait_sock annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:27 -07:00
Al Viro
fb99c848e5
[IPV4]: annotate inet_lookup() and friends
...
inet_lookup() annotated along with helper functions (__inet_lookup(),
__inet_lookup_established(), inet_lookup_established(),
inet_lookup_listener(), __inet_lookup_listener() and inet_ehashfn())
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:26 -07:00
Al Viro
4f765d842f
[IPV4]: INET_MATCH() annotations
...
INET_MATCH() and friends depend on an interesting set of kludges:
* there's a pair of adjacent fields in struct inet_sock - __be16 dport
followed by __u16 num. We want to search by pair, so we combine the keys into
a single 32bit value and compare with 32bit value read from &...->dport.
* on 64bit targets we combine comparisons with pair of adjacent __be32
fields in the same way.
Make sure that we don't mix those values with anything else and that pairs
we form them from have correct types.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:25 -07:00
Al Viro
45d60b9e29
[IPV4]: FRA_{DST,SRC} annotated
...
use be32 netlink accessors for those
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:24 -07:00
Al Viro
81f7bf6cba
[IPV4]: net/ipv4/fib annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:23 -07:00
Al Viro
114c7844f3
[IPV4]: mroute annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:22 -07:00
Al Viro
df7a3b07c2
[TCP] net/ipv4/tcp_output.c: trivial annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:20 -07:00
Al Viro
b03d73e30c
[IPV4] net/ipv4/icmp.c: trivial annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:19 -07:00
Al Viro
734ab87f63
[UDP] net/ipv4/udp.c: trivial annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:17 -07:00
Al Viro
6b72977bd6
[IPV4]: inet_csk_search_req() annotations
...
rport argument is net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:15 -07:00
Al Viro
ed9bad06ee
[IPV4] net/ipv4/arp.c: trivial annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:14 -07:00
Al Viro
4f3608b787
[TCP] net/ipv4/tcp_input.c: trivial annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:11 -07:00
Al Viro
35986b329f
[IPV4]: ip_icmp_error() annotations
...
port is net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:09 -07:00
Al Viro
0579016ec4
[IPV4]: ip_local_error() annotations
...
port argument is net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:08 -07:00
Al Viro
269bd27e66
[TCP]: struct tcp_sack_block annotations
...
Some of the instances of tcp_sack_block are host-endian, some - net-endian.
Define struct tcp_sack_block_wire identical to struct tcp_sack_block
with u32 replaced with __be32; annotate uses of tcp_sack_block replacing
net-endian ones with tcp_sack_block_wire. Change is obviously safe since
for cc(1) __be32 is typedefed to u32.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:04 -07:00
Al Viro
63007727e0
[IPV4]: trivial igmp annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:02 -07:00
Al Viro
c0cda068aa
[IPV4]: ip_mc_sf_allow() annotated
...
ip_mc_sf_allow() expects addresses to be passed net-endian.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:01 -07:00
Al Viro
ea4d9e7220
[IPV4]: struct ip_sf_list and struct ip_sf_socklist annotated
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:02:00 -07:00
Al Viro
8f935bbd7c
[IPV4]: ip_mc_{inc,dec}_group() annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:58 -07:00
Al Viro
4b06a7cf2f
[IPV4]: ip_local_error() ipv4 address argument annotated
...
daddr is net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:56 -07:00
Al Viro
e25d2ca6b2
[IPV4]: trivial ip_options.c annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:55 -07:00
Al Viro
c1d18f9fa0
[IPV4]: struct ipcm_cookie annotation
...
->addr is net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:54 -07:00
Al Viro
3ca3c68e76
[IPV4]: struct ip_options annotations
...
->faddr is net-endian; annotated as such, variables inferred to be net-endian
annotated.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:53 -07:00
Al Viro
7f25afbbef
[IPV4]: inet_csk_search_req() (partial) annotations
...
raddr is net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:52 -07:00
Al Viro
adaf345b53
[IPV4]: annotate address in inet_request_sock
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:51 -07:00
Olaf Kirch
321efff7c3
[IPV4]: Fix order in inet_init failure path.
...
This is just a minor buglet I came across by accident - when inet_init
fails to register raw_prot, it jumps to out_unregister_udp_proto which
should unregister UDP _and_ TCP.
Signed-off-by: Olaf Kirch <okir@suse.de >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:48 -07:00
Al Viro
13d8eaa06a
[IPV4]: ip_build_and_send_pkt() annotations
...
saddr and daddr are net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:19 -07:00
Al Viro
8712f774dc
[IPV4]: ip_options_build() annotations
...
daddr is net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:18 -07:00
Al Viro
e8192f367c
[IPV4] bug: broken open-coded inet_make_mask() (multipath_wrandom)
...
multipath_wrandom.c::__multipath_lookup_weight() contains open-coded
attempt at inet_make_mask(); broken on big-endian.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:17 -07:00
Al Viro
f20f4a60d7
[IPV4] multipath_wrandom.c: trivial annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:16 -07:00
Al Viro
d9cd66e0e5
[IPV4]: multipath_set_nhinfo() annotations
...
multipath_set_nhinfo() (and underlying callback) take net-endian
network and netmask.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:15 -07:00
Al Viro
32ab5f8033
[IPV4] fib_trie.c: trivial annotations
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:14 -07:00
Al Viro
1e8aa6f125
[IPV4] bug: open-coded inet_make_mask() in fib_semantic_match() is broken
...
... and works only on little-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:13 -07:00
Al Viro
1ef1b8c85b
[IPV4]: fib_semantic_match() annotations
...
'mask' and 'zone' arguments are net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:12 -07:00
Al Viro
b6e80c6c8b
[IPV4]: trivial fib_hash.c annotations
...
hash key and stored netmask are net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: David S. Miller <davem@davemloft.net >
2006-09-28 18:01:11 -07:00