Srinivas Pandruvada
021afd55e2
HID: intel-ish-hid: request_irq failure
...
On some platforms ISH interrupt is shared, which causes request_irq to
fail. This requires IRQF_SHARED irq flag.
But IRQF_NO_SUSPEND and IRQF_SHARED should not be used together, so
removed IRQF_NO_SUSPEND flag. Anyway this driver doesn't require
IRQF_NO_SUSPEND, as this interrupt is not required during "noirq" phases
of suspending and resuming devices as well as during the time when
nonboot CPUs are taken offline and brought back online.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com >
Signed-off-by: Jiri Kosina <jkosina@suse.cz >
2016-11-05 15:57:38 +01:00
Borislav Petkov
1793e1c521
HID: intel-ish-hid: Fix !CONFIG_PM build warning
...
Fix
drivers/hid/intel-ish-hid/ipc/pci-ish.c:247:12: warning: ‘ish_suspend’ defined but not used [-Wunused-function]
static int ish_suspend(struct device *device)
^
drivers/hid/intel-ish-hid/ipc/pci-ish.c:282:12: warning: ‘ish_resume’ defined but not used [-Wunused-function]
static int ish_resume(struct device *device)
^
by sticking them in the CONFIG_PM range too.
Signed-off-by: Borislav Petkov <bp@suse.de >
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com >
Cc: Jiri Kosina <jikos@kernel.org >
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com >
Cc: Wei Yongjun <weiyongjun1@huawei.com >
Cc: linux-input@vger.kernel.org
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com >
Signed-off-by: Jiri Kosina <jkosina@suse.cz >
2016-11-03 12:12:09 -06:00
Wei Yongjun
37becf6e60
HID: intel-ish-hid: use module_pci_driver to simplify the code
...
Use the module_pci_driver() macro to make the code simpler
by eliminating module_init and module_exit calls.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com >
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com >
Signed-off-by: Jiri Kosina <jkosina@suse.cz >
2016-08-29 09:36:19 +02:00
Srinivas Pandruvada
ae02e5d40d
HID: intel-ish-hid: ipc layer
...
This layer is responsible for
- Enumerating over PCI bus
- Inform FW about host readiness
- Provide HW interface to transport layer for control and messages
- Interrupt handling and routing
Original-author: Daniel Drubin <daniel.drubin@intel.com >
Reviewed-and-tested-by: Ooi, Joyce <joyce.ooi@intel.com >
Tested-by: Grant Likely <grant.likely@secretlab.ca >
Tested-by: Rann Bar-On <rb6@duke.edu >
Tested-by: Atri Bhattacharya <badshah400@aim.com >
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com >
Signed-off-by: Jiri Kosina <jkosina@suse.cz >
2016-08-17 11:13:07 +02:00