Quentin Lambert
43abdbcece
memstick: remove deprecated use of pci api
...
Replace occurences of the pci api by appropriate call to the dma api.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr )
@deprecated@
idexpression id;
position p;
@@
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@bad1@
idexpression id;
position deprecated.p;
@@
...when != &id->dev
when != pci_get_drvdata ( id )
when != pci_enable_device ( id )
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@depends on !bad1@
idexpression id;
expression direction;
position deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com >
Cc: Maxim Levitsky <maximlevitsky@gmail.com >
Cc: Greg KH <greg@kroah.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2015-06-30 19:44:57 -07:00
Thierry Reding
5ef9819234
memstick: r592: fix build warnings for !PM_SLEEP
...
When PM_SLEEP is not enabled, the r592_clear_interrupts() function is
never used. If so, don't build it to prevent a compiler warning.
Signed-off-by: Thierry Reding <treding@nvidia.com >
Cc: Maxim Levitsky <maximlevitsky@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2014-10-14 02:18:22 +02:00
Wolfram Sang
16735d022f
tree-wide: use reinit_completion instead of INIT_COMPLETION
...
Use this new function to make code more comprehensible, since we are
reinitialzing the completion, not initializing.
[akpm@linux-foundation.org: linux-next resyncs]
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-11-15 09:32:21 +09:00
Libo Chen
5af1a9ce3d
drivers/memstick/host/r592.c: convert to module_pci_driver
...
Signed-off-by: Libo Chen <libo.chen@huawei.com >
Cc: Maxim Levitsky <maximlevitsky@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-07-03 16:08:06 -07:00
Jingoo Han
8d46fa1179
drivers/memstick/host/r592.c: make r592_pm_ops static
...
r592_pm_ops is not exported. Also, CONFIG_PM_SLEEP is used to
remove unnecessary ifdefs.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Cc: Maxim Levitsky <maximlevitsky@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-30 17:04:08 -07:00
Wei Yongjun
940da353a8
memstick: move the dereference below the NULL test
...
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/ )
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn >
Cc: Maxim Levitsky <maximlevitsky@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-02-27 19:10:23 -08:00
Rusty Russell
90ab5ee941
module_param: make bool parameters really bool (drivers & misc)
...
module_param(bool) used to counter-intuitively take an int. In
fddd5201
(mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com >
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
2012-01-13 09:32:20 +10:30
Lucas De Marchi
25985edced
Fix common misspellings
...
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi >
2011-03-31 11:26:23 -03:00
Stephen Rothwell
5ede9ddfba
memstick: make enable_dma less generic in r592
...
Fixes this build error:
drivers/memstick/host/r592.c:26: error: 'enable_dma' redeclared as different kind of symbol
arch/powerpc/include/asm/dma.h:189: note: previous definition of 'enable_dma' was here
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au >
Cc: Andrew Morton <akpm@linux-foundation.org >
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Cc: Alex Dubov <oakad@yahoo.com >
Acked-by: Maxim Levitsky <maximlevitsky@gmail.com >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2011-03-28 16:24:29 -07:00
Maxim Levitsky
9263412501
memstick: add driver for Ricoh R5C592 card reader
...
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com >
Acked-by: Alex Dubov <oakad@yahoo.com >
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2011-03-25 17:45:16 -07:00