Christophe JAILLET
41ef387820
rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'
...
In case of error, we return 0.
This is spurious and not consistent with the other functions of the driver.
Propagate the error code instead.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr >
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2018-11-22 18:11:35 +01:00
Krzysztof Kozlowski
734c5cd5bc
rtc: maxim: Add SPDX license identifiers
...
Replace GPL v2.0+ license statements with SPDX license
identifiers.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2018-08-14 23:38:45 +02:00
Alexandre Belloni
22652ba724
rtc: stop validating rtc_time in .read_time
...
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com >
2018-03-02 10:09:58 +01:00
Javier Martinez Canillas
63074cc3d4
rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
...
These platform drivers have a platform device ID table but the module
alias information is not created so module autoloading will not work.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com >
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com >
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com >
2015-09-05 19:37:21 +02:00
Joe Perches
a737e835e5
rtc: use more standard kernel logging styles
...
Neaten the logging a bit by adding #define pr_fmt
Miscellanea:
o Remove __FILE__/__func__ uses
o Coalesce formats adding missing spaces
o Align arguments
o (rtc-cmos) Integrated 2 consecutive messages
Signed-off-by: Joe Perches <joe@perches.com >
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: Joshua Kinard <kumba@gentoo.org >
Cc: Chanwoo Choi <cw00.choi@samsung.com >
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com >
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com >
Cc: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2015-04-17 09:04:02 -04:00
Wolfram Sang
0929ae376e
rtc: drop owner assignment from platform_drivers
...
A platform_driver does not need to set an owner, it will be populated by the
driver core.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de >
2014-10-20 16:21:31 +02:00
Sachin Kamat
f7de2a1d6d
drivers/rtc/rtc-max8997.c: remove empty function
...
After the switch to devm_* functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Cc: <ms925.kim@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-07-03 16:07:57 -07:00
Sachin Kamat
f887a9de55
drivers/rtc/rtc-max8997.c: remove space before semicolon
...
Fixes the following warning:
WARNING: space prohibited before semicolon
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Cc: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-07-03 16:07:47 -07:00
Linus Torvalds
5d434fcb25
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
...
Pull trivial tree updates from Jiri Kosina:
"Usual stuff, mostly comment fixes, typo fixes, printk fixes and small
code cleanups"
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (45 commits)
mm: Convert print_symbol to %pSR
gfs2: Convert print_symbol to %pSR
m32r: Convert print_symbol to %pSR
iostats.txt: add easy-to-find description for field 6
x86 cmpxchg.h: fix wrong comment
treewide: Fix typo in printk and comments
doc: devicetree: Fix various typos
docbook: fix 8250 naming in device-drivers
pata_pdc2027x: Fix compiler warning
treewide: Fix typo in printks
mei: Fix comments in drivers/misc/mei
treewide: Fix typos in kernel messages
pm44xx: Fix comment for "CONFIG_CPU_IDLE"
doc: Fix typo "CONFIG_CGROUP_CGROUP_MEMCG_SWAP"
mmzone: correct "pags" to "pages" in comment.
kernel-parameters: remove outdated 'noresidual' parameter
Remove spurious _H suffixes from ifdef comments
sound: Remove stray pluses from Kconfig file
radio-shark: Fix printk "CONFIG_LED_CLASS"
doc: put proper reference to CONFIG_MODULE_SIG_ENFORCE
...
2013-04-30 09:36:50 -07:00
Sachin Kamat
406dc00407
drivers/rtc/rtc-max8997.c: fix incorrect return value on error
...
'ret' was being returned without initializing it to error code. While at
it also remove duplicate return statement.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Cc: Jonghwa Lee <jonghwa3.lee@samsung.com >
Cc: Chiwoong Byun <woong.byun@samsung.com >
Cc: Laxman dewangan <ldewangan@nvidia.com >
Cc: Venu Byravarasu <vbyravarasu@nvidia.com >
Cc: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:34 -07:00
Jingoo Han
4ce903cc91
rtc: rtc-max8997: use devm_rtc_device_register()
...
devm_rtc_device_register() is device managed and makes cleanup
paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:26 -07:00
Masanari Iida
a895d57da0
treewide: Fix typo in printks
...
Correct spelling typos in printk and comments.
Signed-off-by: Masanari Iida <standby24x7@gmail.com >
Acked-by: Randy Dunlap <rdunlap@infradead.org >
Signed-off-by: Jiri Kosina <jkosina@suse.cz >
2013-04-12 15:21:36 +02:00
Jingoo Han
c1879fe80c
rtc: rtc-max8997: use devm_request_threaded_irq()
...
Use devm_request_threaded_irq() to make cleanup paths more simple.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-02-21 17:22:30 -08:00
Jonghwa Lee
5e0b2704a1
rtc: max8997: add driver for max8997 rtc
...
Add an rtc driver for Maxim 8997 multifunction chip. Max8997 has rtc
module in it. and it can be used for timekeeping clock and system alarm.
It provide various operational mode those are BCD/binary, 24/12hour,
am/pm. Driver sets binary/24/ for default. Maxim 8997 also supports
SMPL(Sudden Momentary Power Loss), WTSR (Watchdog Timeout and Software
Reset).
Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com >
Cc: Devendra Naga <devendra.aaru@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-02-21 17:22:28 -08:00