Jeff Garzik
a6343afb6e
drivers/*: mark variables with uninitialized_var()
...
Mark variables in drivers/* with uninitialized_var() if such a warning
appears, and analysis proves that the var is initialized properly on all
paths it is used.
Signed-off-by: Jeff Garzik <jeff@garzik.org >
2007-07-17 16:23:19 -04:00
Jiri Slaby
c4923b4f13
Char: cyclades, fix sparse warning
...
cyclades, fix sparse warning
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-07-17 10:23:10 -07:00
Jiri Slaby
054f5b0aaa
Char: cyclades, add firmware loading
...
cyclades, add firmware loading
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-07-17 10:23:10 -07:00
Alan Cox
7e7d136e9e
serial: remove termios checks from various old char serial drivers
...
Signed-off-by: Alan Cox <alan@redhat.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-07-16 09:05:52 -07:00
Jiri Slaby
3fcbc72965
Char: cyclades, fix deadlock
...
An omitted unlock.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Cc: <stable@kernel.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-23 20:14:13 -07:00
Jiri Slaby
c8e1693a4f
Char: cyclades, copyright and version changes
...
- add copyright
- move version one number upper and use MODULE_VERSION
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:25 -07:00
Jiri Slaby
3137553d3f
Char: cyclades, probe cleanup
...
- add fail paths
- merge 3 similar initializations into one (Z, Ze, Y)
[akpm@linux-foundation.org: build fix]
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-05-08 11:15:25 -07:00
Jiri Slaby
dd025c0c7a
Char: cyclades, dynamic ports
...
and save thus approx. 160k of .bss
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:25 -07:00
Jiri Slaby
f2462bfe55
Char: cyclades, fix tty device unregister
...
put_tty_driver after unregistering devices
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:25 -07:00
Jiri Slaby
f742903424
Char: cyclades, conditions cleanup
...
- 0 is not NULL
- use unlikely to hit the icache in isr more likely
- remove or comment empty if/else paths
[akpm@linux-foundation.org: build fix]
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-05-08 11:15:25 -07:00
Jiri Slaby
9fa1b3b185
Char: cyclades, remove locking macros
...
and use locally stored card structure if possible
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:25 -07:00
Jiri Slaby
6a0aa67b17
Char: cyclades, remove unused timestamps
...
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:25 -07:00
Jiri Slaby
3991428d9e
Char: cyclades, timers cleanup
...
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:25 -07:00
Jiri Slaby
ce71b0ffd0
Char: cyclades, fix blockmove
...
tty has no longer flip buffers accessible externally. Fix it by moving the
code to the tty_*flip* helpers.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:25 -07:00
Jiri Slaby
2c7fea9921
Char: cyclades, remove sleep_on
...
convert to wait_* and completion
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:25 -07:00
Jiri Slaby
875b206b5f
Char: cyclades, make info->card a pointer
...
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:25 -07:00
Jiri Slaby
6d8248e850
Char: cyclades, get rid of phys addresses
...
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:25 -07:00
Jiri Slaby
3046d50ea5
Char: cyclades, simplify variables initialization
...
- do not init static variables to 0
- simplify cy_init_card -- use memset(0) and do not zero each element
separately, also reorder init, so that same entries are inited at one
place
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:25 -07:00
Jiri Slaby
31b4f0a118
Char: cyclades, mark cyy_init_card as __devinit, not __init
...
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:24 -07:00
Jiri Slaby
217191910c
Char: cyclades, printk cleanups
...
- add printk KERN_ levels to each printk
- substitute printk with dev_* when device struct is available
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:24 -07:00
Jiri Slaby
80fada50ec
Char: cyclades, irq is int
...
don't fetch it to uchar
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:24 -07:00
Jiri Slaby
46039f8a64
Char: cyclades, remove useless fileds from cyclades_card
...
pde, ctl_phys and base_phys are useless -- they are never used.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:24 -07:00
Jiri Slaby
b81cc310f1
Char: cyclades, unexport struct cyclades_card
...
Do not export internal card data to userspace. cytune doesn't use this
anyway.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:24 -07:00
Jiri Slaby
6747cd93f3
Char: cyclades, switch to pci probing
...
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:24 -07:00
Jiri Slaby
c2ad4c7515
Char: cyclades, use IS_CYC_Z macro
...
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:24 -07:00
Jiri Slaby
f1e83c6c1e
Char: cyclades, allow DEBUG_SHIRQ
...
Test if base addr is non-null in ISR to prove the card has been correctly
initialized. This is needed for DEBUG_SHIRQ for example.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:24 -07:00
Jiri Slaby
85c93fa95b
Char: cyclades, clear interrupts before releasing
...
Without this patch, the driver sometimes causes "IRQXX: Nobody cares". Fix it
by turning off irqs when releasing.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:24 -07:00
Jiri Slaby
6ad1ccc196
Char: cyclades, tty_register_device separately for each device
...
Do not register all tty devices at the init time, delay it for the time until
some device is found.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:24 -07:00
Jiri Slaby
9dacf3b2f0
Char: cyclades, cy_init error handling
...
- do not panic if tty_register_driver fails
- handle fail paths properly
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:23 -07:00
Jiri Slaby
14a55a6789
Char: cyclades, remove some global vars
...
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:23 -07:00
Jiri Slaby
f3851e73ec
Char: cyclades, init card struct immediately
...
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:23 -07:00
Jiri Slaby
0809e2671d
Char: cyclades, move card entries init into function
...
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:23 -07:00
Jiri Slaby
58936d8d94
Char: cyclades, create cy_pci_probe
...
Move probing code to separate function for easy pci probing conversion.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:23 -07:00
Jiri Slaby
2b1da41fb3
Char: cyclades, init Ze immediately
...
There will be no other choice after introducing pci probing anyway.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:23 -07:00
Jiri Slaby
38d0909325
Char: cyclades, use pci_iomap/unmap
...
fork remove code for pci -- move it to separate, new, function and don't care
about pci in the former.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:23 -07:00
Jiri Slaby
d407c78188
Char: cyclades, create cy_init_Ze
...
Move Ze init code into new cy_init_Ze, because we will need it in another
place and it will make the code totally unreadable.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:23 -07:00
Jiri Slaby
cab9bdd14d
Char: cyclades, remove useless casts
...
cyclades, remove useless casts
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:23 -07:00
Jiri Slaby
ad39c30049
Char: cyclades, remove volatiles
...
cyclades, remove volatiles
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:22 -07:00
Jiri Slaby
b70509066c
Char: cyclades, timer cleanup
...
cyclades, timer cleanup
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:22 -07:00
Jiri Slaby
db05c3b1dd
Char: cyclades, cy_readX/writeX cleanup
...
cyclades, cy_readX/writeX cleanup
- cy_readX are placeholders for readX, remove it
- move cy_writeX macros into do {} while(0) to be safe
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:22 -07:00
Jiri Slaby
ffa68e79ff
Char: cyclades, remove PAUSE
...
cyclades, remove PAUSE
PAUSE expands to do {} while (0), it's useless.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:22 -07:00
Milind Arun Choudhary
cc0a8fbb7c
drivers/char: use __set_current_state()
...
use __set_current_state(TASK_*) instead of current->state = TASK_*,
Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com >
Cc: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:13 -07:00
Klaus Kudielka
1a86b5e34e
cyclades: remove custom types
...
Switch from private uclong, etc over to standard types.
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-08 11:15:03 -07:00
Klaus Kudielka
7c4e95bf48
fix cyclades.h for x86_64 (and probably others)
...
At least on x86_64 the present cyclades.h is broken due to the wrong size
of uclong. This affects, of course, both the kernel and the user-level
utilities. The symptom is that cyzload refuses to load the firmware. I
also managed to freeze the machine when unloading the module.
The patch below fixes this in an architecture-independent way. I have
tested it with 2.6.19 and the driver works fine again with a Cyclades-Z on
an Athlon 64 X2.
[akpm@linux-foundation.org: fix warnings]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-05-08 11:15:03 -07:00
Andrew Morton
d5dedf99e4
[PATCH] cyclades: return closing_wait
...
In http://bugzilla.kernel.org/show_bug.cgi?id=8065 , Shen points out that the
cyclades driver forget to return closing_wait to userspace.
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk >
Cc: Russell King <rmk@arm.linux.org.uk >
Cc: Shen <shanlu@cs.uiuc.edu >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-03-05 07:57:50 -08:00
Jiri Slaby
893de2dffb
[PATCH] Char: cyclades, use pci_device_id
...
Use pci_device_id struct instead of ushort array. Add MODULE_DEVICE_TABLE.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-02-12 09:48:28 -08:00
Jiri Slaby
b963a8441c
[PATCH] Char: tty_wakeup cleanup
...
tty_wakeup cleanup
- remove wake_up_interruptible(&tty->write_wait) surrounding
tty_wakup(tty);
- substitute tty->ldisc.write_wakeup(tty) + wake_up() by tty_wakeup(tty);
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk >
Acked-by: Tilman Schmidt <tilman@imap.cc >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-02-11 10:51:26 -08:00
Jiri Slaby
90cc301859
[PATCH] Char: cyclades, fix warnings
...
fix gcc signed/unsigned warnings
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk >
Signed-off-by: Andrew Morton <akpm@osdl.org >
Signed-off-by: Linus Torvalds <torvalds@osdl.org >
2006-12-08 08:29:01 -08:00
Jiri Slaby
096dcfce39
[PATCH] Char: cyclades, cleanup
...
- remove cvs rcsid and alter code that uses it.
- allow a semicolon after use of macro to not confuse parsers (e.g. indent)
by do {} while (0)
- JIFFIES_DIFF is simple subtraction, subtract directly
- returns cleanup -- do not put values in parenthesis and do not return nothing
at the end of void functions
- comments are /* */ in C (not //)
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk >
Signed-off-by: Andrew Morton <akpm@osdl.org >
Signed-off-by: Linus Torvalds <torvalds@osdl.org >
2006-12-08 08:29:01 -08:00
Jiri Slaby
02f1175c87
[PATCH] Char: cyclades, Lindent the code
...
make the code indented by tabs.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com >
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk >
Signed-off-by: Andrew Morton <akpm@osdl.org >
Signed-off-by: Linus Torvalds <torvalds@osdl.org >
2006-12-08 08:29:00 -08:00