Andy Shevchenko
f530f88246
iio: accel: bma220: Remove unneeded blank lines
...
There are few blank lines that split structure definitions
with their users. Remove them to increase readability.
While here, update copyright year.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20200831090813.78841-8-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
2020-09-03 19:41:00 +01:00
Andy Shevchenko
2b09b41dba
iio: accel: bma220: Use BIT() and GENMASK() macros
...
Code is better to read when numbers of bit are explicitly used.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20200831090813.78841-7-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
2020-09-03 19:41:00 +01:00
Andy Shevchenko
df9f7d4c33
iio: accel: bma220: Group IIO headers together
...
Group IIO headers together and follow the common pattern of header inclusion,
i.e. more generic first.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20200831090813.78841-6-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
2020-09-03 19:41:00 +01:00
Andy Shevchenko
846afc1dbc
iio: accel: bma220: Drop ACPI_PTR() and accompanying ifdeffery
...
The driver is quite likely used only on ACPI based platforms and
rarely build with CONFIG_ACPI=n. Even though, the few dozens of bytes
is better than ugly ifdeffery and inclusion of heavy header.
As a result, replace acpi.h with mod_devicetable.h.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20200831090813.78841-5-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
2020-09-03 19:40:59 +01:00
Andy Shevchenko
4d9a167a34
iio: accel: bma220: Mark PM functions as __maybe_unused
...
Instead of using ugly ifdeffery, mark PM functions as __maybe_unused.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20200831090813.78841-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
2020-09-03 19:40:59 +01:00
Andy Shevchenko
700e63dada
iio: accel: bma220: Use dev_get_drvdata() directly
...
Instead of using to_spi_dev() + spi_get_drvdata(),
use dev_get_drvdata() to make code simpler.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20200831090813.78841-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
2020-09-03 19:40:59 +01:00
Andy Shevchenko
938d1b3873
iio: accel: bma220: Convert to use ->read_avail()
...
Convert to use ->read_avail() instead of open-coded attribute handling.
While here, fix the typo in array definition and append comma in case of
the future extension.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20200831090813.78841-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
2020-09-03 19:40:59 +01:00
Andy Shevchenko
5265b267e3
iio: accel: bma220: Fix returned codes from bma220_init(), bma220_deinit()
...
Potentially bma220_init() and bma220_deinit() may return positive codes.
Fix the logic to return proper error codes instead.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20200831090813.78841-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
2020-09-03 19:40:58 +01:00
Lee Jones
2d815b8415
iio: accel: bma220_spi: Do not define 'struct acpi_device_id' when !CONFIG_ACPI
...
Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI,
struct 'bma220_acpi_id' becomes defined but unused.
Fixes the following W=1 kernel build warning(s):
drivers/iio/accel/bma220_spi.c:312:36: warning: ‘bma220_acpi_id’ defined but not used [-Wunused-const-variable=]
312 | static const struct acpi_device_id bma220_acpi_id[] = {
| ^~~~~~~~~~~~~~
Cc: Tiberiu Breana <tiberiu.a.breana@intel.com >
Signed-off-by: Lee Jones <lee.jones@linaro.org >
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
2020-07-20 09:02:47 +01:00
Alexandru Ardelean
d3be83244c
iio: remove explicit IIO device parent assignment
...
This patch applies the semantic patch:
@@
expression I, P, SP;
@@
I = devm_iio_device_alloc(P, SP);
...
- I->dev.parent = P;
It updates 302 files and does 307 deletions.
This semantic patch also removes some comments like
'/* Establish that the iio_dev is a child of the i2c device */'
But this is is only done in case where the block is left empty.
The patch does not seem to cover all cases. It looks like in some cases a
different variable is used in some cases to assign the parent, but it
points to the same reference.
In other cases, the block covered by ... may be just too big to be covered
by the semantic patch.
However, this looks pretty good as well, as it does cover a big bulk of the
drivers that should remove the parent assignment.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com >
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
2020-06-14 11:49:59 +01:00
Thomas Gleixner
36edc93958
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 330
...
Based on 1 normalized pattern(s):
this file is subject to the terms and conditions of version 2 of the
gnu general public license see the file copying in the main
directory of this archive for more details
extracted by the scancode license scanner the SPDX license identifier
GPL-2.0-only
has been chosen to replace the boilerplate/reference in 55 file(s).
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Reviewed-by: Allison Randal <allison@lohutok.net >
Reviewed-by: Alexios Zavras <alexios.zavras@intel.com >
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org >
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190530000436.108941081@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-06-05 17:37:06 +02:00
Jonathan Cameron
6c5bffa80e
iio:accel: drop assign iio_info.driver_module and iio_trigger_ops.owner
...
The equivalent of both of these are now done via macro magic when
the relevant register calls are made. The actual structure
elements will shortly go away.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com >
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de >
2017-08-22 21:22:40 +01:00
Alison Schofield
b234f683dd
iio: accel: bma220_spi: set up buffer timestamps for non-zero values
...
Use the iio_pollfunc_store_time parameter during triggered buffer
set-up to get valid timestamps.
Signed-off-by: Alison Schofield <amsfield22@gmail.com >
Cc: Daniel Baluta <daniel.baluta@gmail.com >
Reviewed-By: Tiberiu Breana <tiberiu.a.breana@intel.com >
Cc: <Stable@vger.kernel.org >
Signed-off-by: Jonathan Cameron <jic23@kernel.org >
2016-08-15 15:39:18 +01:00
Tiberiu Breana
194dc4c714
iio: accel: Add triggered buffer support for BMA220
...
Signed-off-by: Tiberiu Breana <tiberiu.a.breana@intel.com >
Signed-off-by: Jonathan Cameron <jic23@kernel.org >
2016-05-21 20:06:50 +01:00
Tiberiu Breana
bf2a5600a3
iio: accel: Add support for Bosch BMA220
...
This commit adds basic support for the Bosch Sensortec BMA220
digital triaxial acceleration sensor.
The device datasheet can be found here:
http://www.mouser.com/pdfdocs/BSTBMA220DS00308.PDF
Includes:
- raw readings
- ACPI detection
- power management
Signed-off-by: Tiberiu Breana <tiberiu.a.breana@intel.com >
Signed-off-by: Jonathan Cameron <jic23@kernel.org >
2016-05-14 18:43:45 +01:00