Liu Shixin
07def58717
EDAC/aspeed: Use module_platform_driver() to simplify
...
Use module_platform_driver() which makes the code simpler by eliminating
boilerplate code.
Signed-off-by: Liu Shixin <liushixin2@huawei.com >
Signed-off-by: Borislav Petkov <bp@suse.de >
Reviewed-by: Joel Stanley <joel@jms.id.au >
Link: https://lkml.kernel.org/r/20200914065358.3726216-1-liushixin2@huawei.com
2020-09-18 09:14:01 +02:00
Krzysztof Kozlowski
afce699694
EDAC/aspeed: Fix handling of platform_get_irq() error
...
platform_get_irq() returns a negative error number on error. In such a
case, comparison to 0 would pass the check therefore check the return
value properly, whether it is negative.
[ bp: Massage commit message. ]
Fixes: 9b7e6242ee
("EDAC, aspeed: Add an Aspeed AST2500 EDAC driver")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Signed-off-by: Borislav Petkov <bp@suse.de >
Reviewed-by: Stefan Schaeckeler <schaecsn@gmx.net >
Link: https://lkml.kernel.org/r/20200827070743.26628-1-krzk@kernel.org
2020-09-01 20:41:27 +02:00
Xu Wang
a651c6c644
EDAC/aspeed: Remove unneeded semicolon
...
Remove unneeded semicolon reported by coccinelle.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn >
Signed-off-by: Borislav Petkov <bp@suse.de >
Acked-by: Andrew Jeffery <andrew@aj.id.au >
Cc: James Morse <james.morse@arm.com >
Cc: Joel Stanley <joel@jms.id.au >
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-aspeed@lists.ozlabs.org
Cc: linux-edac <linux-edac@vger.kernel.org >
Cc: Mauro Carvalho Chehab <mchehab@kernel.org >
Cc: Robert Richter <rrichter@marvell.com >
Cc: Stefan Schaeckeler <sschaeck@cisco.com >
Cc: Tony Luck <tony.luck@intel.com >
Link: https://lkml.kernel.org/r/1576648806-1114-1-git-send-email-vulab@iscas.ac.cn
2019-12-19 07:27:09 +01:00
Markus Elfring
5bbab3cf21
EDAC/aspeed: Use devm_platform_ioremap_resource() in aspeed_probe()
...
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net >
Signed-off-by: Borislav Petkov <bp@suse.de >
Acked-by: Joel Stanley <joel@jms.id.au >
Cc: Andrew Jeffery <andrew@aj.id.au >
Cc: James Morse <james.morse@arm.com >
Cc: kernel-janitors@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-aspeed@lists.ozlabs.org
Cc: linux-edac <linux-edac@vger.kernel.org >
Cc: Mauro Carvalho Chehab <mchehab@kernel.org >
Cc: Robert Richter <rrichter@marvell.com >
Cc: Stefan Schaeckeler <sschaeck@cisco.com >
Cc: Tony Luck <tony.luck@intel.com >
Link: https://lkml.kernel.org/r/baabb9e9-a1b2-3a04-9fb6-aa632de5f722@web.de
2019-10-24 11:17:29 +02:00
YueHaibing
ff70cacc96
EDAC/aspeed: Remove set but not used variable 'np'
...
Fix the following -Wunused-but-set-variable warning:
drivers/edac/aspeed_edac.c: In function aspeed_probe:
drivers/edac/aspeed_edac.c:284:22: warning: variable np set but not used [-Wunused-but-set-variable]
It is never used and can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com >
Signed-off-by: Borislav Petkov <bp@suse.de >
Reviewed-by: Andrew Jeffery <andrew@aj.id.au >
Reviewed-by: Stefan Schaeckeler <sschaeck@cisco.com >
Cc: James Morse <james.morse@arm.com >
Cc: Joel Stanley <joel@jms.id.au >
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-aspeed@lists.ozlabs.org
Cc: linux-edac <linux-edac@vger.kernel.org >
Cc: Mauro Carvalho Chehab <mchehab@kernel.org >
Link: https://lkml.kernel.org/r/20190525144153.2028-1-yuehaibing@huawei.com
2019-06-20 11:44:36 -07:00
Stefan M Schaeckeler
9b7e6242ee
EDAC, aspeed: Add an Aspeed AST2500 EDAC driver
...
Add support for the Aspeed AST2500 SoC.
Signed-off-by: Stefan M Schaeckeler <sschaeck@cisco.com >
Signed-off-by: Borislav Petkov <bp@suse.de >
Cc: Andrew Jeffery <andrew@aj.id.au >
Cc: Joel Stanley <joel@jms.id.au >
Cc: Mark Rutland <mark.rutland@arm.com >
Cc: Mauro Carvalho Chehab <mchehab@kernel.org >
Cc: Rob Herring <robh+dt@kernel.org >
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-aspeed@lists.ozlabs.org
Cc: linux-edac <linux-edac@vger.kernel.org >
Link: https://lkml.kernel.org/r/1547743097-5236-2-git-send-email-schaecsn@gmx.net
2019-01-18 15:23:11 +01:00