Wang Hui
225c87b40a
stm class: Fix module init return on allocation failure
...
commit 927633a6d20af319d986f3e42c3ef9f6d7835008 upstream.
In stm_heartbeat_init(): return value gets reset after the first
iteration by stm_source_register_device(), so allocation failures
after that will, after a clean up, return success. Fix that.
Fixes: 1192918530
("stm class: Add heartbeat stm source device")
Reported-by: Hulk Robot <hulkci@huawei.com >
Signed-off-by: Wang Hui <john.wanghui@huawei.com >
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com >
Link: https://lore.kernel.org/r/20210115195917.3184-2-alexander.shishkin@linux.intel.com
Cc: stable <stable@vger.kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-01-27 11:55:15 +01:00
Alexander Shishkin
6c7e4b6882
stm class: heartbeat: Fix whitespace
...
Fix whitespace in the code for better readability, no functional changes.
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com >
Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-10-11 12:12:55 +02:00
Alexander Shishkin
9ea393d8d8
stm class: Add SPDX GPL-2.0 header to replace GPLv2 boilerplate
...
This adds SPDX GPL-2.0 header to to stm core files and removes the
GPLv2 boilerplate text.
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com >
2018-03-28 18:47:17 +03:00
Alexander Shishkin
c8be489944
stm class: stm_heartbeat: Make nr_devs parameter read-only
...
Changing nr_devs after the module has been loaded doesn't actually
change anything, so just make it read-only.
Reported-by: Alan Cox <alan.cox@intel.com >
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com >
Reviewed-by: Laurent Fert <laurent.fert@intel.com >
2016-04-08 16:11:51 +03:00
Alexander Shishkin
1192918530
stm class: Add heartbeat stm source device
...
Heartbeat stm source may have multiple instances (for connecting to
different stm devices). Each instance will send a periodic test message
over its stm device when it is linked. This can be used for testing stm
class framework, stm device drivers or as a heartbeat over the stm link.
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2016-02-20 14:09:14 -08:00