Stanislaw Gruszka
6668e4eb50
iwlegacy: s/il_txq_mem/il_free_txq_mem/g
...
Previous name was confusing.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:17 -05:00
Stanislaw Gruszka
bc269a8e27
iwlegacy: s/S_RF_KILL_HW/S_RFKILL/g
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:17 -05:00
Stanislaw Gruszka
d87c771f47
iwlegacy: small queue initializations cleanup
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:17 -05:00
Stanislaw Gruszka
586e45e31e
iwlegacy: check correct il_poll_bit error value
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:16 -05:00
Stanislaw Gruszka
775ed8abde
iwlegacy: do not grab nic access if rfkill
...
If rfkill is on il_grab_nic_access() fail and we can not write to the
various registers during stop procedure. Write to those registers
unconditionally instead.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:16 -05:00
Stanislaw Gruszka
9ce7b73c76
iwlegacy: improve mac operation debuggability a bit
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:15 -05:00
Stanislaw Gruszka
288f995413
iwlegacy: get rid of tx/rx traffic log
...
The same data can be gathered using monitor mode.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:15 -05:00
Stanislaw Gruszka
c936355172
iwlegacy: merge all ops structures into one
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:15 -05:00
Stanislaw Gruszka
1600b87542
iwlegacy: merge il_lib_ops into il_ops
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:15 -05:00
Stanislaw Gruszka
f03ee2a87e
iwlegacy: remove il_apm_ops
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:14 -05:00
Stanislaw Gruszka
a89268e8cd
iwlegacy: merge eeprom_ops into lib_ops
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:13 -05:00
Stanislaw Gruszka
93a984a4ee
iwlegacy: regulatory_bands is not an ops
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:12 -05:00
Stanislaw Gruszka
4e5ea2088b
iwlegacy: cleanup/fix memory barriers
...
wmb(), rmb() are not needed when writel(), readl() are used as
accessors for MMIO. We use them indirectly via iowrite32(),
ioread32().
What is needed mmiowb(), for synchronizing writes coming from
different CPUs on PCIe bridge (see in patch comments). This
fortunately is not needed on x86, where mmiowb() is just
defined as compiler barrier. As iwlegacy devices are most likely
not used on anything other than x86, this is not so important
fix.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:12 -05:00
Stanislaw Gruszka
1e0f32a43a
iwlegacy: always check if got h/w access before write
...
Before we write to the device register always check if
_il_grap_nic_access() was successful.
Change type return type _il_grap_nic_access() to bool, and
add likely()/unlikely() statements.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:12 -05:00
Stanislaw Gruszka
b6603036ad
iwlegacy: dump stack when fail to gain access to the device
...
Print dump stack when the device is not responding. This should give
some more clue about the reason of failure. Also change the message we
print, since "MAC in deep sleep" is kinda confusing.
On the way add unlikely(), as fail to gain NIC access is hmm ...
unlikely.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-22 14:51:11 -05:00
Stanislaw Gruszka
00ea99e1d8
iwlegacy: remove struct il_tx_info
...
It's just wrapper to sk_buff pointers ...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:13 -05:00
Stanislaw Gruszka
89ef1ed2d2
iwlegacy: merge il_base_params into il_cfg
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:12 -05:00
Stanislaw Gruszka
c39ae9fd50
iwlegacy: move ops out of config
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:11 -05:00
Stanislaw Gruszka
8300719603
iwlegacy: get rid of ctx structure
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:11 -05:00
Stanislaw Gruszka
20c47eba70
iwlegacy: remove il_setup_interface()
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:10 -05:00
Stanislaw Gruszka
dee9a09eb3
iwlegacy: get rid of ctx->is_active
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:09 -05:00
Stanislaw Gruszka
1c03c4620e
iwlegacy: move ht out of ctx structure
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:07 -05:00
Stanislaw Gruszka
8d44f2bd75
iwlegacy: move qos_data out of ctx structure
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:06 -05:00
Stanislaw Gruszka
8c9c48d5a9
iwlegacy: remove ctx interface_modes
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:05 -05:00
Stanislaw Gruszka
fd6415bcfb
iwlegacy: get rid of ctx->station_flags
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:04 -05:00
Stanislaw Gruszka
6aa0c25435
iwlegacy: get rid of ctxid
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:02 -05:00
Stanislaw Gruszka
0f8b90f526
iwlegacy: get rid of *_devtype
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:01 -05:00
Stanislaw Gruszka
b16db50a6d
iwlegacy: move bcast_sta_id to hw_params
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:56:00 -05:00
Stanislaw Gruszka
8f9e564553
iwlegacy: get rid of ap_sta_id
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:55:59 -05:00
Stanislaw Gruszka
b96ed60cd0
iwlegacy: get rid of qos_cmd
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:55:58 -05:00
Stanislaw Gruszka
63d0f0c551
iwlegacy: get rid of ctx->rxon_timing_cmd
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:55:56 -05:00
Stanislaw Gruszka
c8b03958d4
iwlegacy: move rxon commands out of ctx structure
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-02-06 14:55:55 -05:00
Stanislaw Gruszka
17d4eca643
iwlegacy: move some i/o helpers out of inline
...
This save us about 20k of text size, and should have no impact on
performance as hot paths do not use much I/O.
Before:
text data bss dec hex filename
108512 1784 168 110464 1af80 drivers/net/wireless/iwlegacy/iwl3945.ko
165730 2164 156 168050 29072 drivers/net/wireless/iwlegacy/iwl4965.ko
91942 328 48 92318 1689e drivers/net/wireless/iwlegacy/iwlegacy.ko
After:
text data bss dec hex filename
95556 1784 168 97508 17ce4 drivers/net/wireless/iwlegacy/iwl3945.ko
154853 2164 156 157173 265f5 drivers/net/wireless/iwlegacy/iwl4965.ko
91634 328 48 92010 1676a drivers/net/wireless/iwlegacy/iwlegacy.ko
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2012-01-04 14:30:44 -05:00
Thomas Meyer
2b50b8f588
iwlegacy: Use kcalloc instead of kzalloc to allocate array
...
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.
The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de >
Signed-off-by: John W. Linville <linville@tuxdriver.com >
2011-12-06 16:05:24 -05:00
Stanislaw Gruszka
1722f8e12a
iwlegacy: checkpatch.pl fixes
...
Fix most checkpatch.pl ERRORs and some WARNINGs.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
2011-11-15 14:51:01 +01:00
Stanislaw Gruszka
e7392364fc
iwlegacy: indentions and whitespaces
...
Process iwlegacy source files using:
indent -npro -l500 -nhnl
indent -npro -kr -i8 -ts8 -sob -l80 -nbbo -ss -ncs -cp1 -il0 -psl
Plus manual compilation fixes.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
2011-11-15 14:45:59 +01:00
Stanislaw Gruszka
f02579e3a8
iwlegacy: merge iwl-debug.h into common.h
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
2011-11-15 14:25:21 +01:00
Stanislaw Gruszka
47ef694dd4
iwlegacy: merge iwl-{eeprom,led}.h into common.h
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
2011-11-15 14:20:23 +01:00
Stanislaw Gruszka
99412002a0
iwlegacy: merge iwl-power.h into common.h
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
2011-11-15 14:20:19 +01:00
Stanislaw Gruszka
e94a4099ad
iwlegacy: merge common header files
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
2011-11-15 14:20:09 +01:00
Stanislaw Gruszka
98613be06e
iwlegacy: rename iwl-core.h to common.h
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
2011-11-15 14:19:34 +01:00
Stanislaw Gruszka
6278ddab9f
iwlegacy: remove il_ieee80211_get_hw_conf
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
2011-11-15 14:12:00 +01:00
Stanislaw Gruszka
0cdc21363c
iwlegacy: merge common .c files
...
Merge iwl-{tx,rx,sta,scan,power,eeprom,led,hcmd}.c into common.c .
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
2011-11-15 13:40:15 +01:00
Stanislaw Gruszka
4ed47911a2
iwlegacy: rename iwl-core.c to common.c
...
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com >
2011-11-15 13:18:51 +01:00