Hirofumi Nakagawa
801678c5a3
Remove duplicated unlikely() in IS_ERR()
...
Some drivers have duplicated unlikely() macros. IS_ERR() already has
unlikely() in itself.
This patch cleans up such pointless code.
Signed-off-by: Hirofumi Nakagawa <hnakagawa@miraclelinux.com >
Acked-by: David S. Miller <davem@davemloft.net >
Acked-by: Jeff Garzik <jeff@garzik.org >
Cc: Paul Clements <paul.clements@steeleye.com >
Cc: Richard Purdie <rpurdie@rpsys.net >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: David Brownell <david-b@pacbell.net >
Cc: James Bottomley <James.Bottomley@HansenPartnership.com >
Cc: Michael Halcrow <mhalcrow@us.ibm.com >
Cc: Anton Altaparmakov <aia21@cantab.net >
Cc: Al Viro <viro@zeniv.linux.org.uk >
Cc: Carsten Otte <cotte@de.ibm.com >
Cc: Patrick McHardy <kaber@trash.net >
Cc: Paul Mundt <lethal@linux-sh.org >
Cc: Jaroslav Kysela <perex@perex.cz >
Cc: Takashi Iwai <tiwai@suse.de >
Acked-by: Mike Frysinger <vapier@gentoo.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-04-29 08:06:25 -07:00
Kay Sievers
ad28a07bca
rtc: fix platform driver hotplug/coldplug
...
Since 43cc71eed1
, the platform modalias is
prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable RTC
platform drivers, to re-enable module auto loading.
[dbrownell@users.sourceforge.net: more drivers, minor fix]
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Cc: Greg KH <greg@kroah.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-11 08:06:44 -07:00
Mike Frysinger
095b9d546f
Blackfin RTC driver: convert sync wait to use the irq write complete notice
...
- thus clearing out the need for spin locks
- add a small optimization for reading of the rtc field
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:14 -08:00
Mike Frysinger
48c1a56b4b
Blackfin RTC driver: shave off another memcpy() by using assignment.
...
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:14 -08:00
Mike Frysinger
68db30472d
Blackfin RTC driver: read_alarm() checks the enabled field, not the pending field.
...
also, dont bother using memcpy since we can just do an assignment of the same structure.
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:14 -08:00
Mike Frysinger
5438de4422
Blackfin RTC driver: use dev_dbg() rather than pr_stamp()
...
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:14 -08:00
Mike Frysinger
640611608f
Blackfin RTC driver: cleanup proc handler (we dont need RTC reg dump now that we have MMR filesystem in sysfs)
...
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:14 -08:00
Mike Frysinger
d7827d889a
Blackfin RTC driver: we pass in a (struct device*) to the irq handler, not a (struct platform_device*), so fix the irq handler
...
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:13 -08:00
Mike Frysinger
5c236343eb
Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
...
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Acked-by: Alessandro Zummo <alessandro.zummo@towertech.it >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:13 -08:00
Mike Frysinger
2c95cd71f8
Blackfin On-Chip RTC driver update for supporting BF54x
...
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
2007-07-15 02:33:26 +08:00
Wu, Bryan
8cc75c9a14
Blackfin: on-chip RTC controller driver
...
This patch implements the driver necessary use the Analog Devices Blackfin
processor's on-chip RTC controller.
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-07 12:12:58 -07:00