Sangjung Woo
1748cbf7f7
drivers/rtc/rtc-max77686.c: Fix wrong register
...
Fix a read of the wrong register when checking whether the RTC timer has
reached the alarm time.
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com >
Signed-off-by: Myugnjoo Ham <myungjoo.ham@samsung.com >
Reviewed-by: Jonghwa Lee <jonghwa3.lee@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-09-11 15:58:56 -07:00
Sachin Kamat
eda328fbe3
drivers/rtc/rtc-max77686.c: remove empty function
...
After the switch to devm_* functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Cc: Chiwoong Byun <woong.byun@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-07-03 16:07:57 -07:00
Sachin Kamat
cdf5f4ac63
drivers/rtc/rtc-max77686.c: remove space before semicolon
...
Fixes the following warning:
WARNING: space prohibited before semicolon
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Cc: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-07-03 16:07:47 -07:00
Sachin Kamat
7f391f54cd
drivers/rtc/rtc-max77686.c: use devm_regmap_init_i2c()
...
This driver already uses other devm_* APIs.
Convert regmap_init_i2c too.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Cc: Chiwoong Byun <woong.byun@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:35 -07:00
Sachin Kamat
ad819039f1
drivers/rtc/rtc-max77686.c: fix incorrect return value on error
...
'ret' was not initialized to error code before returning. While
at it also remove some redundant code and cleanup.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org >
Cc: Chiwoong Byun <woong.byun@samsung.com >
Cc: Jonghwa Lee <jonghwa3.lee@samsung.com >
Cc: Laxman dewangan <ldewangan@nvidia.com >
Cc: Venu Byravarasu <vbyravarasu@nvidia.com >
Cc: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:34 -07:00
Jingoo Han
f56950ec3a
rtc: rtc-max77686: use devm_rtc_device_register()
...
devm_rtc_device_register() is device managed and makes cleanup
paths simpler. Also, this patch uses devm_request_threaded_irq().
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:26 -07:00
Jingoo Han
e2bf1151ed
drivers/rtc/rtc-max77686.c: use dev_info()/dev_emerg() instead of pr_info()/pr_emerg()
...
dev_info()/dev_emerg() are preferred to pr_info()/pr_emerg().
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:22 -07:00
Jingoo Han
ac60bf3121
drivers/rtc/rtc-max77686.c: fix indentation of bit definitions
...
Fix indentation of bit definitions to enhance the readability.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:22 -07:00
Jingoo Han
0f64f853fc
drivers/rtc/rtc-max77686.c: use devm_kzalloc()
...
Use devm_kzalloc() to make cleanup paths more simple.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:21 -07:00
Jingoo Han
f5b1d3c5d0
drivers/rtc/rtc-max77686.c: add missing module author name
...
Add missing module author name to MODULE_AUTHOR macro.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:21 -07:00
Jingoo Han
0c58ff5877
drivers/rtc/rtc-max77686.c: use module_platform_driver()
...
Use module_platform_driver() macro which makes the code smaller and
simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-29 18:28:21 -07:00
Jingoo Han
3cebeb53d9
rtc: max77686: use dev_info() instead of printk()
...
Fix the checkpatch warning as below:
WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-02-21 17:22:29 -08:00
Jonghwa Lee
fca1dd031a
rtc: max77686: add Maxim 77686 driver
...
Add a driver to support max77686 rtc. MAX77686 rtc support smpl and wtsr
mode. It has two alarm register which can be used for alarming to wake
system up. This drvier uses regmap to access its register.
[akpm@linux-foundation.org: remove inline, __devinit annotations]
[jg1.han@samsung.com: fix build warnings]
[akpm@linux-foundation.org: simplify code]
Signed-off-by: Chiwoong Byun <woong.byun@samsung.com>
Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
Signed-off-by: Myugnjoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-21 17:22:27 -08:00