xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: typec: Add the missed altmode_id_remove() in typec_register_altmode()

Browse Source 
commit 03026197bb657d784220b040c6173267a0375741 upstream.

typec_register_altmode() misses to call altmode_id_remove() in an error
path. Add the missed function call to fix it.

Fixes: 8a37d87d72 ("usb: typec: Bus type for alternate modes")
Cc: stable <stable@vger.kernel.org>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Link: https://lore.kernel.org/r/20210617073226.47599-1-jingxiangfeng@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jing Xiangfeng
2021-06-17 15:32:26 +08:00
committed by Greg Kroah-Hartman
parent 63d6029e66
commit ff0f59d2d8
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/typec/class.c
View File

@@ -446,8 +446,10 @@ typec_register_altmode(struct device *parent,
int ret; int ret;
alt = kzalloc(sizeof(*alt), GFP_KERNEL); alt = kzalloc(sizeof(*alt), GFP_KERNEL);
if (!alt) if (!alt) {
altmode_id_remove(parent, id);
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
}
alt->adev.svid = desc->svid; alt->adev.svid = desc->svid;
alt->adev.mode = desc->mode; alt->adev.mode = desc->mode;