Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6: (53 commits) DVB: firedtv: FireDTV S2 problems with tuning solved DVB: firedtv: fix printk format mismatch ieee1394: constify device ID tables ieee1394: raw1394: add sparse annotations to raw1394_compat_write ieee1394: Storage class should be before const qualifier ieee1394: sbp2: follow up on "ieee1394: inherit ud vendor_id from node vendor_id" firewire: core: optimize propagation of BROADCAST_CHANNEL firewire: core: simplify broadcast channel allocation firewire: core: increase bus manager grace period firewire: core: drop unused call parameters of close_transaction firewire: cdev: add closure to async stream ioctl firewire: cdev: simplify FW_CDEV_IOC_SEND_REQUEST return value firewire: cdev: fix race of ioctl_send_request with bus reset firewire: cdev: secure add_descriptor ioctl firewire: cdev: amendment to "add ioctl to query maximum transmission speed" firewire: broadcast channel support firewire: implement asynchronous stream transmission firewire: core: normalize a function argument name firewire: normalize a variable name firewire: core: remove condition which is always false ...
This commit is contained in:
@@ -68,22 +68,22 @@ static struct hpsb_highlevel csr_highlevel = {
|
||||
.host_reset = host_reset,
|
||||
};
|
||||
|
||||
const static struct hpsb_address_ops map_ops = {
|
||||
static const struct hpsb_address_ops map_ops = {
|
||||
.read = read_maps,
|
||||
};
|
||||
|
||||
const static struct hpsb_address_ops fcp_ops = {
|
||||
static const struct hpsb_address_ops fcp_ops = {
|
||||
.write = write_fcp,
|
||||
};
|
||||
|
||||
const static struct hpsb_address_ops reg_ops = {
|
||||
static const struct hpsb_address_ops reg_ops = {
|
||||
.read = read_regs,
|
||||
.write = write_regs,
|
||||
.lock = lock_regs,
|
||||
.lock64 = lock64_regs,
|
||||
};
|
||||
|
||||
const static struct hpsb_address_ops config_rom_ops = {
|
||||
static const struct hpsb_address_ops config_rom_ops = {
|
||||
.read = read_config_rom,
|
||||
};
|
||||
|
||||
|
@@ -2171,7 +2171,7 @@ static const struct file_operations dv1394_fops=
|
||||
* Export information about protocols/devices supported by this driver.
|
||||
*/
|
||||
#ifdef MODULE
|
||||
static struct ieee1394_device_id dv1394_id_table[] = {
|
||||
static const struct ieee1394_device_id dv1394_id_table[] = {
|
||||
{
|
||||
.match_flags = IEEE1394_MATCH_SPECIFIER_ID | IEEE1394_MATCH_VERSION,
|
||||
.specifier_id = AVC_UNIT_SPEC_ID_ENTRY & 0xffffff,
|
||||
|
@@ -181,7 +181,7 @@ static void ether1394_remove_host(struct hpsb_host *host);
|
||||
static void ether1394_host_reset(struct hpsb_host *host);
|
||||
|
||||
/* Function for incoming 1394 packets */
|
||||
const static struct hpsb_address_ops addr_ops = {
|
||||
static const struct hpsb_address_ops addr_ops = {
|
||||
.write = ether1394_write,
|
||||
};
|
||||
|
||||
@@ -438,7 +438,7 @@ static int eth1394_update(struct unit_directory *ud)
|
||||
return eth1394_new_node(hi, ud);
|
||||
}
|
||||
|
||||
static struct ieee1394_device_id eth1394_id_table[] = {
|
||||
static const struct ieee1394_device_id eth1394_id_table[] = {
|
||||
{
|
||||
.match_flags = (IEEE1394_MATCH_SPECIFIER_ID |
|
||||
IEEE1394_MATCH_VERSION),
|
||||
|
@@ -478,7 +478,7 @@ int hpsb_unregister_addrspace(struct hpsb_highlevel *hl, struct hpsb_host *host,
|
||||
return retval;
|
||||
}
|
||||
|
||||
const static struct hpsb_address_ops dummy_ops;
|
||||
static const struct hpsb_address_ops dummy_ops;
|
||||
|
||||
/* dummy address spaces as lower and upper bounds of the host's a.s. list */
|
||||
static void init_hpsb_highlevel(struct hpsb_host *host)
|
||||
|
@@ -484,7 +484,7 @@ static struct device_attribute *const fw_host_attrs[] = {
|
||||
static ssize_t fw_show_drv_device_ids(struct device_driver *drv, char *buf)
|
||||
{
|
||||
struct hpsb_protocol_driver *driver;
|
||||
struct ieee1394_device_id *id;
|
||||
const struct ieee1394_device_id *id;
|
||||
int length = 0;
|
||||
char *scratch = buf;
|
||||
|
||||
@@ -658,7 +658,7 @@ static int nodemgr_bus_match(struct device * dev, struct device_driver * drv)
|
||||
{
|
||||
struct hpsb_protocol_driver *driver;
|
||||
struct unit_directory *ud;
|
||||
struct ieee1394_device_id *id;
|
||||
const struct ieee1394_device_id *id;
|
||||
|
||||
/* We only match unit directories */
|
||||
if (dev->platform_data != &nodemgr_ud_platform_data)
|
||||
|
@@ -125,7 +125,7 @@ struct hpsb_protocol_driver {
|
||||
* probe function below can implement further protocol
|
||||
* dependent or vendor dependent checking.
|
||||
*/
|
||||
struct ieee1394_device_id *id_table;
|
||||
const struct ieee1394_device_id *id_table;
|
||||
|
||||
/*
|
||||
* The update function is called when the node has just
|
||||
|
@@ -90,7 +90,7 @@ static int arm_lock(struct hpsb_host *host, int nodeid, quadlet_t * store,
|
||||
static int arm_lock64(struct hpsb_host *host, int nodeid, octlet_t * store,
|
||||
u64 addr, octlet_t data, octlet_t arg, int ext_tcode,
|
||||
u16 flags);
|
||||
const static struct hpsb_address_ops arm_ops = {
|
||||
static const struct hpsb_address_ops arm_ops = {
|
||||
.read = arm_read,
|
||||
.write = arm_write,
|
||||
.lock = arm_lock,
|
||||
@@ -369,6 +369,7 @@ static const char __user *raw1394_compat_write(const char __user *buf)
|
||||
{
|
||||
struct compat_raw1394_req __user *cr = (typeof(cr)) buf;
|
||||
struct raw1394_request __user *r;
|
||||
|
||||
r = compat_alloc_user_space(sizeof(struct raw1394_request));
|
||||
|
||||
#define C(x) __copy_in_user(&r->x, &cr->x, sizeof(r->x))
|
||||
@@ -378,7 +379,8 @@ static const char __user *raw1394_compat_write(const char __user *buf)
|
||||
C(tag) ||
|
||||
C(sendb) ||
|
||||
C(recvb))
|
||||
return ERR_PTR(-EFAULT);
|
||||
return (__force const char __user *)ERR_PTR(-EFAULT);
|
||||
|
||||
return (const char __user *)r;
|
||||
}
|
||||
#undef C
|
||||
@@ -389,6 +391,7 @@ static int
|
||||
raw1394_compat_read(const char __user *buf, struct raw1394_request *r)
|
||||
{
|
||||
struct compat_raw1394_req __user *cr = (typeof(cr)) buf;
|
||||
|
||||
if (!access_ok(VERIFY_WRITE, cr, sizeof(struct compat_raw1394_req)) ||
|
||||
P(type) ||
|
||||
P(error) ||
|
||||
@@ -400,6 +403,7 @@ raw1394_compat_read(const char __user *buf, struct raw1394_request *r)
|
||||
P(sendb) ||
|
||||
P(recvb))
|
||||
return -EFAULT;
|
||||
|
||||
return sizeof(struct compat_raw1394_req);
|
||||
}
|
||||
#undef P
|
||||
@@ -2249,8 +2253,8 @@ static ssize_t raw1394_write(struct file *file, const char __user * buffer,
|
||||
sizeof(struct compat_raw1394_req) !=
|
||||
sizeof(struct raw1394_request)) {
|
||||
buffer = raw1394_compat_write(buffer);
|
||||
if (IS_ERR(buffer))
|
||||
return PTR_ERR(buffer);
|
||||
if (IS_ERR((__force void *)buffer))
|
||||
return PTR_ERR((__force void *)buffer);
|
||||
} else
|
||||
#endif
|
||||
if (count != sizeof(struct raw1394_request)) {
|
||||
@@ -2978,7 +2982,7 @@ static int raw1394_release(struct inode *inode, struct file *file)
|
||||
* Export information about protocols/devices supported by this driver.
|
||||
*/
|
||||
#ifdef MODULE
|
||||
static struct ieee1394_device_id raw1394_id_table[] = {
|
||||
static const struct ieee1394_device_id raw1394_id_table[] = {
|
||||
{
|
||||
.match_flags = IEEE1394_MATCH_SPECIFIER_ID | IEEE1394_MATCH_VERSION,
|
||||
.specifier_id = AVC_UNIT_SPEC_ID_ENTRY & 0xffffff,
|
||||
|
@@ -265,7 +265,7 @@ static struct hpsb_highlevel sbp2_highlevel = {
|
||||
.host_reset = sbp2_host_reset,
|
||||
};
|
||||
|
||||
const static struct hpsb_address_ops sbp2_ops = {
|
||||
static const struct hpsb_address_ops sbp2_ops = {
|
||||
.write = sbp2_handle_status_write
|
||||
};
|
||||
|
||||
@@ -275,7 +275,7 @@ static int sbp2_handle_physdma_write(struct hpsb_host *, int, int, quadlet_t *,
|
||||
static int sbp2_handle_physdma_read(struct hpsb_host *, int, quadlet_t *, u64,
|
||||
size_t, u16);
|
||||
|
||||
const static struct hpsb_address_ops sbp2_physdma_ops = {
|
||||
static const struct hpsb_address_ops sbp2_physdma_ops = {
|
||||
.read = sbp2_handle_physdma_read,
|
||||
.write = sbp2_handle_physdma_write,
|
||||
};
|
||||
@@ -285,7 +285,7 @@ const static struct hpsb_address_ops sbp2_physdma_ops = {
|
||||
/*
|
||||
* Interface to driver core and IEEE 1394 core
|
||||
*/
|
||||
static struct ieee1394_device_id sbp2_id_table[] = {
|
||||
static const struct ieee1394_device_id sbp2_id_table[] = {
|
||||
{
|
||||
.match_flags = IEEE1394_MATCH_SPECIFIER_ID | IEEE1394_MATCH_VERSION,
|
||||
.specifier_id = SBP2_UNIT_SPEC_ID_ENTRY & 0xffffff,
|
||||
@@ -1413,8 +1413,7 @@ static void sbp2_parse_unit_directory(struct sbp2_lu *lu,
|
||||
"(firmware_revision 0x%06x, vendor_id 0x%06x,"
|
||||
" model_id 0x%06x)",
|
||||
NODE_BUS_ARGS(ud->ne->host, ud->ne->nodeid),
|
||||
workarounds, firmware_revision,
|
||||
ud->vendor_id ? ud->vendor_id : ud->ne->vendor_id,
|
||||
workarounds, firmware_revision, ud->vendor_id,
|
||||
model);
|
||||
|
||||
/* We would need one SCSI host template for each target to adjust
|
||||
|
@@ -1294,7 +1294,7 @@ static const struct file_operations video1394_fops=
|
||||
* Export information about protocols/devices supported by this driver.
|
||||
*/
|
||||
#ifdef MODULE
|
||||
static struct ieee1394_device_id video1394_id_table[] = {
|
||||
static const struct ieee1394_device_id video1394_id_table[] = {
|
||||
{
|
||||
.match_flags = IEEE1394_MATCH_SPECIFIER_ID | IEEE1394_MATCH_VERSION,
|
||||
.specifier_id = CAMERA_UNIT_SPEC_ID_ENTRY & 0xffffff,
|
||||
|
Reference in New Issue
Block a user