xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PATCH] sysfs: (driver/pci) if show/store is missing return -EIO

Browse Source 
sysfs: fix drivers/pci so if an attribute does not implement
       show or store method read/write will return -EIO
       instead of 0.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Dmitry Torokhov
2005-04-29 01:26:27 -05:00
committed by Greg Kroah-Hartman
parent 4a0c20bf8c
commit fc7e482899
3 changed files with 17 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/pci/pci-driver.c
View File

@@ -335,13 +335,14 @@ pci_driver_attr_show(struct kobject * kobj, struct attribute *attr, char *buf)
{
struct device_driver *driver = kobj_to_pci_driver(kobj);
struct driver_attribute *dattr = attr_to_driver_attribute(attr);
ssize_t ret = 0;
ssize_t ret;
if (get_driver(driver)) {
if (dattr->show)
ret = dattr->show(driver, buf);
put_driver(driver);
}
if (!get_driver(driver))
return -ENODEV;
ret = dattr->show ? dattr->show(driver, buf) : -EIO;
put_driver(driver);
return ret;
}
@@ -351,13 +352,14 @@ pci_driver_attr_store(struct kobject * kobj, struct attribute *attr,
{
struct device_driver *driver = kobj_to_pci_driver(kobj);
struct driver_attribute *dattr = attr_to_driver_attribute(attr);
ssize_t ret = 0;
ssize_t ret;
if (get_driver(driver)) {
if (dattr->store)
ret = dattr->store(driver, buf, count);
put_driver(driver);
}
if (!get_driver(driver))
return -ENODEV;
ret = dattr->store ? dattr->store(driver, buf, count) : -EIO;
put_driver(driver);
return ret;
}