cfg80211: add wdev to testmode cmd
To allow drivers to implement per-interface testmode operations more easily, pass a wdev pointer if any identification for one was given from userspace. Clean up the code a bit while at it. Signed-off-by: David Spinadel <david.spinadel@intel.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:

committed by
Johannes Berg

parent
af61a16518
commit
fc73f11f5f
@@ -6591,19 +6591,30 @@ static struct genl_multicast_group nl80211_testmode_mcgrp = {
|
||||
static int nl80211_testmode_do(struct sk_buff *skb, struct genl_info *info)
|
||||
{
|
||||
struct cfg80211_registered_device *rdev = info->user_ptr[0];
|
||||
struct wireless_dev *wdev =
|
||||
__cfg80211_wdev_from_attrs(genl_info_net(info), info->attrs);
|
||||
int err;
|
||||
|
||||
if (!rdev->ops->testmode_cmd)
|
||||
return -EOPNOTSUPP;
|
||||
|
||||
if (IS_ERR(wdev)) {
|
||||
err = PTR_ERR(wdev);
|
||||
if (err != -EINVAL)
|
||||
return err;
|
||||
wdev = NULL;
|
||||
} else if (wdev->wiphy != &rdev->wiphy) {
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
if (!info->attrs[NL80211_ATTR_TESTDATA])
|
||||
return -EINVAL;
|
||||
|
||||
err = -EOPNOTSUPP;
|
||||
if (rdev->ops->testmode_cmd) {
|
||||
rdev->testmode_info = info;
|
||||
err = rdev_testmode_cmd(rdev,
|
||||
rdev->testmode_info = info;
|
||||
err = rdev_testmode_cmd(rdev, wdev,
|
||||
nla_data(info->attrs[NL80211_ATTR_TESTDATA]),
|
||||
nla_len(info->attrs[NL80211_ATTR_TESTDATA]));
|
||||
rdev->testmode_info = NULL;
|
||||
}
|
||||
rdev->testmode_info = NULL;
|
||||
|
||||
return err;
|
||||
}
|
||||
|
@@ -516,11 +516,12 @@ static inline void rdev_rfkill_poll(struct cfg80211_registered_device *rdev)
|
||||
|
||||
#ifdef CONFIG_NL80211_TESTMODE
|
||||
static inline int rdev_testmode_cmd(struct cfg80211_registered_device *rdev,
|
||||
struct wireless_dev *wdev,
|
||||
void *data, int len)
|
||||
{
|
||||
int ret;
|
||||
trace_rdev_testmode_cmd(&rdev->wiphy);
|
||||
ret = rdev->ops->testmode_cmd(&rdev->wiphy, data, len);
|
||||
trace_rdev_testmode_cmd(&rdev->wiphy, wdev);
|
||||
ret = rdev->ops->testmode_cmd(&rdev->wiphy, wdev, data, len);
|
||||
trace_rdev_return_int(&rdev->wiphy, ret);
|
||||
return ret;
|
||||
}
|
||||
|
@@ -1293,15 +1293,17 @@ TRACE_EVENT(rdev_return_int_int,
|
||||
|
||||
#ifdef CONFIG_NL80211_TESTMODE
|
||||
TRACE_EVENT(rdev_testmode_cmd,
|
||||
TP_PROTO(struct wiphy *wiphy),
|
||||
TP_ARGS(wiphy),
|
||||
TP_PROTO(struct wiphy *wiphy, struct wireless_dev *wdev),
|
||||
TP_ARGS(wiphy, wdev),
|
||||
TP_STRUCT__entry(
|
||||
WIPHY_ENTRY
|
||||
WDEV_ENTRY
|
||||
),
|
||||
TP_fast_assign(
|
||||
WIPHY_ASSIGN;
|
||||
WDEV_ASSIGN;
|
||||
),
|
||||
TP_printk(WIPHY_PR_FMT, WIPHY_PR_ARG)
|
||||
TP_printk(WIPHY_PR_FMT WDEV_PR_FMT, WIPHY_PR_ARG, WDEV_PR_ARG)
|
||||
);
|
||||
|
||||
TRACE_EVENT(rdev_testmode_dump,
|
||||
|
Reference in New Issue
Block a user