net: 8390: pcnet_cs: Use setup_timer and mod_timer
Use timer API functions setup_timer and mod_timer instead of structure assignments as they are standard way to set the timer and to update the expire field of an active timer respectively. This is done using Coccinelle and semantic patch used for this is as follows: // <smpl> @@ expression x,y,z,a,b; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); // </smpl> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Este cometimento está contido em:

cometido por
David S. Miller

ascendente
b8b01344eb
cometimento
fc4ba63627
@@ -918,11 +918,8 @@ static int pcnet_open(struct net_device *dev)
|
||||
|
||||
info->phy_id = info->eth_phy;
|
||||
info->link_status = 0x00;
|
||||
init_timer(&info->watchdog);
|
||||
info->watchdog.function = ei_watchdog;
|
||||
info->watchdog.data = (u_long)dev;
|
||||
info->watchdog.expires = jiffies + HZ;
|
||||
add_timer(&info->watchdog);
|
||||
setup_timer(&info->watchdog, ei_watchdog, (u_long)dev);
|
||||
mod_timer(&info->watchdog, jiffies + HZ);
|
||||
|
||||
return ei_open(dev);
|
||||
} /* pcnet_open */
|
||||
|
Criar uma nova questão referindo esta
Bloquear um utilizador