xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remoteproc: Check for NULL firmwares in sysfs interface

Browse Source 
The remoteproc framework provides a sysfs file 'firmware'
for modifying the firmware image name from userspace. Add
an additional check to ensure NULL firmwares are errored
out right away, rather than getting a delayed error while
requesting a firmware during the start of a remoteproc
later on.

Tested-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
This commit is contained in:
Suman Anna
2018-09-14 19:37:22 -05:00
committed by Bjorn Andersson
parent 29a5f9aaf9
commit faeadbb640
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/remoteproc/remoteproc_sysfs.c
View File

@@ -48,6 +48,11 @@ static ssize_t firmware_store(struct device *dev,
} }
len = strcspn(buf, "\n"); len = strcspn(buf, "\n");
if (!len) {
dev_err(dev, "can't provide a NULL firmware\n");
err = -EINVAL;
goto out;
}
p = kstrndup(buf, len, GFP_KERNEL); p = kstrndup(buf, len, GFP_KERNEL);
if (!p) { if (!p) {