sh: fixup many sparse errors.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
This commit is contained in:
@@ -294,9 +294,10 @@ arch_init_clk_ops(struct clk_ops **ops, int type)
|
||||
{
|
||||
}
|
||||
|
||||
void __init __attribute__ ((weak))
|
||||
int __init __attribute__ ((weak))
|
||||
arch_clk_init(void)
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int show_clocks(char *buf, char **start, off_t off,
|
||||
@@ -331,7 +332,7 @@ int __init clk_init(void)
|
||||
ret |= clk_register(clk);
|
||||
}
|
||||
|
||||
arch_clk_init();
|
||||
ret |= arch_clk_init();
|
||||
|
||||
/* Kick the child clocks.. */
|
||||
propagate_rate(&master_clk);
|
||||
|
@@ -81,7 +81,7 @@ void generic_insb(unsigned long port, void *dst, unsigned long count)
|
||||
volatile u8 *port_addr;
|
||||
u8 *buf = dst;
|
||||
|
||||
port_addr = (volatile u8 *)__ioport_map(port, 1);
|
||||
port_addr = (volatile u8 __force *)__ioport_map(port, 1);
|
||||
while (count--)
|
||||
*buf++ = *port_addr;
|
||||
}
|
||||
@@ -91,7 +91,7 @@ void generic_insw(unsigned long port, void *dst, unsigned long count)
|
||||
volatile u16 *port_addr;
|
||||
u16 *buf = dst;
|
||||
|
||||
port_addr = (volatile u16 *)__ioport_map(port, 2);
|
||||
port_addr = (volatile u16 __force *)__ioport_map(port, 2);
|
||||
while (count--)
|
||||
*buf++ = *port_addr;
|
||||
|
||||
@@ -103,7 +103,7 @@ void generic_insl(unsigned long port, void *dst, unsigned long count)
|
||||
volatile u32 *port_addr;
|
||||
u32 *buf = dst;
|
||||
|
||||
port_addr = (volatile u32 *)__ioport_map(port, 4);
|
||||
port_addr = (volatile u32 __force *)__ioport_map(port, 4);
|
||||
while (count--)
|
||||
*buf++ = *port_addr;
|
||||
|
||||
|
@@ -14,6 +14,7 @@
|
||||
#include <linux/string.h>
|
||||
#include <asm/machvec.h>
|
||||
#include <asm/sections.h>
|
||||
#include <asm/setup.h>
|
||||
#include <asm/io.h>
|
||||
#include <asm/irq.h>
|
||||
|
||||
|
@@ -26,6 +26,7 @@
|
||||
#include <asm/system.h>
|
||||
#include <asm/ubc.h>
|
||||
#include <asm/fpu.h>
|
||||
#include <asm/syscalls.h>
|
||||
|
||||
static int hlt_counter;
|
||||
int ubc_usercnt = 0;
|
||||
|
@@ -25,6 +25,7 @@
|
||||
#include <linux/module.h>
|
||||
#include <linux/proc_fs.h>
|
||||
#include <linux/io.h>
|
||||
#include <asm/syscalls.h>
|
||||
#include <asm/uaccess.h>
|
||||
#include <asm/pgtable.h>
|
||||
#include <asm/mmu_context.h>
|
||||
|
@@ -27,6 +27,7 @@
|
||||
#include <asm/system.h>
|
||||
#include <asm/processor.h>
|
||||
#include <asm/mmu_context.h>
|
||||
#include <asm/syscalls.h>
|
||||
|
||||
/*
|
||||
* does not yet catch signals sent when the child dies.
|
||||
@@ -105,6 +106,7 @@ void ptrace_disable(struct task_struct *child)
|
||||
long arch_ptrace(struct task_struct *child, long request, long addr, long data)
|
||||
{
|
||||
struct user * dummy = NULL;
|
||||
unsigned long __user *datap = (unsigned long __user *)data;
|
||||
int ret;
|
||||
|
||||
switch (request) {
|
||||
@@ -133,7 +135,7 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
|
||||
tmp = !!tsk_used_math(child);
|
||||
else
|
||||
tmp = 0;
|
||||
ret = put_user(tmp, (unsigned long __user *)data);
|
||||
ret = put_user(tmp, datap);
|
||||
break;
|
||||
}
|
||||
|
||||
@@ -202,7 +204,7 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
|
||||
}
|
||||
|
||||
ret = 0;
|
||||
if (put_user(tmp, (unsigned long *) data)) {
|
||||
if (put_user(tmp, datap)) {
|
||||
ret = -EFAULT;
|
||||
break;
|
||||
}
|
||||
|
@@ -35,6 +35,7 @@
|
||||
#include <asm/system.h>
|
||||
#include <asm/processor.h>
|
||||
#include <asm/mmu_context.h>
|
||||
#include <asm/syscalls.h>
|
||||
#include <asm/fpu.h>
|
||||
|
||||
/* This mask defines the bits of the SR which the user is not allowed to
|
||||
|
@@ -26,6 +26,7 @@
|
||||
#include <linux/err.h>
|
||||
#include <linux/debugfs.h>
|
||||
#include <linux/crash_dump.h>
|
||||
#include <linux/mmzone.h>
|
||||
#include <asm/uaccess.h>
|
||||
#include <asm/io.h>
|
||||
#include <asm/page.h>
|
||||
|
@@ -30,6 +30,7 @@
|
||||
#include <asm/uaccess.h>
|
||||
#include <asm/pgtable.h>
|
||||
#include <asm/cacheflush.h>
|
||||
#include <asm/syscalls.h>
|
||||
#include <asm/fpu.h>
|
||||
|
||||
#define _BLOCKABLE (~(sigmask(SIGKILL) | sigmask(SIGSTOP)))
|
||||
@@ -247,7 +248,6 @@ asmlinkage int sys_rt_sigreturn(unsigned long r4, unsigned long r5,
|
||||
struct pt_regs *regs = RELOC_HIDE(&__regs, 0);
|
||||
struct rt_sigframe __user *frame = (struct rt_sigframe __user *)regs->regs[15];
|
||||
sigset_t set;
|
||||
stack_t st;
|
||||
int r0;
|
||||
|
||||
if (!access_ok(VERIFY_READ, frame, sizeof(*frame)))
|
||||
@@ -265,11 +265,9 @@ asmlinkage int sys_rt_sigreturn(unsigned long r4, unsigned long r5,
|
||||
if (restore_sigcontext(regs, &frame->uc.uc_mcontext, &r0))
|
||||
goto badframe;
|
||||
|
||||
if (__copy_from_user(&st, &frame->uc.uc_stack, sizeof(st)))
|
||||
if (do_sigaltstack(&frame->uc.uc_stack, NULL,
|
||||
regs->regs[15]) == -EFAULT)
|
||||
goto badframe;
|
||||
/* It is more difficult to avoid calling this function than to
|
||||
call it and ignore errors. */
|
||||
do_sigaltstack((const stack_t __user *)&st, NULL, (unsigned long)frame);
|
||||
|
||||
return r0;
|
||||
|
||||
@@ -429,7 +427,7 @@ static int setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
|
||||
|
||||
/* Create the ucontext. */
|
||||
err |= __put_user(0, &frame->uc.uc_flags);
|
||||
err |= __put_user(0, &frame->uc.uc_link);
|
||||
err |= __put_user(NULL, &frame->uc.uc_link);
|
||||
err |= __put_user((void *)current->sas_ss_sp,
|
||||
&frame->uc.uc_stack.ss_sp);
|
||||
err |= __put_user(sas_ss_flags(regs->regs[15]),
|
||||
|
@@ -23,6 +23,7 @@
|
||||
#include <linux/fs.h>
|
||||
#include <linux/ipc.h>
|
||||
#include <asm/cacheflush.h>
|
||||
#include <asm/syscalls.h>
|
||||
#include <asm/uaccess.h>
|
||||
#include <asm/unistd.h>
|
||||
|
||||
@@ -186,7 +187,7 @@ asmlinkage int sys_ipc(uint call, int first, int second,
|
||||
union semun fourth;
|
||||
if (!ptr)
|
||||
return -EINVAL;
|
||||
if (get_user(fourth.__pad, (void * __user *) ptr))
|
||||
if (get_user(fourth.__pad, (void __user * __user *) ptr))
|
||||
return -EFAULT;
|
||||
return sys_semctl (first, second, third, fourth);
|
||||
}
|
||||
@@ -261,13 +262,13 @@ asmlinkage int sys_ipc(uint call, int first, int second,
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
asmlinkage int sys_uname(struct old_utsname * name)
|
||||
asmlinkage int sys_uname(struct old_utsname __user *name)
|
||||
{
|
||||
int err;
|
||||
if (!name)
|
||||
return -EFAULT;
|
||||
down_read(&uts_sem);
|
||||
err = copy_to_user(name, utsname(), sizeof (*name));
|
||||
err = copy_to_user(name, utsname(), sizeof(*name));
|
||||
up_read(&uts_sem);
|
||||
return err?-EFAULT:0;
|
||||
}
|
||||
|
@@ -16,6 +16,7 @@
|
||||
#include <asm/cacheflush.h>
|
||||
#include <asm/uaccess.h>
|
||||
#include <asm/unistd.h>
|
||||
#include <asm/syscalls.h>
|
||||
|
||||
/*
|
||||
* sys_pipe() is the normal C calling standard for creating
|
||||
@@ -37,13 +38,13 @@ asmlinkage int sys_pipe(unsigned long r4, unsigned long r5,
|
||||
return error;
|
||||
}
|
||||
|
||||
asmlinkage ssize_t sys_pread_wrapper(unsigned int fd, char * buf,
|
||||
asmlinkage ssize_t sys_pread_wrapper(unsigned int fd, char __user *buf,
|
||||
size_t count, long dummy, loff_t pos)
|
||||
{
|
||||
return sys_pread64(fd, buf, count, pos);
|
||||
}
|
||||
|
||||
asmlinkage ssize_t sys_pwrite_wrapper(unsigned int fd, const char * buf,
|
||||
asmlinkage ssize_t sys_pwrite_wrapper(unsigned int fd, const char __user *buf,
|
||||
size_t count, long dummy, loff_t pos)
|
||||
{
|
||||
return sys_pwrite64(fd, buf, count, pos);
|
||||
|
@@ -16,6 +16,7 @@
|
||||
#include <linux/timex.h>
|
||||
#include <linux/sched.h>
|
||||
#include <linux/clockchips.h>
|
||||
#include <linux/mc146818rtc.h> /* for rtc_lock */
|
||||
#include <linux/smp.h>
|
||||
#include <asm/clock.h>
|
||||
#include <asm/rtc.h>
|
||||
|
@@ -174,7 +174,7 @@ static int cmt_timer_init(void)
|
||||
return 0;
|
||||
}
|
||||
|
||||
struct sys_timer_ops cmt_timer_ops = {
|
||||
static struct sys_timer_ops cmt_timer_ops = {
|
||||
.init = cmt_timer_init,
|
||||
.start = cmt_timer_start,
|
||||
.stop = cmt_timer_stop,
|
||||
|
@@ -192,6 +192,7 @@ static int handle_unaligned_ins(opcode_t instruction, struct pt_regs *regs,
|
||||
int ret, index, count;
|
||||
unsigned long *rm, *rn;
|
||||
unsigned char *src, *dst;
|
||||
unsigned char __user *srcu, *dstu;
|
||||
|
||||
index = (instruction>>8)&15; /* 0x0F00 */
|
||||
rn = ®s->regs[index];
|
||||
@@ -206,28 +207,28 @@ static int handle_unaligned_ins(opcode_t instruction, struct pt_regs *regs,
|
||||
case 0: /* mov.[bwl] to/from memory via r0+rn */
|
||||
if (instruction & 8) {
|
||||
/* from memory */
|
||||
src = (unsigned char*) *rm;
|
||||
src += regs->regs[0];
|
||||
dst = (unsigned char*) rn;
|
||||
*(unsigned long*)dst = 0;
|
||||
srcu = (unsigned char __user *)*rm;
|
||||
srcu += regs->regs[0];
|
||||
dst = (unsigned char *)rn;
|
||||
*(unsigned long *)dst = 0;
|
||||
|
||||
#if !defined(__LITTLE_ENDIAN__)
|
||||
dst += 4-count;
|
||||
#endif
|
||||
if (ma->from(dst, src, count))
|
||||
if (ma->from(dst, srcu, count))
|
||||
goto fetch_fault;
|
||||
|
||||
sign_extend(count, dst);
|
||||
} else {
|
||||
/* to memory */
|
||||
src = (unsigned char*) rm;
|
||||
src = (unsigned char *)rm;
|
||||
#if !defined(__LITTLE_ENDIAN__)
|
||||
src += 4-count;
|
||||
#endif
|
||||
dst = (unsigned char*) *rn;
|
||||
dst += regs->regs[0];
|
||||
dstu = (unsigned char __user *)*rn;
|
||||
dstu += regs->regs[0];
|
||||
|
||||
if (ma->to(dst, src, count))
|
||||
if (ma->to(dstu, src, count))
|
||||
goto fetch_fault;
|
||||
}
|
||||
ret = 0;
|
||||
@@ -235,10 +236,10 @@ static int handle_unaligned_ins(opcode_t instruction, struct pt_regs *regs,
|
||||
|
||||
case 1: /* mov.l Rm,@(disp,Rn) */
|
||||
src = (unsigned char*) rm;
|
||||
dst = (unsigned char*) *rn;
|
||||
dst += (instruction&0x000F)<<2;
|
||||
dstu = (unsigned char __user *)*rn;
|
||||
dstu += (instruction&0x000F)<<2;
|
||||
|
||||
if (ma->to(dst, src, 4))
|
||||
if (ma->to(dstu, src, 4))
|
||||
goto fetch_fault;
|
||||
ret = 0;
|
||||
break;
|
||||
@@ -247,28 +248,28 @@ static int handle_unaligned_ins(opcode_t instruction, struct pt_regs *regs,
|
||||
if (instruction & 4)
|
||||
*rn -= count;
|
||||
src = (unsigned char*) rm;
|
||||
dst = (unsigned char*) *rn;
|
||||
dstu = (unsigned char __user *)*rn;
|
||||
#if !defined(__LITTLE_ENDIAN__)
|
||||
src += 4-count;
|
||||
#endif
|
||||
if (ma->to(dst, src, count))
|
||||
if (ma->to(dstu, src, count))
|
||||
goto fetch_fault;
|
||||
ret = 0;
|
||||
break;
|
||||
|
||||
case 5: /* mov.l @(disp,Rm),Rn */
|
||||
src = (unsigned char*) *rm;
|
||||
src += (instruction&0x000F)<<2;
|
||||
dst = (unsigned char*) rn;
|
||||
*(unsigned long*)dst = 0;
|
||||
srcu = (unsigned char __user *)*rm;
|
||||
srcu += (instruction & 0x000F) << 2;
|
||||
dst = (unsigned char *)rn;
|
||||
*(unsigned long *)dst = 0;
|
||||
|
||||
if (ma->from(dst, src, 4))
|
||||
if (ma->from(dst, srcu, 4))
|
||||
goto fetch_fault;
|
||||
ret = 0;
|
||||
break;
|
||||
|
||||
case 6: /* mov.[bwl] from memory, possibly with post-increment */
|
||||
src = (unsigned char*) *rm;
|
||||
srcu = (unsigned char __user *)*rm;
|
||||
if (instruction & 4)
|
||||
*rm += count;
|
||||
dst = (unsigned char*) rn;
|
||||
@@ -277,7 +278,7 @@ static int handle_unaligned_ins(opcode_t instruction, struct pt_regs *regs,
|
||||
#if !defined(__LITTLE_ENDIAN__)
|
||||
dst += 4-count;
|
||||
#endif
|
||||
if (ma->from(dst, src, count))
|
||||
if (ma->from(dst, srcu, count))
|
||||
goto fetch_fault;
|
||||
sign_extend(count, dst);
|
||||
ret = 0;
|
||||
@@ -286,28 +287,28 @@ static int handle_unaligned_ins(opcode_t instruction, struct pt_regs *regs,
|
||||
case 8:
|
||||
switch ((instruction&0xFF00)>>8) {
|
||||
case 0x81: /* mov.w R0,@(disp,Rn) */
|
||||
src = (unsigned char*) ®s->regs[0];
|
||||
src = (unsigned char *) ®s->regs[0];
|
||||
#if !defined(__LITTLE_ENDIAN__)
|
||||
src += 2;
|
||||
#endif
|
||||
dst = (unsigned char*) *rm; /* called Rn in the spec */
|
||||
dst += (instruction&0x000F)<<1;
|
||||
dstu = (unsigned char __user *)*rm; /* called Rn in the spec */
|
||||
dstu += (instruction & 0x000F) << 1;
|
||||
|
||||
if (ma->to(dst, src, 2))
|
||||
if (ma->to(dstu, src, 2))
|
||||
goto fetch_fault;
|
||||
ret = 0;
|
||||
break;
|
||||
|
||||
case 0x85: /* mov.w @(disp,Rm),R0 */
|
||||
src = (unsigned char*) *rm;
|
||||
src += (instruction&0x000F)<<1;
|
||||
dst = (unsigned char*) ®s->regs[0];
|
||||
*(unsigned long*)dst = 0;
|
||||
srcu = (unsigned char __user *)*rm;
|
||||
srcu += (instruction & 0x000F) << 1;
|
||||
dst = (unsigned char *) ®s->regs[0];
|
||||
*(unsigned long *)dst = 0;
|
||||
|
||||
#if !defined(__LITTLE_ENDIAN__)
|
||||
dst += 2;
|
||||
#endif
|
||||
if (ma->from(dst, src, 2))
|
||||
if (ma->from(dst, srcu, 2))
|
||||
goto fetch_fault;
|
||||
sign_extend(2, dst);
|
||||
ret = 0;
|
||||
@@ -333,7 +334,8 @@ static inline int handle_delayslot(struct pt_regs *regs,
|
||||
struct mem_access *ma)
|
||||
{
|
||||
opcode_t instruction;
|
||||
void *addr = (void *)(regs->pc + instruction_size(old_instruction));
|
||||
void __user *addr = (void __user *)(regs->pc +
|
||||
instruction_size(old_instruction));
|
||||
|
||||
if (copy_from_user(&instruction, addr, sizeof(instruction))) {
|
||||
/* the instruction-fetch faulted */
|
||||
@@ -559,7 +561,7 @@ asmlinkage void do_address_error(struct pt_regs *regs,
|
||||
}
|
||||
|
||||
set_fs(USER_DS);
|
||||
if (copy_from_user(&instruction, (void *)(regs->pc),
|
||||
if (copy_from_user(&instruction, (void __user *)(regs->pc),
|
||||
sizeof(instruction))) {
|
||||
/* Argh. Fault on the instruction itself.
|
||||
This should never happen non-SMP
|
||||
@@ -589,7 +591,7 @@ uspace_segv:
|
||||
die("unaligned program counter", regs, error_code);
|
||||
|
||||
set_fs(KERNEL_DS);
|
||||
if (copy_from_user(&instruction, (void *)(regs->pc),
|
||||
if (copy_from_user(&instruction, (void __user *)(regs->pc),
|
||||
sizeof(instruction))) {
|
||||
/* Argh. Fault on the instruction itself.
|
||||
This should never happen non-SMP
|
||||
|
Reference in New Issue
Block a user